Refactor the put_request method to have a return value

This commit is contained in:
Greg Karékinian
2018-05-09 16:01:14 +02:00
parent 709f63555d
commit 639c3724f0
2 changed files with 15 additions and 17 deletions

View File

@@ -141,7 +141,7 @@ module RemoteStorage
server.halt 412, "Precondition Failed" unless existing_metadata.empty?
end
etag, timestamp = do_put_request_and_return_etag_and_last_modified(url, data, content_type)
etag, timestamp = do_put_request(url, data, content_type)
metadata = {
e: etag,
@@ -392,16 +392,15 @@ module RemoteStorage
def do_put_request(url, data, content_type)
deal_with_unauthorized_requests do
RestClient.put(url, data, default_headers.merge({content_type: content_type}))
res = RestClient.put(url, data, default_headers.merge({content_type: content_type}))
return [
res.headers[:etag],
timestamp_for(res.headers[:last_modified])
]
end
end
def do_put_request_and_return_etag_and_last_modified(url, data, content_type)
res = do_put_request(url, data, content_type)
return [res.headers[:etag], timestamp_for(res.headers[:last_modified])]
end
def do_get_request(url, &block)
deal_with_unauthorized_requests do
RestClient.get(url, default_headers, &block)