5apps/liquor-cabinet
5apps/liquor-cabinet
4
0
Fork 0
Code Issues 1 Pull Requests Packages Releases Activity

Don't use or create any directory objects in Swift

Browse Source
This commit is contained in:
Garret Alfert 2016-03-04 15:33:28 +01:00
parent 14a522f09f
commit d08bc45489
2 changed files with 111 additions and 237 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

205
lib/remote_storage/swift.rb
View File

@ -29,7 +29,6 @@ module RemoteStorage
server.halt 401 unless permission server.halt 401 unless permission
if ["PUT", "DELETE"].include? request_method if ["PUT", "DELETE"].include? request_method
server.halt 503 if directory_backend(user).match(/locked/)
server.halt 401 unless permission == "rw" server.halt 401 unless permission == "rw"
end end
end end
@ -60,28 +59,37 @@ module RemoteStorage
end end
def get_head_directory_listing(user, directory) def get_head_directory_listing(user, directory)
is_root_listing = directory.empty? get_directory_listing(user, directory)
if is_root_listing
# We need to calculate the etag ourselves
res = do_get_request("#{url_for_directory(user, directory)}/?format=json")
etag = etag_for(res.body)
else
res = do_head_request("#{url_for_directory(user, directory)}/")
etag = res.headers[:etag]
end
server.headers["Content-Type"] = "application/json" "" # just return empty body, headers are set by get_directory_listing
server.headers["ETag"] = %Q("#{etag}")
rescue RestClient::ResourceNotFound
server.halt 404
end end
def get_directory_listing(user, directory) def get_directory_listing(user, directory)
if directory_backend(user).match(/new/) etag = redis.hget "rs:m:#{user}:#{directory}/", "e"
get_directory_listing_from_redis(user, directory)
server.headers["Content-Type"] = "application/json"
none_match = (server.env["HTTP_IF_NONE_MATCH"] || "").split(",").map(&:strip)
if etag
server.halt 304 if none_match.include? etag
items = get_directory_listing_from_redis_via_lua(user, directory)
else else
get_directory_listing_from_swift(user, directory) etag = etag_for(user, directory)
items = {}
server.halt 304 if none_match.include? etag
end end
server.headers["ETag"] = %Q("#{etag}")
listing = {
"@context" => "http://remotestorage.io/spec/folder-description",
"items" => items
}
listing.to_json
end end
def get_directory_listing_from_redis_via_lua(user, directory) def get_directory_listing_from_redis_via_lua(user, directory)
@ -121,76 +129,22 @@ module RemoteStorage
JSON.parse(redis.eval(lua_script, nil, [user, directory])) JSON.parse(redis.eval(lua_script, nil, [user, directory]))
end end
def get_directory_listing_from_redis(user, directory)
etag = redis.hget "rs:m:#{user}:#{directory}/", "e"
none_match = (server.env["HTTP_IF_NONE_MATCH"] || "").split(",").map(&:strip)
server.halt 304 if none_match.include? etag
server.headers["Content-Type"] = "application/json"
server.headers["ETag"] = %Q("#{etag}")
listing = {
"@context" => "http://remotestorage.io/spec/folder-description",
"items" => get_directory_listing_from_redis_via_lua(user, directory)
}
listing.to_json
end
def get_directory_listing_from_swift(user, directory)
is_root_listing = directory.empty?
server.headers["Content-Type"] = "application/json"
etag, get_response = nil
do_head_request("#{url_for_directory(user, directory)}/") do |response|
return directory_listing([]).to_json if response.code == 404
if is_root_listing
get_response = do_get_request("#{container_url_for(user)}/?format=json&path=")
etag = etag_for(get_response.body)
else
get_response = do_get_request("#{container_url_for(user)}/?format=json&path=#{escape(directory)}/")
etag = response.headers[:etag]
end
none_match = (server.env["HTTP_IF_NONE_MATCH"] || "").split(",").map(&:strip)
server.halt 304 if none_match.include? %Q("#{etag}")
end
server.headers["ETag"] = %Q("#{etag}")
if body = JSON.parse(get_response.body)
listing = directory_listing(body)
else
puts "listing not JSON"
end
listing.to_json
end
def put_data(user, directory, key, data, content_type) def put_data(user, directory, key, data, content_type)
server.halt 409 if has_name_collision?(user, directory, key) server.halt 409 if has_name_collision?(user, directory, key)
existing_metadata = redis.hgetall "rs:m:#{user}:#{directory}/#{key}"
url = url_for_key(user, directory, key) url = url_for_key(user, directory, key)
if required_match = server.env["HTTP_IF_MATCH"] if required_match = server.env["HTTP_IF_MATCH"]
do_head_request(url) do |response| server.halt 412 unless required_match == %Q("#{existing_metadata["e"]}")
server.halt 412 unless required_match == %Q("#{response.headers[:etag]}")
end
end end
if server.env["HTTP_IF_NONE_MATCH"] == "*" if server.env["HTTP_IF_NONE_MATCH"] == "*"
do_head_request(url) do |response| server.halt 412 unless existing_metadata.empty?
server.halt 412 unless response.code == 404
end
end end
res = do_put_request(url, data, content_type) res = do_put_request(url, data, content_type)
# TODO use actual last modified time from the document put request timestamp = timestamp_for(res.headers[:last_modified])
timestamp = (Time.now.to_f * 1000).to_i
metadata = { metadata = {
e: res.headers[:etag], e: res.headers[:etag],
@ -199,8 +153,11 @@ module RemoteStorage
m: timestamp m: timestamp
} }
if update_metadata_object(user, directory, key, metadata) && if update_metadata_object(user, directory, key, metadata)
if metadata_changed?(existing_metadata, metadata)
update_dir_objects(user, directory, timestamp) update_dir_objects(user, directory, timestamp)
end
server.headers["ETag"] = %Q("#{res.headers[:etag]}") server.headers["ETag"] = %Q("#{res.headers[:etag]}")
server.halt 200 server.halt 200
else else
@ -211,10 +168,10 @@ module RemoteStorage
def delete_data(user, directory, key) def delete_data(user, directory, key)
url = url_for_key(user, directory, key) url = url_for_key(user, directory, key)
existing_metadata = redis.hgetall "rs:m:#{user}:#{directory}/#{key}"
if required_match = server.env["HTTP_IF_MATCH"] if required_match = server.env["HTTP_IF_MATCH"]
do_head_request(url) do |response| server.halt 412 unless required_match == %Q("#{existing_metadata["e"]}")
server.halt 412 unless required_match == %Q("#{response.headers[:etag]}")
end
end end
do_delete_request(url) do_delete_request(url)
@ -293,14 +250,6 @@ module RemoteStorage
end end
def has_name_collision?(user, directory, key) def has_name_collision?(user, directory, key)
if directory_backend(user).match(/new/)
has_name_collision_via_redis?(user, directory, key)
else
has_name_collision_via_swift?(user, directory, key)
end
end
def has_name_collision_via_redis?(user, directory, key)
lua_script = <<-EOF lua_script = <<-EOF
local user = ARGV[1] local user = ARGV[1]
local directory = ARGV[2] local directory = ARGV[2]
@ -344,31 +293,17 @@ module RemoteStorage
redis.eval(lua_script, nil, [user, directory, key, *parent_directories]) redis.eval(lua_script, nil, [user, directory, key, *parent_directories])
end end
def has_name_collision_via_swift?(user, directory, key) def metadata_changed?(old_metadata, new_metadata)
# check for existing directory with the same name as the document # check metadata relevant to the directory listing
url = url_for_key(user, directory, key) # ie. the timestamp (m) is not relevant, because it's not used in
do_head_request("#{url}/") do |res| # the listing
return true if res.code == 200 return old_metadata["e"] != new_metadata[:e] ||
old_metadata["s"] != new_metadata[:s].to_s ||
old_metadata["t"] != new_metadata[:t]
end end
# check for existing documents with the same name as one of the parent directories def timestamp_for(date)
parent_directories_for(directory).each do |dir| return DateTime.parse(date).strftime("%Q").to_i
do_head_request("#{url_for_directory(user, dir)}/") do |res_dir|
if res_dir.code == 200
return false
else
do_head_request("#{url_for_directory(user, dir)}") do |res_key|
if res_key.code == 200
return true
else
next
end
end
end
end
end
false
end end
def parent_directories_for(directory) def parent_directories_for(directory)
@ -411,29 +346,13 @@ module RemoteStorage
def update_dir_objects(user, directory, timestamp) def update_dir_objects(user, directory, timestamp)
parent_directories_for(directory).each do |dir| parent_directories_for(directory).each do |dir|
unless dir == "" etag = etag_for(dir, timestamp)
res = do_put_request("#{url_for_directory(user, dir)}/", timestamp.to_s, "text/plain")
etag = res.headers[:etag]
else
get_response = do_get_request("#{container_url_for(user)}/?format=json&path=")
etag = etag_for(get_response.body)
end
key = "rs:m:#{user}:#{dir}/" key = "rs:m:#{user}:#{dir}/"
metadata = {e: etag, m: timestamp} metadata = {e: etag, m: timestamp}
redis.hmset(key, *metadata) redis.hmset(key, *metadata)
redis.sadd "rs:m:#{user}:#{parent_directory_for(dir)}:items", "#{top_directory(dir)}/" redis.sadd "rs:m:#{user}:#{parent_directory_for(dir)}:items", "#{top_directory(dir)}/"
end end
true
rescue
parent_directories_for(directory).each do |dir|
unless dir == ""
do_delete_request("#{url_for_directory(user, dir)}/") rescue false
end
end
false
end end
def delete_metadata_objects(user, directory, key) def delete_metadata_objects(user, directory, key)
@ -447,19 +366,11 @@ module RemoteStorage
parent_directories_for(directory).each do |dir| parent_directories_for(directory).each do |dir|
if dir_empty?(user, dir) if dir_empty?(user, dir)
unless dir == ""
do_delete_request("#{url_for_directory(user, dir)}/")
end
redis.del "rs:m:#{user}:#{directory}/" redis.del "rs:m:#{user}:#{directory}/"
redis.srem "rs:m:#{user}:#{parent_directory_for(dir)}:items", "#{dir}/" redis.srem "rs:m:#{user}:#{parent_directory_for(dir)}:items", "#{dir}/"
else else
unless dir == "" etag = etag_for(dir, timestamp)
res = do_put_request("#{url_for_directory(user, dir)}/", timestamp.to_s, "text/plain")
etag = res.headers[:etag]
else
get_response = do_get_request("#{container_url_for(user)}/?format=json&path=")
etag = etag_for(get_response.body)
end
metadata = {e: etag, m: timestamp} metadata = {e: etag, m: timestamp}
redis.hmset("rs:m:#{user}:#{dir}/", *metadata) redis.hmset("rs:m:#{user}:#{dir}/", *metadata)
end end
@ -467,13 +378,7 @@ module RemoteStorage
end end
def dir_empty?(user, dir) def dir_empty?(user, dir)
if directory_backend(user).match(/new/)
redis.smembers("rs:m:#{user}:#{dir}/:items").empty? redis.smembers("rs:m:#{user}:#{dir}/:items").empty?
else
do_get_request("#{container_url_for(user)}/?format=plain&limit=1&path=#{escape(dir)}/") do |res|
return res.headers[:content_length] == "0"
end
end
end end
def container_url_for(user) def container_url_for(user)
@ -537,18 +442,8 @@ module RemoteStorage
@redis ||= Redis.new(settings.redis.symbolize_keys) @redis ||= Redis.new(settings.redis.symbolize_keys)
end end
def directory_backend(user) def etag_for(*args)
@directory_backend ||= redis.get("rsc:db:#{user}") || "legacy" Digest::MD5.hexdigest args.join(":")
end
def etag_for(body)
objects = JSON.parse(body)
if objects.empty?
Digest::MD5.hexdigest ''
else
Digest::MD5.hexdigest objects.map { |o| o["hash"] }.join
end
end end
def reload_swift_token def reload_swift_token

137
spec/swift/app_spec.rb
View File

@ -16,7 +16,6 @@ describe "App" do
before do before do
purge_redis purge_redis
redis.set "rsc:db:phil", "new"
end end
context "authorized" do context "authorized" do
@ -26,7 +25,11 @@ describe "App" do
end end
it "creates the metadata object in redis" do it "creates the metadata object in redis" do
put_stub = OpenStruct.new(headers: {etag: "bla"}) put_stub = OpenStruct.new(headers: {
etag: "bla",
last_modified: "Fri, 04 Mar 2016 12:20:18 GMT"
})
RestClient.stub :put, put_stub do RestClient.stub :put, put_stub do
put "/phil/food/aguacate", "si" put "/phil/food/aguacate", "si"
end end
@ -39,11 +42,15 @@ describe "App" do
end end
it "creates the directory objects metadata in redis" do it "creates the directory objects metadata in redis" do
put_stub = OpenStruct.new(headers: {etag: "bla"}) put_stub = OpenStruct.new(headers: {
etag: "bla",
last_modified: "Fri, 04 Mar 2016 12:20:18 GMT"
})
get_stub = OpenStruct.new(body: "rootbody") get_stub = OpenStruct.new(body: "rootbody")
RestClient.stub :put, put_stub do RestClient.stub :put, put_stub do
RestClient.stub :get, get_stub do RestClient.stub :get, get_stub do
RemoteStorage::Swift.stub_any_instance :etag_for, "rootetag" do RemoteStorage::Swift.stub_any_instance :etag_for, "newetag" do
put "/phil/food/aguacate", "si" put "/phil/food/aguacate", "si"
put "/phil/food/camaron", "yummi" put "/phil/food/camaron", "yummi"
end end
@ -51,11 +58,11 @@ describe "App" do
end end
metadata = redis.hgetall "rs:m:phil:/" metadata = redis.hgetall "rs:m:phil:/"
metadata["e"].must_equal "rootetag" metadata["e"].must_equal "newetag"
metadata["m"].length.must_equal 13 metadata["m"].length.must_equal 13
metadata = redis.hgetall "rs:m:phil:food/" metadata = redis.hgetall "rs:m:phil:food/"
metadata["e"].must_equal "bla" metadata["e"].must_equal "newetag"
metadata["m"].length.must_equal 13 metadata["m"].length.must_equal 13
food_items = redis.smembers "rs:m:phil:food/:items" food_items = redis.smembers "rs:m:phil:food/:items"
@ -69,8 +76,12 @@ describe "App" do
describe "name collision checks" do describe "name collision checks" do
it "is successful when there is no name collision" do it "is successful when there is no name collision" do
put_stub = OpenStruct.new(headers: {etag: "bla"}) put_stub = OpenStruct.new(headers: {
etag: "bla",
last_modified: "Fri, 04 Mar 2016 12:20:18 GMT"
})
get_stub = OpenStruct.new(body: "rootbody") get_stub = OpenStruct.new(body: "rootbody")
RestClient.stub :put, put_stub do RestClient.stub :put, put_stub do
RestClient.stub :get, get_stub do RestClient.stub :get, get_stub do
RemoteStorage::Swift.stub_any_instance :etag_for, "rootetag" do RemoteStorage::Swift.stub_any_instance :etag_for, "rootetag" do
@ -86,7 +97,11 @@ describe "App" do
end end
it "conflicts when there is a directory with same name as document" do it "conflicts when there is a directory with same name as document" do
put_stub = OpenStruct.new(headers: {etag: "bla"}) put_stub = OpenStruct.new(headers: {
etag: "bla",
last_modified: "Fri, 04 Mar 2016 12:20:18 GMT"
})
RestClient.stub :put, put_stub do RestClient.stub :put, put_stub do
put "/phil/food/aguacate", "si" put "/phil/food/aguacate", "si"
put "/phil/food", "wontwork" put "/phil/food", "wontwork"
@ -99,7 +114,11 @@ describe "App" do
end end
it "conflicts when there is a document with same name as directory" do it "conflicts when there is a document with same name as directory" do
put_stub = OpenStruct.new(headers: {etag: "bla"}) put_stub = OpenStruct.new(headers: {
etag: "bla",
last_modified: "Fri, 04 Mar 2016 12:20:18 GMT"
})
RestClient.stub :put, put_stub do RestClient.stub :put, put_stub do
put "/phil/food/aguacate", "si" put "/phil/food/aguacate", "si"
put "/phil/food/aguacate/empanado", "wontwork" put "/phil/food/aguacate/empanado", "wontwork"
@ -111,38 +130,6 @@ describe "App" do
metadata.must_be_empty metadata.must_be_empty
end end
end end
describe "directory backend configuration" do
context "locked new backed" do
before do
redis.set "rsc:db:phil", "new-locked"
end
it "responds with 503" do
put "/phil/food/aguacate", "si"
last_response.status.must_equal 503
metadata = redis.hgetall "rs:m:phil:food/aguacate"
metadata.must_be_empty
end
end
context "locked legacy backend" do
before do
redis.set "rsc:db:phil", "legacy-locked"
end
it "responds with 503" do
put "/phil/food/aguacate", "si"
last_response.status.must_equal 503
metadata = redis.hgetall "rs:m:phil:food/aguacate"
metadata.must_be_empty
end
end
end
end end
end end
@ -150,7 +137,6 @@ describe "App" do
before do before do
purge_redis purge_redis
redis.set "rsc:db:phil", "new"
end end
context "authorized" do context "authorized" do
@ -158,7 +144,11 @@ describe "App" do
redis.sadd "authorizations:phil:amarillo", [":rw"] redis.sadd "authorizations:phil:amarillo", [":rw"]
header "Authorization", "Bearer amarillo" header "Authorization", "Bearer amarillo"
put_stub = OpenStruct.new(headers: {etag: "bla"}) put_stub = OpenStruct.new(headers: {
etag: "bla",
last_modified: "Fri, 04 Mar 2016 12:20:18 GMT"
})
RestClient.stub :put, put_stub do RestClient.stub :put, put_stub do
put "/phil/food/aguacate", "si" put "/phil/food/aguacate", "si"
put "/phil/food/camaron", "yummi" put "/phil/food/camaron", "yummi"
@ -166,8 +156,12 @@ describe "App" do
end end
it "deletes the metadata object in redis" do it "deletes the metadata object in redis" do
put_stub = OpenStruct.new(headers: {etag: "bla"}) put_stub = OpenStruct.new(headers: {
etag: "bla",
last_modified: "Fri, 04 Mar 2016 12:20:18 GMT"
})
get_stub = OpenStruct.new(body: "rootbody") get_stub = OpenStruct.new(body: "rootbody")
RestClient.stub :put, put_stub do RestClient.stub :put, put_stub do
RestClient.stub :delete, "" do RestClient.stub :delete, "" do
RestClient.stub :get, get_stub do RestClient.stub :get, get_stub do
@ -185,12 +179,16 @@ describe "App" do
it "deletes the directory objects metadata in redis" do it "deletes the directory objects metadata in redis" do
old_metadata = redis.hgetall "rs:m:phil:food/" old_metadata = redis.hgetall "rs:m:phil:food/"
put_stub = OpenStruct.new(headers: {etag: "newetag"}) put_stub = OpenStruct.new(headers: {
etag: "bla",
last_modified: "Fri, 04 Mar 2016 12:20:18 GMT"
})
get_stub = OpenStruct.new(body: "rootbody") get_stub = OpenStruct.new(body: "rootbody")
RestClient.stub :put, put_stub do RestClient.stub :put, put_stub do
RestClient.stub :delete, "" do RestClient.stub :delete, "" do
RestClient.stub :get, get_stub do RestClient.stub :get, get_stub do
RemoteStorage::Swift.stub_any_instance :etag_for, "rootetag" do RemoteStorage::Swift.stub_any_instance :etag_for, "newetag" do
delete "/phil/food/aguacate" delete "/phil/food/aguacate"
end end
end end
@ -210,8 +208,12 @@ describe "App" do
end end
it "deletes the parent directory objects metadata when deleting all items" do it "deletes the parent directory objects metadata when deleting all items" do
put_stub = OpenStruct.new(headers: {etag: "bla"}) put_stub = OpenStruct.new(headers: {
etag: "bla",
last_modified: "Fri, 04 Mar 2016 12:20:18 GMT"
})
get_stub = OpenStruct.new(body: "rootbody") get_stub = OpenStruct.new(body: "rootbody")
RestClient.stub :put, put_stub do RestClient.stub :put, put_stub do
RestClient.stub :delete, "" do RestClient.stub :delete, "" do
RestClient.stub :get, get_stub do RestClient.stub :get, get_stub do
@ -239,7 +241,6 @@ describe "App" do
before do before do
purge_redis purge_redis
redis.set "rsc:db:phil", "new"
end end
context "authorized" do context "authorized" do
@ -248,7 +249,11 @@ describe "App" do
redis.sadd "authorizations:phil:amarillo", [":rw"] redis.sadd "authorizations:phil:amarillo", [":rw"]
header "Authorization", "Bearer amarillo" header "Authorization", "Bearer amarillo"
put_stub = OpenStruct.new(headers: {etag: "bla"}) put_stub = OpenStruct.new(headers: {
etag: "bla",
last_modified: "Fri, 04 Mar 2016 12:20:18 GMT"
})
RestClient.stub :put, put_stub do RestClient.stub :put, put_stub do
put "/phil/food/aguacate", "si" put "/phil/food/aguacate", "si"
put "/phil/food/camaron", "yummi" put "/phil/food/camaron", "yummi"
@ -262,11 +267,11 @@ describe "App" do
get "/phil/food/" get "/phil/food/"
last_response.status.must_equal 200 last_response.status.must_equal 200
last_response.headers["ETag"].must_equal "\"bla\"" last_response.headers["ETag"].must_equal "\"a693babe4b4027de2340b4f1c362d2c8\""
end end
it "responds with 304 when IF_NONE_MATCH header contains the ETag" do it "responds with 304 when IF_NONE_MATCH header contains the ETag" do
header "If-None-Match", "bla" header "If-None-Match", "a693babe4b4027de2340b4f1c362d2c8"
get "/phil/food/" get "/phil/food/"
last_response.status.must_equal 304 last_response.status.must_equal 304
@ -289,7 +294,7 @@ describe "App" do
content["items"]["camaron"]["Content-Length"].must_equal 5 content["items"]["camaron"]["Content-Length"].must_equal 5
content["items"]["camaron"]["ETag"].must_equal "bla" content["items"]["camaron"]["ETag"].must_equal "bla"
content["items"]["desunyos/"].wont_be_nil content["items"]["desunyos/"].wont_be_nil
content["items"]["desunyos/"]["ETag"].must_equal "bla" content["items"]["desunyos/"]["ETag"].must_equal "5e17228c28f15521416812ecac6f718e"
end end
it "contains all items in the root directory" do it "contains all items in the root directory" do
@ -300,38 +305,12 @@ describe "App" do
content = JSON.parse(last_response.body) content = JSON.parse(last_response.body)
content["items"]["food/"].wont_be_nil content["items"]["food/"].wont_be_nil
content["items"]["food/"]["ETag"].must_equal "bla" content["items"]["food/"]["ETag"].must_equal "a693babe4b4027de2340b4f1c362d2c8"
end end
end end
end end
context "with legacy directory backend" do
before do
redis.sadd "authorizations:phil:amarillo", [":rw"]
header "Authorization", "Bearer amarillo"
put_stub = OpenStruct.new(headers: {etag: "bla"})
RestClient.stub :put, put_stub do
put "/phil/food/aguacate", "si"
put "/phil/food/camaron", "yummi"
end
redis.set "rsc:db:phil", "legacy"
end
it "serves directory listing from Swift backend" do
RemoteStorage::Swift.stub_any_instance :get_directory_listing_from_swift, "directory listing" do
get "/phil/food/"
end
last_response.status.must_equal 200
last_response.body.must_equal "directory listing"
end
end
end end
end end