5apps/manifique
4
0
Fork 0
Code Issues Pull Requests Releases 3 Activity

Refactor icon parsing, add apple touch icons

Browse Source
This commit is contained in:
Basti
2018-07-04 09:27:03 +02:00
parent 87baa5960c
commit 44bf2404f6
3 changed files with 42 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
spec/fixtures/mastodon-no-manifest.html vendored
View File

@@ -6,6 +6,7 @@
<meta name="description" content="A friendly place for tooting">
<link href='/favicon.ico' rel='icon' type='image/x-icon'>
<link href='/apple-touch-icon.png' rel='apple-touch-icon' sizes='180x180'>
<link href='/apple-touch-icon-57px.png' rel='apple-touch-icon' sizes='57x57'>
<link color='#2b90d9' href='/mask-icon.svg' rel='mask-icon'>
<meta content='/browserconfig.xml' name='msapplication-config'>
<meta content='#282c37' name='theme-color'>

19
spec/manifique/web_client_spec.rb
View File

@@ -160,16 +160,31 @@ RSpec.describe Manifique::WebClient do
subject { web_client.fetch_metadata }
it "returns a metadata object with the HTML properties loaded" do
it "returns a metadata object" do
expect(subject).to be_kind_of(Manifique::Metadata)
end
it "loads properties from parsed HTML" do
expect(subject.name).to eq("kosmos.social")
expect(subject.description).to eq("A friendly place for tooting")
expect(subject.theme_color).to eq("#282c37")
expect(subject.display).to eq("standalone")
end
it "loads icons from link[rel=icon] elements" do
png_icons = subject.icons.select{|i| i["type"] == "image/png"}
expect(png_icons.length).to eq(5)
expect(png_icons.length).to eq(7)
expect(subject.icons.find{|i| i["sizes"] == "512x512"}["src"]).to eq( "/application_icon_x512.png")
end
it "loads icons from link[rel=apple-touch-icon] elements" do
apple_touch_icons = subject.icons.select{|i| i["purpose"] == "apple-touch-icon"}
expect(apple_touch_icons.length).to eq(2)
expect(apple_touch_icons.first["type"]).to eq("image/png")
expect(apple_touch_icons.first["sizes"]).to eq("180x180")
end
it "loads mask icons from link[rel=mask-icon] elements" do
mask_icon = subject.icons.find{|i| i["purpose"] == "mask-icon"}
expect(mask_icon["color"]).to eq("#2b90d9")
expect(mask_icon["type"]).to eq("image/svg")