From cee7f7e174692d0b5ac79b85df1f172e696a94d4 Mon Sep 17 00:00:00 2001 From: Sebastian Kippe Date: Wed, 4 Jul 2018 08:58:49 +0200 Subject: [PATCH] Make client's internal methods private --- lib/manifique/web_client.rb | 4 ++-- spec/manifique/web_client_spec.rb | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/manifique/web_client.rb b/lib/manifique/web_client.rb index 7d83488..0e5e66c 100644 --- a/lib/manifique/web_client.rb +++ b/lib/manifique/web_client.rb @@ -26,6 +26,8 @@ module Manifique @metadata end + private + def fetch_website res = do_get_request @url @html = Nokogiri::HTML(res.body) @@ -46,8 +48,6 @@ module Manifique JSON.parse(res.body) end - private - def parse_metadata_from_html parse_title_from_html parse_meta_elements_from_html diff --git a/spec/manifique/web_client_spec.rb b/spec/manifique/web_client_spec.rb index 4db4d30..bd8d9eb 100644 --- a/spec/manifique/web_client_spec.rb +++ b/spec/manifique/web_client_spec.rb @@ -60,7 +60,7 @@ RSpec.describe Manifique::WebClient do "Content-Type": "text/html; charset=utf-8" }) - web_client.fetch_website + web_client.send(:fetch_website) end it "instantiates an HTML parser object" do @@ -86,11 +86,11 @@ RSpec.describe Manifique::WebClient do "Content-Type": "application/json; charset=utf-8" }) - web_client.fetch_website + web_client.send(:fetch_website) end subject do - web_client.fetch_web_manifest + web_client.send(:fetch_web_manifest) end it "returns the fetched manifest as a hash" do @@ -107,11 +107,11 @@ RSpec.describe Manifique::WebClient do "Content-Type": "text/html; charset=utf-8" }) - web_client.fetch_website + web_client.send(:fetch_website) end subject do - web_client.fetch_web_manifest + web_client.send(:fetch_web_manifest) end it "returns false" do