5apps/manifique
5apps/manifique
4
0
Fork 0
Code Issues Pull Requests Releases 3 Activity

Don't break on icon size "any" #5

Merged
raucao merged 1 commits from bugfix/size_any into master 2024-08-14 13:52:04 +00:00
Conversation 0 Commits 1 Files Changed 2 +2 -1
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/manifique/metadata.rb
View File

@ -47,7 +47,7 @@ module Manifique
end end
if options[:sizes] if options[:sizes]
results.reject! { |r| r["sizes"].nil? } results.reject! { |r| r["sizes"].nil? || r["sizes"].match(/(\d+)x/).nil? }
results.sort! { |a, b| sizes_to_i(b["sizes"]) <=> sizes_to_i(a["sizes"]) } results.sort! { |a, b| sizes_to_i(b["sizes"]) <=> sizes_to_i(a["sizes"]) }
if icon = select_exact_size(results, options[:sizes]) if icon = select_exact_size(results, options[:sizes])

1
spec/manifique/metadata_spec.rb
View File

@ -105,6 +105,7 @@ def icon_fixtures
{"src"=>"/application_icon_x228.png", "sizes"=>"228x228", "type"=>"image/png"}, {"src"=>"/application_icon_x228.png", "sizes"=>"228x228", "type"=>"image/png"},
{"src"=>"/application_icon_x196.png", "sizes"=>"196x196", "type"=>"image/png"}, {"src"=>"/application_icon_x196.png", "sizes"=>"196x196", "type"=>"image/png"},
{"src"=>"/application_icon_x192.png", "sizes"=>"192x192", "type"=>"image/png"}, {"src"=>"/application_icon_x192.png", "sizes"=>"192x192", "type"=>"image/png"},
{"src"=>"/icon-maskable.svg", "type"=>"image/svg+xml", "sizes"=>"any", "purpose"=>"maskable"},
{"purpose"=>"apple-touch-icon", "src"=>"/apple-touch-icon.png", "sizes"=>"180x180", "type"=>"image/png" }, {"purpose"=>"apple-touch-icon", "src"=>"/apple-touch-icon.png", "sizes"=>"180x180", "type"=>"image/png" },
{"purpose"=>"apple-touch-icon", "src"=>"/apple-touch-icon-57px.png", "sizes"=>"57x57", "type"=>"image/png"}, {"purpose"=>"apple-touch-icon", "src"=>"/apple-touch-icon-57px.png", "sizes"=>"57x57", "type"=>"image/png"},
{"purpose"=>"mask-icon", "src"=>"/mask-icon.svg", "type"=>"image/svg", "color"=>"#2b90d9"} {"purpose"=>"mask-icon", "src"=>"/mask-icon.svg", "type"=>"image/svg", "color"=>"#2b90d9"}