colby/cappuccino
1
0
Fork 0
mirror of https://github.com/cappuccino/cappuccino.git synced 2026-09-07 03:07:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

CPArrayController : setAvoidsEmptySelection:YES should not apply when setting an empty selection explicitely. With tests.

Browse Source
This commit is contained in:
cacaodev
2012-02-03 00:48:49 +01:00
parent ab88f72827
commit 12201d38f3
2 changed files with 56 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Tests/AppKit/CPArrayControllerTest.j
+41 -1
View File
@@ -201,12 +201,32 @@
[arrayController setPreservesSelection:NO];
[arrayController setSelectionIndexes:[CPIndexSet indexSetWithIndexesInRange:CPMakeRange(1, 2)]];
[arrayController removeObjects:[arrayController selectedObjects]]
[arrayController removeObjects:[arrayController selectedObjects]];
[self assert:[CPIndexSet indexSet] equals:[arrayController selectionIndexes]
message:@"selection should be empty if arraycontroller doesn't avoid empty selection"];
}
- (void)testRemoveObjectWithAvoidingEmptySelection
{
var arrayController = [self arrayController];
[arrayController setAvoidsEmptySelection:YES];
[arrayController setSelectionIndex:2];
[arrayController removeObjectsAtArrangedObjectIndexes:[CPIndexSet indexSetWithIndex:2]];
[self assertTrue:([[arrayController selectionIndexes] count] > 0) message:@"Selection should not empty when arraycontroller avoids empty selection"];
[arrayController setContent:[self contentArray]];
[arrayController setSelectionIndex:2];
[arrayController removeObjects:[arrayController selectedObjects]];
[self assertTrue:([[arrayController selectionIndexes] count] > 0) message:@"Selection should not empty when arraycontroller avoids empty selection"];
// This will fail, currently we select the first index instead of an adjacent index.
// [self assertTrue:([arrayController selectionIndex] == 1) message:@"The selected index should be 1, was " + [arrayController selectionIndex]];
}
- (void)testRemoveObjectsWithPreservesSelection_SimpleArray
{
[self initControllerWithSimpleArray];
@@ -287,6 +307,26 @@
[self assert:[CPIndexSet indexSetWithIndexesInRange:CPMakeRange(0, 2)] equals:[arrayController selectionIndexes] message:@"last object cannot be selected"];
}
- (void)testSelectingEmptyIndexesExplicitlyWithAvoidsEmptySelection
{
var arrayController = [self arrayController];
[arrayController setAvoidsEmptySelection:YES];
[arrayController setSelectionIndex:0];
[arrayController setSelectionIndexes:[CPIndexSet indexSet]];
[self assertTrue:([[arrayController selectionIndexes] count] == 0) message:@"Selection should be empty when unselecting explicitly, even with avoidsEmptySelection"];
}
- (void)testSelectingEmptyObjectsExplicitlyWithAvoidsEmptySelection
{
var arrayController = [self arrayController];
[arrayController setAvoidsEmptySelection:YES];
[arrayController setSelectionIndex:0];
[arrayController setSelectedObjects:[CPArray array]];
[self assertTrue:([[arrayController selectionIndexes] count] == 0) message:@"Selection should be empty when unselecting explicitly, even with avoidsEmptySelection"];
}
- (void)testContentBinding
{
[[self arrayController] bind:@"contentArray" toObject:self withKeyPath:@"contentArray" options:0];