From 344d2eb78c64ed2f37bc16e7d9a6011a7bc4df52 Mon Sep 17 00:00:00 2001 From: Francisco Ryan Tolmasky I Date: Fri, 3 Oct 2008 13:46:05 -0700 Subject: [PATCH] Further fix for toolbar item sizing. Reviewed by me. --- AppKit/CPToolbarItem.j | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/AppKit/CPToolbarItem.j b/AppKit/CPToolbarItem.j index 95eee5626..d623d28fe 100644 --- a/AppKit/CPToolbarItem.j +++ b/AppKit/CPToolbarItem.j @@ -260,7 +260,21 @@ var _CPToolbarSeparatorItemView = nil; { _image = anImage; + // FIXME: We can't keep assuming this. [_view setImage:anImage]; + + if (!_image) + return; + + var imageSize = [_image size]; + + if (_minSize.width == 0 && _minSize.height == 0 && + _maxSize.width == 0 && _maxSize.height == 0 && + (imageSize.width > 0 || imageSize.height > 0)) + { + [self setMinSize:imageSize]; + [self setMaxSize:imageSize]; + } } /* @@ -271,6 +285,7 @@ var _CPToolbarSeparatorItemView = nil; { _alternateImage = anImage; + // FIXME: We can't keep assuming this. [_view setAlternateImage:anImage]; }