From 4fdddfb585ecec78e041706f9f6950f64c349098 Mon Sep 17 00:00:00 2001 From: Abhinav Gupta Date: Thu, 26 Nov 2009 19:18:20 -0500 Subject: [PATCH] Fixed CPString's commonPrefixWithString to be faster. --- Foundation/CPString.j | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/Foundation/CPString.j b/Foundation/CPString.j index 30b6503c2..7e65dc636 100644 --- a/Foundation/CPString.j +++ b/Foundation/CPString.j @@ -557,19 +557,19 @@ var CPStringRegexSpecialCharacters = [ { var len = 0, // length of common prefix min = MIN([aString length], [self length]); + + var lhs = self, + rhs = aString; + + if (aMask & CPCaseInsensitiveSearch) + { + lhs = [lhs lowercaseString]; + rhs = [rhs lowercaseString]; + } for ( len = 0; len < min; len++ ) { - var lhs = [self characterAtIndex: len], - rhs = [aString characterAtIndex: len]; - - if (aMask & CPCaseInsensitiveSearch) - { - lhs = [lhs lowercaseString]; - rhs = [rhs lowercaseString]; - } - - if ( lhs != rhs ) + if ( [lhs characterAtIndex: len] != [rhs characterAtIndex: len] ) break; } return [self substringToIndex: len];