colby/cappuccino
1
0 Fork 0
mirror of https://github.com/cappuccino/cappuccino.git synced 2026-10-09 18:30:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed: Make sure we handle undefined when testing for nil values (#2862)

Browse Source
This commit is contained in:
Martin Carlberg authored and GitHub committed 2020-01-31 13:43:58 +01:00
1 parent 8daa53dd3e
commit 7dc77ed609
95 files changed
+280 -280
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

Foundation/CPArray/CPMutableArray.j
+3 -3
View File
@@ -527,10 +527,10 @@ var sortArrayUsingJSDescriptors = function(a, d)
key = dd.k;
value1 = C1[key];
value2 = C2[key];
if (value1 === nil || value1 === cpNull)
o = value2 === nil || value2 === cpNull ? CPOrderedSame : CPOrderedAscending;
if (value1 == nil || value1 === cpNull)
o = value2 == nil || value2 === cpNull ? CPOrderedSame : CPOrderedAscending;
else
o = value2 === nil || value2 === cpNull ? CPOrderedDescending : value1.isa.objj_msgSend1(value1, dd.s, value2);
o = value2 == nil || value2 === cpNull ? CPOrderedDescending : value1.isa.objj_msgSend1(value1, dd.s, value2);
if (o && !dd.a)
o = -o;