From b8420303ba7bc5298b4a07defdd97cacf8a2a132 Mon Sep 17 00:00:00 2001 From: daniel Date: Tue, 3 Apr 2018 10:55:17 -0700 Subject: [PATCH 1/9] Formatting: add missing semi-colon to CPKeyValueBinding.j --- AppKit/CPKeyValueBinding.j | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AppKit/CPKeyValueBinding.j b/AppKit/CPKeyValueBinding.j index d524590d4..05a9fd585 100644 --- a/AppKit/CPKeyValueBinding.j +++ b/AppKit/CPKeyValueBinding.j @@ -857,7 +857,7 @@ var CPBindingOperationAnd = 0, - (id)initWithName:(CPString)aName { if (self = [super init]) - _name = aName + _name = aName; return self; } From 0fc3eb38f1db92562757bb34dc5a2cbd1fd1bbec Mon Sep 17 00:00:00 2001 From: daniel Date: Tue, 3 Apr 2018 12:11:57 -0700 Subject: [PATCH 2/9] Formatting: Add semi-colons to CGContextCanvas.j --- AppKit/CoreGraphics/CGContextCanvas.j | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/AppKit/CoreGraphics/CGContextCanvas.j b/AppKit/CoreGraphics/CGContextCanvas.j index 628afd27e..3c2115dc4 100644 --- a/AppKit/CoreGraphics/CGContextCanvas.j +++ b/AppKit/CoreGraphics/CGContextCanvas.j @@ -557,14 +557,14 @@ CGContextConcatCTM = function(aContext, anAffineTransform) b = VT.b; c = VT.c; d = VT.d; - scale_rotate(a, b, c, d) + scale_rotate(a, b, c, d); S.a *= sx; S.d *= sy; a = U.a; b = U.b; c = U.c; d = U.d; - rotate_scale(a, b, c, d) + rotate_scale(a, b, c, d); sx = S.a * sx; sy = S.d * sy; } From 36702bc97119531d01da918de0f38f6ed66e85e1 Mon Sep 17 00:00:00 2001 From: daniel Date: Tue, 3 Apr 2018 12:15:04 -0700 Subject: [PATCH 3/9] Formatting: add missing semi-colon to CGContextVML --- AppKit/CoreGraphics/CGContextVML.j | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AppKit/CoreGraphics/CGContextVML.j b/AppKit/CoreGraphics/CGContextVML.j index d8431a857..8bb35f649 100644 --- a/AppKit/CoreGraphics/CGContextVML.j +++ b/AppKit/CoreGraphics/CGContextVML.j @@ -242,7 +242,7 @@ function CGContextDrawPath(aContext, aMode) vml.push("\">"); if (gState.gradient) - vml.push(gState.gradient) + vml.push(gState.gradient); else if (fill) { From fd581cd65c9a09a4952ddb7c3ddd1b4614e66489 Mon Sep 17 00:00:00 2001 From: daniel Date: Tue, 3 Apr 2018 12:46:56 -0700 Subject: [PATCH 4/9] Formatting: removed variable redeclaration in CGPath.j Variables `arcStartX` and `arcStartY` are declared on 125 and 126, but are later redeclared in an `else` statement on lines 135 and 136 with the same equation and presumably the same value used in the initial declaration. Also added missing semi-colon --- AppKit/CoreGraphics/CGPath.j | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/AppKit/CoreGraphics/CGPath.j b/AppKit/CoreGraphics/CGPath.j index b7cea5164..b01d92dfc 100644 --- a/AppKit/CoreGraphics/CGPath.j +++ b/AppKit/CoreGraphics/CGPath.j @@ -132,9 +132,6 @@ function CGPathAddArc(aPath, aTransform, x, y, aRadius, aStartAngle, anEndAngle, } else { - var arcStartX = x + aRadius * COS(aStartAngle), - arcStartY = y + aRadius * SIN(aStartAngle); - aPath.start = CGPointMake(arcStartX, arcStartY); } @@ -274,7 +271,7 @@ function CGPathAddQuadCurveToPoint(aPath, aTransform, cpx, cpy, x, y) end = CGPointApplyAffineTransform(end, aTransform); } - aPath.elements[aPath.count++] = { type:kCGPathElementAddQuadCurveToPoint, cpx:cp.x, cpy:cp.y, x:end.x, y:end.y } + aPath.elements[aPath.count++] = { type:kCGPathElementAddQuadCurveToPoint, cpx:cp.x, cpy:cp.y, x:end.x, y:end.y }; aPath.current = end; } From ed0dc2d88767b476ab66c03f2c33967a4145f215 Mon Sep 17 00:00:00 2001 From: daniel Date: Tue, 3 Apr 2018 12:59:51 -0700 Subject: [PATCH 5/9] Formatting: add semi-colon to _CPDatePickerClock.j --- AppKit/CPDatePicker/_CPDatePickerClock.j | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AppKit/CPDatePicker/_CPDatePickerClock.j b/AppKit/CPDatePicker/_CPDatePickerClock.j index 1dc603934..c18c5e66b 100644 --- a/AppKit/CPDatePicker/_CPDatePickerClock.j +++ b/AppKit/CPDatePicker/_CPDatePickerClock.j @@ -142,7 +142,7 @@ var RADIANS = Math.PI / 180; if ([_datePicker _isAmericanFormat]) { if (dateValue.getHours() > 11) - [_PMAMTextField setStringValue:@"PM"] + [_PMAMTextField setStringValue:@"PM"]; else [_PMAMTextField setStringValue:@"AM"]; From 0f40721cff876bf6b76280538ce2c2bd011c2395 Mon Sep 17 00:00:00 2001 From: daniel Date: Wed, 4 Apr 2018 13:29:40 -0700 Subject: [PATCH 6/9] Formatting: add semi-colon to _CPPopoverWindow.j --- AppKit/_CPPopoverWindow.j | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AppKit/_CPPopoverWindow.j b/AppKit/_CPPopoverWindow.j index 055611e98..159b26a6c 100644 --- a/AppKit/_CPPopoverWindow.j +++ b/AppKit/_CPPopoverWindow.j @@ -574,7 +574,7 @@ var _CPPopoverWindow_shouldClose_ = 1 << 4, _isOpening = NO; [_delegate _popoverWindowDidShow]; - } + }; #if PLATFORM(DOM) _DOMElement.addEventListener(CPBrowserStyleProperty('transitionend'), _transitionCompleteFunction, YES); From 186048676ab0ec5d783f96db0e8f6bc5d8426504 Mon Sep 17 00:00:00 2001 From: daniel Date: Wed, 4 Apr 2018 13:31:19 -0700 Subject: [PATCH 7/9] Formatting: add semi-colon to _CPTooltip.j --- AppKit/_CPToolTip.j | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AppKit/_CPToolTip.j b/AppKit/_CPToolTip.j index 296293d02..83457ad3e 100644 --- a/AppKit/_CPToolTip.j +++ b/AppKit/_CPToolTip.j @@ -181,7 +181,7 @@ var _CPToolTipHeight = 24.0, textFrameSize.height += 4; _content = [CPTextField labelWithTitle:aString]; - [_content setFont:[CPFont systemFontOfSize:_CPToolTipFontSize]] + [_content setFont:[CPFont systemFontOfSize:_CPToolTipFontSize]]; [_content setLineBreakMode:CPLineBreakByCharWrapping]; [_content setAutoresizingMask:CPViewWidthSizable | CPViewHeightSizable]; [_content setFrameOrigin:CGPointMake(0.0, 0.0)]; From aa7e49cfde36b630da9258fd4b56b00b17a8c524 Mon Sep 17 00:00:00 2001 From: daniel Date: Wed, 4 Apr 2018 13:32:37 -0700 Subject: [PATCH 8/9] Formatting: add semi-colon to CPApplication.j --- AppKit/CPApplication.j | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AppKit/CPApplication.j b/AppKit/CPApplication.j index f20664030..100912937 100644 --- a/AppKit/CPApplication.j +++ b/AppKit/CPApplication.j @@ -216,7 +216,7 @@ var CPApplicationDelegate_applicationShouldTerminate_ = 1 << 0, } if ([_delegate respondsToSelector:@selector(applicationShouldTerminate:)]) - _implementedDelegateMethods |= CPApplicationDelegate_applicationShouldTerminate_ + _implementedDelegateMethods |= CPApplicationDelegate_applicationShouldTerminate_; if ([_delegate respondsToSelector:@selector(applicationShouldTerminateMessage:)]) _implementedDelegateMethods |= CPApplicationDelegate_applicationShouldTerminateMessage_ From ef462973c7b9a807eefb29a3b9be83d47e9b70ad Mon Sep 17 00:00:00 2001 From: daniel Date: Wed, 4 Apr 2018 13:33:53 -0700 Subject: [PATCH 9/9] Formatting: add semi-colon to CPArrayController.j --- AppKit/CPArrayController.j | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AppKit/CPArrayController.j b/AppKit/CPArrayController.j index 67e2f681e..b26c0ced8 100644 --- a/AppKit/CPArrayController.j +++ b/AppKit/CPArrayController.j @@ -563,7 +563,7 @@ */ - (BOOL)setSelectionIndexes:(CPIndexSet)indexes { - [self _selectionWillChange] + [self _selectionWillChange]; var r = [self __setSelectionIndexes:indexes avoidEmpty:NO]; [self _selectionDidChange]; return r;