From a0f6b815e8e7771d76b2e01961824fac46903121 Mon Sep 17 00:00:00 2001 From: Frank Rehwinkel Date: Wed, 3 May 2017 09:39:08 -0400 Subject: [PATCH] Removed an unused variable: cachedSearchResults. It is polluting the global namespace. Seven years ago this line was added and even then the variable wasn't being used but it was a local variable so would have been hard to spot unless a linter should catch things like that. Then some four years ago it was accidently converted to a global variable because the line above it ended in a semicolon rather than a comma. 'use strict' didn't exist at the time this file was created and hasn't been added in general yet. --- Objective-J/Executable.js | 1 - 1 file changed, 1 deletion(-) diff --git a/Objective-J/Executable.js b/Objective-J/Executable.js index 8da88e457..f138fb6c2 100644 --- a/Objective-J/Executable.js +++ b/Objective-J/Executable.js @@ -475,7 +475,6 @@ Executable.fileExecutableSearcherForURL = function(/*CFURL*/ referenceURL) var referenceURLString = referenceURL.absoluteString(), cachedFileExecutableSearcher = cachedFileExecutableSearchers[referenceURLString], aFilenameTranslateDictionary = Executable.filenameTranslateDictionary ? Executable.filenameTranslateDictionary() : null; - cachedSearchResults = { }; if (!cachedFileExecutableSearcher) {