From 5736d2c9ccc729fda6eeffef9e1af5f4450ef5e2 Mon Sep 17 00:00:00 2001 From: Andrew Hankinson Date: Thu, 22 Jan 2015 13:31:04 -0500 Subject: [PATCH] Formatting: CPView Previously CPView used "==" as an equality checker. This commit changes these to use "===" for consistency. --- AppKit/CPView.j | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/AppKit/CPView.j b/AppKit/CPView.j index 18d09d25e..b614a1381 100644 --- a/AppKit/CPView.j +++ b/AppKit/CPView.j @@ -380,7 +380,7 @@ var CPViewFlags = { }, */ - (void)setToolTip:(CPString)aToolTip { - if (_toolTip == aToolTip) + if (_toolTip === aToolTip) return; if (aToolTip && ![aToolTip isKindOfClass:CPString]) @@ -525,7 +525,7 @@ var CPViewFlags = { }, [[self window] _dirtyKeyViewLoop]; // If this is already one of our subviews, remove it. - if (aSubview._superview == self) + if (aSubview._superview === self) { var index = [_subviews indexOfObjectIdenticalTo:aSubview]; @@ -796,7 +796,7 @@ var CPViewFlags = { }, do { - if (view == aView) + if (view === aView) return YES; } while(view = [view superview]) @@ -911,7 +911,7 @@ var CPViewFlags = { }, - (CPView)viewWithTag:(CPInteger)aTag { - if ([self tag] == aTag) + if ([self tag] === aTag) return self; var index = 0, @@ -1342,7 +1342,7 @@ var CPViewFlags = { }, { var mask = [self autoresizingMask]; - if (mask == CPViewNotSizable) + if (mask === CPViewNotSizable) return; var frame = _superview._frame, @@ -1525,7 +1525,7 @@ var CPViewFlags = { }, { do { - if (self == view) + if (self === view) { [_window makeFirstResponder:[self nextValidKeyView]]; break; @@ -1595,7 +1595,7 @@ var CPViewFlags = { }, */ - (void)setAlphaValue:(float)anAlphaValue { - if (_opacity == anAlphaValue) + if (_opacity === anAlphaValue) return; _opacity = anAlphaValue; @@ -1799,10 +1799,10 @@ var CPViewFlags = { }, */ - (void)setBackgroundColor:(CPColor)aColor { - if (_backgroundColor == aColor) + if (_backgroundColor === aColor) return; - if (aColor == [CPNull null]) + if (aColor === [CPNull null]) aColor = nil; _backgroundColor = aColor; @@ -1845,7 +1845,7 @@ var CPViewFlags = { }, var image = slices[i], size = [image size]; - if (!size || (size.width == 0 && size.height == 0)) + if (!size || (size.width === 0 && size.height === 0)) size = nil; _DOMImageSizes[i] = size; @@ -1900,10 +1900,12 @@ var CPViewFlags = { }, CPDOMDisplayServerSetStyleSize(_DOMImageParts[0], size.width, size.height); } else + { _DOMElement.style.background = colorCSS; if (patternImage) CPDOMDisplayServerSetStyleBackgroundSize(_DOMElement, [patternImage size].width + "px", [patternImage size].height + "px"); + } } else { @@ -1937,7 +1939,7 @@ var CPViewFlags = { }, partIndex++; } - if (_backgroundType == BackgroundNinePartImage) + if (_backgroundType === BackgroundNinePartImage) { var left = _DOMImageSizes[0] ? _DOMImageSizes[0].width : 0, right = _DOMImageSizes[2] ? _DOMImageSizes[2].width : 0, @@ -1998,7 +2000,7 @@ var CPViewFlags = { }, CPDOMDisplayServerSetStyleRightBottom(_DOMImageParts[partIndex], NULL, 0.0, 0.0); } } - else if (_backgroundType == BackgroundVerticalThreePartImage) + else if (_backgroundType === BackgroundVerticalThreePartImage) { var top = _DOMImageSizes[0] ? _DOMImageSizes[0].height : 0, bottom = _DOMImageSizes[2] ? _DOMImageSizes[2].height : 0; @@ -2030,7 +2032,7 @@ var CPViewFlags = { }, CPDOMDisplayServerSetStyleSize(_DOMImageParts[partIndex], frameSize.width, bottom); } } - else if (_backgroundType == BackgroundHorizontalThreePartImage) + else if (_backgroundType === BackgroundHorizontalThreePartImage) { var left = _DOMImageSizes[0] ? _DOMImageSizes[0].width : 0, right = _DOMImageSizes[2] ? _DOMImageSizes[2].width : 0; @@ -2913,7 +2915,7 @@ setBoundsOrigin: */ - (void)setLayer:(CALayer)aLayer { - if (_layer == aLayer) + if (_layer === aLayer) return; if (_layer)