From c9d4089b9adaeac577c6469ae52efd6b12ddcbdf Mon Sep 17 00:00:00 2001 From: Alexander Ljungberg Date: Wed, 8 Feb 2012 14:54:50 +0000 Subject: [PATCH] Throw an exception when trying to set a scroller's knob proportion to NaN or Inifinity. --- AppKit/CPScroller.j | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/AppKit/CPScroller.j b/AppKit/CPScroller.j index a466dbbea..a3ee42c6c 100644 --- a/AppKit/CPScroller.j +++ b/AppKit/CPScroller.j @@ -23,6 +23,8 @@ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ +#include "../Foundation/Foundation.h" + @import "CPControl.j" // CPScroller Constants @@ -260,6 +262,9 @@ CPThemeStateScrollerKnobDark = CPThemeState("scroller-knob-dark"); */ - (void)setKnobProportion:(float)aProportion { + if (!_IS_NUMERIC(aProportion)) + [CPException raise:CPInvalidArgumentException reason:"aProportion must be numeric"]; + _knobProportion = MIN(1.0, MAX(0.0001, aProportion)); [self setNeedsDisplay:YES];