mirror of
https://github.com/cappuccino/cappuccino.git
synced 2026-08-25 21:17:03 +00:00
Fixed: Return a Number from CPNumber>>numberWithBool:
The Cocoa signature for this method + (NSNumber *)numberWithBool:(BOOL)value implies that a number is being returned. In Cappuccino a Boolean is returned. This leads to some problems e.g. in addObserver:forKeyPath:options:context: with CPKeyValueObservingOptionPrior and observeValueForKeyPath:ofObject:change:context: with CPKeyValueObservingOptionPrior. Setting CPKeyValueObservingOptionPrior leads to CPKeyValueChangeNotificationIsPriorKey being set to 1 (which should be equal to [NSNumber numberWithBool:YES] as documented in https://developer.apple.com/library/mac/documentation/Cocoa/Reference/Foundation/Protocols/NSKeyValueObserving_Protocol/Reference/Reference.html. The actual value though is true as [CPNumber numberWithBool:YES] does not return a number but a boolean. This commit fixes this issue.
This commit is contained in:
@@ -50,7 +50,7 @@ var CPNumberUIDs = new CFMutableDictionary();
|
||||
|
||||
+ (id)numberWithBool:(BOOL)aBoolean
|
||||
{
|
||||
return aBoolean;
|
||||
return aBoolean ? 1 : 0;
|
||||
}
|
||||
|
||||
+ (id)numberWithChar:(char)aChar
|
||||
|
||||
Reference in New Issue
Block a user