From e92a7825bfff7b2284b19dc6bc285e5e10446f08 Mon Sep 17 00:00:00 2001 From: Alexander Ljungberg Date: Thu, 27 Oct 2011 13:35:55 +0100 Subject: [PATCH] Optimise bottom corner view in overlay scrolling mode. In particular, there is no need to update nor even draw the bottom corner view when in overlay mode. --- AppKit/CPScrollView.j | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/AppKit/CPScrollView.j b/AppKit/CPScrollView.j index ce47c1902..4a1e5344f 100644 --- a/AppKit/CPScrollView.j +++ b/AppKit/CPScrollView.j @@ -777,7 +777,10 @@ var CPScrollerStyleGlobal = CPScrollerStyleOverlay, if (_timerScrollersHide) [_timerScrollersHide invalidate]; _timerScrollersHide = [CPTimer scheduledTimerWithTimeInterval:CPScrollViewFadeOutTime target:self selector:@selector(_hideScrollers:) userInfo:nil repeats:NO]; + [[self bottomCornerView] setHidden:YES]; } + else + [[self bottomCornerView] setHidden:NO]; [self reflectScrolledClipView:_contentView]; } @@ -1156,8 +1159,11 @@ var CPScrollerStyleGlobal = CPScrollerStyleOverlay, [[_headerClipView documentView] setNeedsDisplay:YES]; [_cornerView setFrame:[self _cornerViewFrame]]; - [[self bottomCornerView] setFrame:[self _bottomCornerViewFrame]]; - [[self bottomCornerView] setBackgroundColor:[self currentValueForThemeAttribute:@"bottom-corner-color"]]; + if (_scrollerStyle === CPScrollerStyleLegacy) + { + [[self bottomCornerView] setFrame:[self _bottomCornerViewFrame]]; + [[self bottomCornerView] setBackgroundColor:[self currentValueForThemeAttribute:@"bottom-corner-color"]]; + } --_recursionCount; }