diff --git a/AppKit/CPControl.j b/AppKit/CPControl.j index db8a22cd9..6310a9b11 100644 --- a/AppKit/CPControl.j +++ b/AppKit/CPControl.j @@ -337,9 +337,19 @@ var CPControlBlackColor = [CPColor blackColor]; [self highlight:YES]; [self setState:[self nextState]]; - [self sendAction:[self action] to:[self target]]; - [CPTimer scheduledTimerWithTimeInterval:0.1 target:self selector:@selector(unhighlightButtonTimerDidFinish:) userInfo:nil repeats:NO]; + try + { + [self sendAction:[self action] to:[self target]]; + } + catch (e) + { + throw e; + } + finally + { + [CPTimer scheduledTimerWithTimeInterval:0.1 target:self selector:@selector(unhighlightButtonTimerDidFinish:) userInfo:nil repeats:NO]; + } } - (void)unhighlightButtonTimerDidFinish:(id)sender diff --git a/Tests/Manual/CPControlPerformClickExceptionTest/AppController.j b/Tests/Manual/CPControlPerformClickExceptionTest/AppController.j new file mode 100644 index 000000000..fc07ffc5b --- /dev/null +++ b/Tests/Manual/CPControlPerformClickExceptionTest/AppController.j @@ -0,0 +1,110 @@ +/* + * AppController.j + * CPControlPerformClickExceptionTest + * + * Created by Aparajita Fishman on August 21, 2010. + */ + +@import + +CPLogRegister(CPLogConsole); + +var UseFix = NO; + + +@implementation AppController : CPObject +{ + CPWindow theWindow; + + CPButton button; +} + +- (void)applicationDidFinishLaunching:(CPNotification)aNotification +{ + theWindow = [[CPWindow alloc] initWithContentRect:CGRectMake(70.0, 70.0, 400.0, 300.0) styleMask:CPTitledWindowMask]; + [theWindow setTitle:@"CPControlPerformClickExceptionTest"]; + + var contentView = [theWindow contentView], + label = [CPTextField labelWithTitle:@"Press the Return key to see the problem and fix"], + button = [MyButton buttonWithTitle:@"Button"], + checkbox = [CPCheckBox checkBoxWithTitle:@"Use Fix"]; + + [label setFrameOrigin:CGPointMake(50, 50)]; + [contentView addSubview:label]; + + [button setFrameOrigin:CGPointMake(50, 90)]; + [button setTarget:self]; + [button setAction:@selector(buttonWasPressed:)]; + [contentView addSubview:button]; + + [checkbox setFrameOrigin:CGPointMake(50, 130)]; + [checkbox setTarget:self]; + [checkbox setAction:@selector(useFix:)]; + [contentView addSubview:checkbox]; + + [theWindow setDefaultButton:button]; + [theWindow orderFront:nil]; +} + +- (void)buttonWasPressed:(id)sender +{ + try + { + [CPException raise:[[sender window] title] reason:[sender title]]; + } + finally + { + var alert = [[CPAlert alloc] init]; + + [alert setTitle:@"Test"]; + [alert setMessageText:UseFix ? @"Note the button has already been unhighlighted." : @"Note the button has not been unhighlighted. It will be when this alert is closed."]; + [alert addButtonWithTitle:@"OK"]; + [alert setDelegate:self]; + [alert runModal]; + } +} + +-(void)alertDidEnd:(CPAlert)theAlert returnCode:(int)returnCode +{ + [button highlight:NO]; +} + +- (void)useFix:(id)sender +{ + UseFix = [sender state] == CPOnState; +} + +@end + +@implementation MyButton : CPButton + ++ (id)buttonWithTitle:(CPString)aTitle +{ + var button = [[[self class] alloc] init]; + + [button setTheme:[CPTheme defaultTheme]]; + [button setTitle:aTitle]; + [button sizeToFit]; + + return button; +} + +- (void)performClick:(id)sender +{ + if (UseFix) + { + [super performClick:sender]; + return; + } + + if (![self isEnabled]) + return; + + [self highlight:YES]; + [self setState:[self nextState]]; + [self sendAction:[self action] to:[self target]]; + + [CPTimer scheduledTimerWithTimeInterval:0.1 target:self selector:@selector(unhighlightButtonTimerDidFinish:) userInfo:nil repeats:NO]; +} + +@end diff --git a/Tests/Manual/CPControlPerformClickExceptionTest/Info.plist b/Tests/Manual/CPControlPerformClickExceptionTest/Info.plist new file mode 100644 index 000000000..d698a875a --- /dev/null +++ b/Tests/Manual/CPControlPerformClickExceptionTest/Info.plist @@ -0,0 +1,12 @@ + + + + + CPApplicationDelegateClass + AppController + CPBundleName + CPControlPerformClickExceptionTest + CPPrincipalClass + CPApplication + + diff --git a/Tests/Manual/CPControlPerformClickExceptionTest/Resources/spinner.gif b/Tests/Manual/CPControlPerformClickExceptionTest/Resources/spinner.gif new file mode 100644 index 000000000..06dbc2bc2 Binary files /dev/null and b/Tests/Manual/CPControlPerformClickExceptionTest/Resources/spinner.gif differ diff --git a/Tests/Manual/CPControlPerformClickExceptionTest/index-debug.html b/Tests/Manual/CPControlPerformClickExceptionTest/index-debug.html new file mode 100644 index 000000000..dcc825c28 --- /dev/null +++ b/Tests/Manual/CPControlPerformClickExceptionTest/index-debug.html @@ -0,0 +1,69 @@ + + + + + + + + CPControlPerformClickExceptionTest + + + + + + + + + + + + +
+ + + +
+ + + diff --git a/Tests/Manual/CPControlPerformClickExceptionTest/index.html b/Tests/Manual/CPControlPerformClickExceptionTest/index.html new file mode 100644 index 000000000..bd9ab5680 --- /dev/null +++ b/Tests/Manual/CPControlPerformClickExceptionTest/index.html @@ -0,0 +1,68 @@ + + + + + + + + CPControlPerformClickExceptionTest + + + + + + + + + + + + +
+ + + +
+ + + diff --git a/Tests/Manual/CPControlPerformClickExceptionTest/main.j b/Tests/Manual/CPControlPerformClickExceptionTest/main.j new file mode 100755 index 000000000..af6279da3 --- /dev/null +++ b/Tests/Manual/CPControlPerformClickExceptionTest/main.j @@ -0,0 +1,18 @@ +/* + * AppController.j + * TableCibTest + * + * Created by Francisco Tolmasky on July 5, 2009. + * Copyright 2009, 280 North, Inc. All rights reserved. + */ + +@import +@import + +@import "AppController.j" + + +function main(args, namedArgs) +{ + CPApplicationMain(args, namedArgs); +}