From 089d564934047da0435d5d456172af32b4206d83 Mon Sep 17 00:00:00 2001 From: Alexandre Wilhelm Date: Tue, 27 May 2014 10:12:02 -0700 Subject: [PATCH] Fixed: CPDatePicker firstResponder issue Previously, the textual datePicker didn't work because it couldn't become the firstResponder. This PR fixed another issue as well. Previously it wasn't possible to modify a date when moving only with tab and when the datePicker came firstResponder with tabulation. --- AppKit/CPDatePicker/CPDatePicker.j | 2 +- AppKit/CPDatePicker/_CPDatePickerTextField.j | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/AppKit/CPDatePicker/CPDatePicker.j b/AppKit/CPDatePicker/CPDatePicker.j index 922e8cbd9..5a4f81727 100644 --- a/AppKit/CPDatePicker/CPDatePicker.j +++ b/AppKit/CPDatePicker/CPDatePicker.j @@ -533,7 +533,7 @@ CPEraDatePickerElementFlag = 0x0100; { if (_datePickerStyle == CPTextFieldAndStepperDatePickerStyle || _datePickerStyle == CPTextFieldDatePickerStyle) { - if ([super becomeFirstResponder]) + if (![super becomeFirstResponder]) return NO; [_datePickerTextfield _selecteTextFieldWithFlags:[[CPApp currentEvent] modifierFlags]]; diff --git a/AppKit/CPDatePicker/_CPDatePickerTextField.j b/AppKit/CPDatePicker/_CPDatePickerTextField.j index 02c7a7148..ddd6e3172 100644 --- a/AppKit/CPDatePicker/_CPDatePickerTextField.j +++ b/AppKit/CPDatePicker/_CPDatePickerTextField.j @@ -1226,14 +1226,14 @@ var CPMonthDateType = 0, CPTimer _timerEdition; } - -#pragma mark - -#pragma mark Getter Setter methods - -- (BOOL)acceptFirstResponder +- (id)init { - _firstEvent = YES; - return NO; + if (self = [super init]) + { + _firstEvent = YES; + } + + return self; } /*! Set the dateType of the textField