From fb2d0ed1709ce5fbf5fdc03e97692d6021b8a227 Mon Sep 17 00:00:00 2001 From: daniel Date: Thu, 28 Mar 2019 13:42:39 -0700 Subject: [PATCH] Fixed: Return types in CPPlatformPasteboard.j should return BOOL Method _mayRequireDOMPasteboardElementHack:flags had return type of void, despite returning a BOOL value, and also being annotated with a doc comment stating that it should return a BOOL value Also some methods had return type "boolean", should possibly be BOOL --- AppKit/Platform/DOM/CPPlatformPasteboard.j | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/AppKit/Platform/DOM/CPPlatformPasteboard.j b/AppKit/Platform/DOM/CPPlatformPasteboard.j index c41e8f6cc..ad6a7564d 100644 --- a/AppKit/Platform/DOM/CPPlatformPasteboard.j +++ b/AppKit/Platform/DOM/CPPlatformPasteboard.j @@ -330,7 +330,7 @@ var hasEditableTarget = function(aDOMEvent) [[CPRunLoop currentRunLoop] limitDateForMode:CPDefaultRunLoopMode]; } -- (boolean)beforePasteEvent:(DOMEvent)aDOMEvent +- (BOOL)beforePasteEvent:(DOMEvent)aDOMEvent { // Set up to capture the paste in a temporary input field. We'll send the event after capture. if ([self _mayRequireDOMPasteboardElementHack:aDOMEvent flags:CPPlatformActionKeyMask]) @@ -407,7 +407,7 @@ Return true if the event may be a copy and paste event, but the target is not an _DOMPasteboardElement.blur(); } -- (boolean)nativeBeforeClipboardEvent:(DOMEvent)aDOMEvent +- (BOOL)nativeBeforeClipboardEvent:(DOMEvent)aDOMEvent { // Our job here is to return "false" if the given clipboard operation should be enabled even in a situation where // the browser might normally grey the option out. @@ -437,7 +437,7 @@ Return true if the event may be a copy and paste event, but the target is not an return returnValue; } -- (boolean)nativePasteEvent:(DOMEvent)aDOMEvent +- (BOOL)nativePasteEvent:(DOMEvent)aDOMEvent { // This shouldn't happen. if (!supportsNativeCopyAndPaste) @@ -481,7 +481,7 @@ Return true if the event may be a copy and paste event, but the target is not an return false; } -- (boolean)nativeCopyOrCutEvent:(DOMEvent)aDOMEvent +- (BOOL)nativeCopyOrCutEvent:(DOMEvent)aDOMEvent { // This shouldn't happen. if (!supportsNativeCopyAndPaste)