daniel
0a93f2d0b0
Formatting: add missing semi-colons to _CPDatePickerCalendar.j
2018-04-03 12:54:39 -07:00
daniel
fd581cd65c
Formatting: removed variable redeclaration in CGPath.j
...
Variables `arcStartX` and `arcStartY` are declared on 125 and 126, but
are later redeclared in an `else` statement on lines 135 and 136 with
the same equation and presumably the same value used in the initial
declaration.
Also added missing semi-colon
2018-04-03 12:46:56 -07:00
daniel
36702bc971
Formatting: add missing semi-colon to CGContextVML
2018-04-03 12:15:04 -07:00
daniel
0fc3eb38f1
Formatting: Add semi-colons to CGContextCanvas.j
2018-04-03 12:11:57 -07:00
daniel
b8420303ba
Formatting: add missing semi-colon to CPKeyValueBinding.j
2018-04-03 10:55:17 -07:00
cacaodev and GitHub
f6d892023e
Merge pull request #2604 from bedalton/overshadowing-variable-in-_CPCibObjectData
...
Fixed: Variable in if statement overshadows variable in enclosing block
2018-04-03 07:54:11 +02:00
daboe01
6d06a26c31
fixed: typo in method invocation
2018-03-26 17:53:38 +02:00
Daniel
1db740039b
Fixed: Variable in if statement overshadows variable in enclosing block
...
If statement variable ‘instantiatedObject’ on line 229 of
_CPCibObjectData.j overshadows a variable with the same name declared
on line 233 in the enclosing block. Variable is added to array outside
the enclosing if statement.
Refs: #2601
2018-03-20 11:36:19 -07:00
daboe01
df462774aa
refactured front detection logic to own method _isFrontmostWindow
...
fixes travis error
2018-03-20 14:25:42 +01:00
daboe01
488541f26e
fixed: click to key window in the background did not bring it forward
2018-03-18 21:45:25 +01:00
Martin Carlberg and GitHub
69370aa806
Merge pull request #2596 from mrcarlberg/triple_click_noneditable_selectable_empty_textfield
...
Fixed: Crash when triple click an empty CPTextField that is not editable but selectable
2018-03-08 09:17:57 +01:00
daboe01 and Martin Carlberg
b3ddd85b09
Fixed: Editing text in tableviews throws DOM exceptions under certain conditions in Chrome ( #2563 )
...
Previosly, we unflagged ```CPTextFieldInputDidBlur``` and ```CPTextFieldInputResigning``` before
the call to removeChild. This resulted in DOM exceptions in Chrome under certain conditions.
See https://stackoverflow.com/questions/21926083/failed-to-execute-removechild-on-node for
why we need to unflag ```CPTextFieldInputDidBlur``` and ```CPTextFieldInputResigning``` only after removing the element.
This apply to token fields also but with the corresponding flags. Also token fields now have the same behavior as the text field when bluring etc.
2018-03-08 09:17:15 +01:00
Martin Carlberg
033221fd01
Fixed: When triple click in an empty CPTextField that is not editable but selectable this call will crash as _DOMTextElement is nil.
...
This check will make sure it is not called when no element is present. This is the same way as it is done in other parts of this class.
2018-03-07 11:24:21 +01:00
Martin Carlberg and GitHub
511d393c78
Merge pull request #2576 from mrcarlberg/cptextview_delegate
...
New: CPTextView delegate methods added
2018-03-06 09:07:55 +01:00
daboe01 and Martin Carlberg
928f14872e
Fixed: call to nonexistent method ( #2588 )
2018-03-06 08:59:36 +01:00
Martin Carlberg and GitHub
c6a9adf96c
Merge pull request #2556 from daboe01/plainsliderfix
...
Fixed: legacy scrollers used Aristo1 artwork in Aristo2
2018-03-05 11:06:59 +01:00
Martin Carlberg and GitHub
2503d13402
Merge pull request #2594 from daboe01/CPSavePanel-missing-class-method
...
Fixed: +proposedFileURLWithDocumentName: was missing
2018-03-05 11:01:18 +01:00
daboe01 and Martin Carlberg
2d97970d24
Fixed: numberWithInteger: was erroneously used instead of numberWithInt: ( #2587 )
2018-03-05 10:50:30 +01:00
daboe01 and Martin Carlberg
f18012d07b
Fixed: removed erroneous call to sizeValue ( #2589 )
2018-03-05 10:36:22 +01:00
daboe01
19bb083030
fixed: +proposedFileURLWithDocumentName: was missing
2018-03-04 18:40:33 +01:00
Martin Carlberg
9f25743b4d
Fixed: Never send CPTextViewDidChangeTypingAttributes notification when selection the same selection again. This is how Cocoa works.
2018-01-09 13:41:34 +01:00
Martin Carlberg
f1c76f65cf
Fixed: Added some comments on some methods
2018-01-09 13:37:35 +01:00
Martin Carlberg
2b7be2e3f1
Fixed: Make sure the delegate methods and notifications are handled in the same way as in the Cooca frameworks.
...
CPTextViewDidChangeSelectionNotification should not be send if the text view is empty.
CPTextDidBeginEditingNotification is send when an edit is started.
CPTextDidEndEditingNotification is send when an edit is ending.
textShouldBeginEditing: delegate method is called to allow control if edit should start.
textShouldEndEditing: delegate method is called to allow control if edit should end.
2018-01-08 13:56:24 +01:00
Martin Carlberg
1ee9a3f279
Fixed: Check if the correct delegate method is implemented before calling it
2018-01-08 13:47:45 +01:00
Martin Carlberg
679acfb239
Fixed: Register the delegate as an observer on any notification that the delegate implement.
...
Also make sure we remove the observers if for example the view does not have a superview. This will make sure that the Notification Center is not hanging on to the view and delegate if the view is not used any more. Can cause a memory leak.
2018-01-08 13:44:47 +01:00
Martin Carlberg
3c7ab4b49b
Fixed: Make the view aware of some more delegate methods
2018-01-08 13:20:03 +01:00
Martin Carlberg
3f062e1c0a
Fixed: Make all method in CPTextDelegate and CPTextViewDelegate protocol optional.
2018-01-08 13:15:31 +01:00
Martin Carlberg and GitHub
c4cbb631a9
Merge pull request #2561 from mrcarlberg/compile_with_sourcemap
...
Full support for source map when debugging
2017-12-11 10:52:05 +01:00
Martin Carlberg
76f2d15b1b
Fixed: Added the option to only inline message send function without also compress the output javascript file.
...
This allows us to inline the message send function in DEBUG mode. This is great when stepping into a method in the debugger as the message send function is not a separate function. Also the stack traces in the debugger is much more compact as the message send function is not there.
2017-12-08 14:02:11 +01:00
cacaodev and GitHub
5d63865ae5
Merge pull request #2546 from cacaodev/CPSplitView
...
CPSplitView -trackDivider: performance
2017-11-08 18:53:22 +01:00
daboe01
1af3877758
FIXED: scroll-knob was slightly too bold
2017-09-27 11:05:59 +02:00
Martin Carlberg and GitHub
bf67721ac4
Merge pull request #2548 from cacaodev/CPWindow-live-resize-notifications
...
CPWindow live resize notifications
2017-09-25 14:04:01 +02:00
Martin Carlberg
c6aafac6c8
Fixed: Compile Foundation and AppKit frameworks with source maps for the debug version.
2017-09-11 12:50:49 +02:00
daboe01
7a593b13a7
Merge remote-tracking branch 'cappuccino/master' into plainsliderfix
2017-09-09 10:56:37 +02:00
Martin Carlberg and GitHub
25dc38b2b1
Merge pull request #2558 from daboe01/smartcopypastefixes
...
Fixed: smart copy/paste did not work properly [+1]
2017-09-08 09:09:26 +02:00
Alexandre Wilhelm and GitHub
403b12f7b7
Merge pull request #2550 from cacaodev/CPAnimationContext
...
FIXED: CPAnimationContext completionHandler was not called under certain circumstances.
2017-09-07 18:21:56 -07:00
Alexandre Wilhelm and GitHub
cd223be88a
Merge pull request #2557 from daboe01/placeholderselectablefix
...
fixed: cursor blinks for placeholder
2017-09-07 18:21:12 -07:00
Alexandre Wilhelm and GitHub
a6a3fca1e7
Merge pull request #2559 from daboe01/onpaste-ff-fix
...
Fixed: CPTextView's onpaste handler used non-standard window.event
2017-09-07 18:20:32 -07:00
daboe01
63815eb5c2
fixed: onpaste handler used window.event (non-standard)
...
broke paste on FF/win
2017-09-07 19:19:19 +02:00
daboe01
4444264830
formatting
2017-09-04 23:02:50 +02:00
daboe01
255f91f7ca
fixed: cornerview looked odd without scroller margins
2017-09-04 22:59:34 +02:00
daboe01
72d96e9a3b
fixed: smart pasting did not work properly
2017-08-29 15:11:29 +02:00
daboe01
a55b6de1b4
removed: unused artwork from aristo2
2017-08-28 23:32:47 +02:00
daboe01
9faac05666
fixed: cursor blinks for placeholder
2017-08-23 23:07:42 +02:00
daboe01
7bf408aba0
fixed: legacy scrollers used aristo1 artwork in aristo2
2017-08-22 22:02:42 +02:00
cacaodev
f5eb1158db
Fix issue 2549: table rows where invisible when dragging.
2017-07-28 21:35:24 +02:00
cacaodev
81916d0f45
FIXED: A grouping context does not inherit the completion handler ...
...
… from the current context.
Also removed CPAnimationContext -copy method. CPAnimationContext is not
CPCopying compliant.
TEST: CPAnimationContextTest ->
testCompletionHandlerWithoutAnimatorWithGrouping2
2017-07-25 12:04:58 +02:00
cacaodev
03dccbe613
Add a manual test for the previous fixes.
...
The tests must be run independently because animations are launched at
the end of the current run loop.
2017-06-30 12:26:15 +02:00
cacaodev
1ccec65619
Add debug information
2017-06-30 12:03:29 +02:00
cacaodev
b78e9062a1
CompletionHandlerAgent fire() is a one shot.
2017-06-30 12:03:09 +02:00
daniel
cacaodevandGitHub
daboe01
Martin CarlbergandGitHub
Alexandre WilhelmandGitHub