Ross Boucher
7caf5fe20a
Must return from this method.
2010-07-28 14:54:07 -07:00
Aparajita Fishman and Ross Boucher
44a958d3f8
-hitTest was always returning self, which did not allow any other views to receive a mouse down
2010-07-28 14:53:13 -07:00
Aparajita Fishman and Ross Boucher
4c562048dc
More fixes to CPSearchField (Cocoa compliance and bugs):
...
- Added the ability to specify a separator in the template by using the tag CPSearchFieldSeparatorMenuItemTag.
- _recentSearches was not being initialized by -initWithCoder, moved that code into -_init.
- -setSearchMenuTemplate was not being invoked. Since having a recents menu is the default behavior in Cocoa, it should probably be the default behavior in cappuccino. To turn it off, set _maximumRecents to >= 254.
- -searchTextRectForBounds was using the wrong rect for -searchButtonRectForBounds and -cancelButtonRectForBounds, resulting in a rect that was too narrow and did not fill the space.
- Tightened up the spacing between the magnifying glass and the text to exactly Cocoa distance.
- Overhauled -
updateSearchMenu to fix some logic bugs.
- Made sure the search field becomes first responder after closing the search menu.
- Cleared the search string when clearing recent searches, this is what Safari does.
- Removed redundant invoking of -setDelegate in -initWithCoder.
- -_init has to be called last in _initWithCoder.
2010-07-28 14:53:04 -07:00
Aparajita Fishman and Ross Boucher
f3b92c7445
Fixes to cacaodev/searchfield/ffb8f99603d96b903b6bb39bc4dcb15ad09465be...
...
- Replaced CG functions with inline _CG functions
- _canResignFirstResponder was not being initialized to YES
- -resignFirstResponder has to call super if _canResignFirstResponder == YES
2010-07-28 14:51:57 -07:00
cacaodev and Ross Boucher
675e9829bd
CPSearchField: Fixes (per cocoa)
...
- Do not override search button action, catch mouse events in mouseDown: instead.
- Do not resign first responder on searchfield when showing the context menu
- Give more space between search button and insertion point
- Do not add search string to recents searches when typing and sendsWholeString == NO, only on enter.
- Select all text when showing the menu or after selecting a recent search in the menu
- Support custom search/cancel buttons and custom layout
- Allow images in template menu items
- Updated Test App with custom buttons
2010-07-28 14:49:02 -07:00
Ross Boucher
4c0dbda558
Merge remote branch 'klaaspieter/fix/789-observeablearray-removeobjectatindex'
2010-07-28 14:22:14 -07:00
Ross Boucher
e586273a3f
Fix accidental global.
2010-07-28 14:13:12 -07:00
Ross Boucher
d4a0f0cd21
Merge remote branch 'klaaspieter/fix/787-cptablecolumn-editability'
2010-07-28 14:12:49 -07:00
Klaas Pieter Annema and Ross Boucher
8cfba4c242
only offset a nib2cib'ed textfield if it has a bezel
2010-07-28 14:09:11 -07:00
Aparajita Fishman and Ross Boucher
cce13b4b45
NSMenuItem is not reading the tag for some reason
2010-07-28 14:07:45 -07:00
Alexander Ljungberg and Ross Boucher
05e435633f
Fixed: if a custom CPTableView header view was used for a column, such as a CPImageView, sorting by that column would cause an exception as CPTableView tried to send _setIndicatorImage: to the view. The fix is to only send the message if the view supports it.
2010-07-28 13:57:49 -07:00
Mike Fellows and Ross Boucher
6ff3fa0e52
Fix for issue #769 , allow ctrl/cmd keys and F1-F12 keys to propagate to the browser unless they are blacklisted
2010-07-28 13:52:01 -07:00
Aparajita Fishman and Ross Boucher
c3c996f1f7
Don't substitute the font if the textfield is not editable (a label)
2010-07-28 13:50:52 -07:00
Klaas Pieter Annema
ff98a9be5a
fix preserve selection in removeObjects and added unit test
2010-07-28 15:02:48 +02:00
Klaas Pieter Annema
96cef81267
Merge branch 'master' of git://github.com/280north/cappuccino
2010-07-28 13:29:16 +02:00
Klaas Pieter Annema
75ceeffab8
remove commented code from CPArrayControllerTest
2010-07-28 13:28:53 +02:00
Klaas Pieter Annema
71fffb6b68
Merge branch 'master' of git://github.com/280north/cappuccino into cparraycontroller-removeobject
2010-07-27 09:47:28 +02:00
Klaas Pieter Annema
e066228015
Merge branch 'cpindexset-isequal' into arraycontroller-fixes
2010-07-27 09:23:00 +02:00
Klaas Pieter Annema
48a5d55af7
fix CPArrayController selectPrevious: and selectNext:
...
Also added unit-tests for canSelectPrevious, canSelectNext, selectPrevious: and selectNext:
2010-07-27 09:10:41 +02:00
Klaas Pieter Annema
b9c2becd3e
implement CPIndexSet isEqual:
2010-07-27 09:09:59 +02:00
Klaas Pieter Annema
24f72c0b73
Merge branch 'master' of git://github.com/280north/cappuccino into arraycontroller-fixes
2010-07-27 08:47:14 +02:00
Klaas Pieter Annema and Ross Boucher
90e9b86497
match CPTableView's alternating row colors with Aristo's
2010-07-26 22:48:58 -07:00
Klaas Pieter Annema and Ross Boucher
560ea75a25
added CPArrayController to AppKit.j
2010-07-26 22:48:40 -07:00
Klaas Pieter Annema and Ross Boucher
78fd972312
only reverse set the binding on end editing
2010-07-26 22:48:40 -07:00
Klaas Pieter Annema and Ross Boucher
d947c849c8
made _accessorForKey slightly faster by inlining it as a function
2010-07-26 22:48:40 -07:00
Klaas Pieter Annema and Ross Boucher
8ce63a244c
store accessors in a javascript object not a CPDictionary, for slight performance improvement
2010-07-26 22:48:39 -07:00
Klaas Pieter Annema and Ross Boucher
0306c35b54
don't copy the selection indexes in setContent:
2010-07-26 22:48:39 -07:00
Klaas Pieter Annema and Ross Boucher
ff8e5ae42e
save _replacedKeys on the class in stead of the object instance
...
reviewed: Ross
2010-07-26 22:48:39 -07:00
Klaas Pieter Annema
acf5e5b75f
call super in _CPObservableArray removeObjectAtIndex:
...
The current implementation calls self, which causes an infinite loop
2010-07-26 18:44:50 +02:00
Klaas Pieter Annema
4f946f267e
fix CPArrayController removeObject:
...
removeObject: only shifted the selection, it never actually removes the object
2010-07-26 18:44:00 +02:00
Klaas Pieter Annema
abfe2b4be6
Merge branch 'master' of git://github.com/280north/cappuccino
2010-07-26 16:23:28 +02:00
Klaas Pieter Annema
bb3c08ce0b
add CPArrayController test
2010-07-26 14:04:26 +02:00
Klaas Pieter Annema
138888e620
implement CPArrayController insertObject:atArrangedObjectIndex:
2010-07-26 14:04:05 +02:00
Nicholas Small
4e1b429913
Merge branch 'master' of github.com:280north/cappuccino
2010-07-22 15:41:28 -04:00
Randall Luecke
51f780b5f5
Merge branch 'master' of github.com:280north/cappuccino
2010-07-22 00:21:51 -05:00
Randall Luecke
cffbf86351
TableView theming
2010-07-22 00:21:02 -05:00
Ross Boucher
709a9b3c61
Merge remote branch 'klaaspieter/fix-758-cpdate-isequal'
2010-07-21 15:04:10 -07:00
Ross Boucher
c35621b669
Merge remote branch 'klaaspieter/fix-756-cpstring-isequal'
2010-07-21 15:03:43 -07:00
Alexander Ljungberg and Ross Boucher
4d1baac4db
Fixed: first clearing a \r keqyEquivalent from one button and then setting it on another would result in an exception.
2010-07-21 14:57:52 -07:00
Alexander Ljungberg and Ross Boucher
474623feb3
Added support for punctuation based key equivalents such as Cmd-' or Cmd-;. Fixed: [event characters] would contain Þ when Cmd-' was pressed and º for Cmd-; since the key codes for punctuation do not match the ASCII codes and String.fromCharCode does not work. Manual test included.
2010-07-21 14:52:05 -07:00
Klaas Pieter Annema
c17a3533ec
fix #764
...
Array controller inserts object in wrong arranged object position if there are no sort descriptors defined
2010-07-20 14:59:18 +02:00
Ross Boucher
85f3691432
Don't add a "Shift" if it's not required.
2010-07-19 16:27:44 -07:00
Klaas Pieter Annema
2ae8d25d18
don't use === for date equality checking
...
Apparently this will return false for equal dates, reverted the actual equality check to what was already in Cappuccino before my fix !(date < otherDate || date > otherDate)
2010-07-19 13:10:15 +02:00
Nicholas Small
780bdc4421
Generate accessors for _CPSegmentInfo.
2010-07-18 03:05:31 -04:00
Randall Luecke
a2e6f8f964
Initial theming of TableView header.
2010-07-15 22:32:00 -05:00
Klaas Pieter Annema
564668587c
fix CPDate isEqual: and isEqualToDate:
2010-07-15 14:42:48 +02:00
Klaas Pieter Annema
023cf46041
check for nil in CPString isEqual:
2010-07-15 14:39:24 +02:00
Klaas Pieter Annema
36bb41a945
implemented isEqual: on CPString
2010-07-15 12:49:52 +02:00
Randall Luecke
0cbdb3b2d1
Fix for redrawing issues in tableview. Closes #627
2010-07-12 21:14:48 -05:00
Randall Luecke
70f2d86b58
Fixes for adding and removing columns to the tableview after the tableview has already been displayed... There are still issues though.
2010-07-12 20:45:30 -05:00
