Antoine Mercadal
775141b7f7
Merge branch 'themeable-rule-editor' of https://github.com/t00f/cappuccino into themeable-rule-editor
2014-08-14 21:03:45 -07:00
Antoine Mercadal
a2d9c1aa72
Merge pull request #2174 from Dogild/PopoverDelegate
...
Fixed: delegate popover did show not called with a none animate CPPopover
2014-08-14 20:59:29 -07:00
Christophe Serafin
4b639843ec
fixed buttons positions and extended Nib2CibAlignment test
2014-08-14 18:18:08 -07:00
Christophe Serafin
464389a862
update nib2cib-adjustment-frame to match Nib2CibAlignment Test. Except for button in small and mini sizes
2014-08-14 14:17:57 -07:00
Alexandre Wilhelm
48b3eb259d
Fixed: delegate popover did show not called with a none animate CPPopover
...
Previously, the delegate popoverDidShow wasn't called with an none animated CPPopover.
2014-08-14 14:10:37 -07:00
daboe01
4cebfbcd13
removed collectionViewDidChangeSelection
2014-08-14 22:57:05 +02:00
daboe01
1767cf8ad4
formatting+nil equality
2014-08-14 22:41:59 +02:00
daboe01
b1981bb70c
fix activateIgnoringOtherApps:shouldIgnoreOthe...
2014-08-14 22:27:46 +02:00
Christophe Serafin
3dc581efbb
introduce nib2cib-adjustment-frame as theme attribute to enbable proper control alignment
2014-08-14 10:54:38 -07:00
Christophe Serafin
655cc3256c
remove arbitrary CONTROL_HEIGHT
2014-08-14 10:45:12 -07:00
daboe01
ce69410f49
revert of breaking change wrt backspace
2014-08-14 18:21:53 +02:00
daboe01
5f0be0cc7f
make storage length zero more tolerant
2014-08-14 14:14:49 +02:00
Andrew Hankinson
dca6347ea9
Fixed: Remove lingering references to i
...
Refs 75e347e8e3
2014-08-14 07:19:53 -04:00
daboe01
94c4db9072
fixed equality operator
2014-08-14 07:17:00 +02:00
Andrew Hankinson
7f63be2cd2
Formatting: Make if statement more readable
...
The if statement had a lot of sub-clauses. These were factored out into variable assignments.
2014-08-13 19:56:50 -04:00
Andrew Hankinson
1236dea4c5
Fixed: equality operators
2014-08-13 19:47:06 -04:00
Andrew Hankinson
c5c46df613
Fixed: typo
2014-08-13 19:44:23 -04:00
Andrew Hankinson
a96269150a
Fixed: AppKit.j is alphabetized
...
CPTextView.j was out of alphabetical order. This commit fixes that.
2014-08-13 19:34:56 -04:00
Andrew Hankinson
75e347e8e3
Fixed: obscure use of variables
...
Previously, the counting variable "i" was used as a variable throughout this method, leading to the value of 'i' becoming unclear as the method progressed.
Additionally, a later loop in this method redeclared 'i', providing more confusion.
This commit renames 'i' to the more descriptive 'targetLine' and uses that in its place. The redeclared value of 'i' was also renamed to "newTargetLine".
2014-08-13 18:15:58 -04:00
daboe01
d641cc5057
fix fussy optimization
2014-08-14 00:12:02 +02:00
Christophe Serafin
bf5b660cb5
fix background size with 1-part image
2014-08-12 17:26:43 -07:00
Christophe Serafin
712dc493ca
remove CPDateFormater dependancy and CPString convertion
2014-08-12 15:42:03 -07:00
Christophe Serafin
f4fba64ffb
remove test on sendAction
2014-08-12 14:06:37 -07:00
Christophe Serafin
02430916cb
add CPDatePicker without CPStepper in CPControlSize test demo
2014-08-12 13:58:05 -07:00
Christophe Serafin
e3ad115698
correction based on primalmotion comments
2014-08-12 13:56:25 -07:00
Christophe Serafin
c078bb04b2
Correction and optimizations based on Alex comments. Fix for CPDatePickerTest
2014-08-12 13:31:22 -07:00
Antoine Mercadal
d95e133792
Merge pull request #2171 from Dogild/CPTextField-Platform
...
Fixed: Checking if a CPTextField is usable in a CPPlatformWindow
2014-08-12 12:11:50 -07:00
Alexandre Wilhelm
a04f1045bc
Fixed: Checking if a CPTextField is usable in a CPPlatformWindow
...
Previously, when a CPTextField was in a CPPlatformWindow, the checking of if the CPTextField was usable or not (depending on its position) in a CPPlatformWindow didn't take in account the content-inset of the CPTextField. Now it does.
2014-08-12 11:27:25 -07:00
daboe01
cf64145ff3
formatting
2014-08-12 16:06:49 +02:00
daboe01
195eca6b09
typesetter early exit in flushing fix
2014-08-12 15:48:31 +02:00
daboe01
b0ef077e48
fix typesetter nil bug
2014-08-12 15:12:19 +02:00
daboe01
e40a698d1a
fixed accessor
2014-08-12 10:37:05 +02:00
daboe01
69c34b1b27
formatting
2014-08-12 08:33:28 +02:00
daboe01
4700c2583d
fix acessor names
2014-08-12 08:29:28 +02:00
Christophe Serafin
db6975e07a
force size only for bordered buttons and bezeled textfields
2014-08-11 18:08:15 -07:00
Christophe Serafin
93127489e7
stop forcing font on CPButton and CPTextField. If the developper wants to set a bigger font it is possible in Cocoa
2014-08-11 17:25:31 -07:00
Christophe Serafin
83064294ac
remove useless images and declaration
2014-08-11 15:04:35 -07:00
Christophe Serafin
0b64758360
adjust CPPopUpButton alignment
2014-08-11 15:04:06 -07:00
Christophe Serafin
4e1a2c04a5
create a CPControlSize Manual test to verify control sizes with a certain theme
2014-08-11 14:27:01 -07:00
Christophe Serafin
8412c1db21
enable autoresize theme images instead of creating small and mini images. Remove all existing small and mini images
2014-08-11 14:25:02 -07:00
Antoine Mercadal
18a7a9fdce
Merge pull request #2168 from Dogild/CPOutlineView-fixed
...
Fixed: Memory leaks in CPOutlineView + corrupted itemInfos dictionary
2014-08-11 14:15:59 -07:00
Antoine Mercadal
fc90d00354
Merge branch 'master' of https://github.com/cappuccino/cappuccino
2014-08-11 12:47:12 -07:00
Antoine Mercadal
55861a8f44
FIXED: transient popovers were not close with right click
...
This patch ensure that is a popover is transient and the user right clicks outside, it closes properly.
2014-08-11 12:46:09 -07:00
Alexandre Wilhelm
4fbd307163
Fixed: refactoring of the class CPOutlineView
2014-08-09 15:10:25 -07:00
Alexandre Wilhelm
3e4c03852d
Fixed: Memory leaks in CPOutlineView + corrupted itemInfos dictionary
...
Previously, when reloading a CPOutlineView with different datas than before, the CPOutlineView kept a reference of the previous datas.
Now, when reloading, the CPOutlineView will delete these references when we don't need it anymore. For that, the CPOutlineView will only try to delete the previous reference when we have reloaded the children of a node, otherwise it will keep the other references.
This PR fix some issue with the following methods :
- (BOOL)isExpandable:(id)anItem;
- (BOOL)isItemExpanded:(id)anItem;
- (CPInteger)rowForItem:(id)anItem;
- (CPInteger)levelForItem:(id)anItem;
- (id)itemAtRow:(CPInteger)aRow;
- (CPInteger)levelForItem:(id)anItem;
- (CPInteger)levelForRow:(CPInteger)aRow;
Previously these methods took care about not displayed items. Now they just work with displayed items.
Added unit-tests in Test/AppKit/CPOutlineViewTest.j
Test app in Test/Manual/CPOutlineViewTestCib
2014-08-08 15:05:24 -07:00
Christophe Serafin
c8a04b998b
update origin Y according to control Size
2014-08-07 18:27:01 -07:00
Christophe Serafin
568a652fb4
added default CPButton images
2014-08-07 18:26:32 -07:00
Christophe Serafin
a2c9b5c042
added choices in list to test CPPredicateEditor with CPPopupButton
2014-08-07 16:51:36 -07:00
Christophe Serafin
fd3a4b069d
removes CPRuleEditorPopUpButton and use CPPopUpButton directly
2014-08-07 16:50:52 -07:00
Christophe Serafin
4aaafa6de7
fix CPDatePicker alignment in CPPredicateEditor. fixes #2162
2014-08-07 16:50:23 -07:00