Aparajita Fishman
1c2a304ee5
Assignment of function is a statement and should be semicolon terminated. Some miscellaneous linting as well.
2012-01-05 17:51:37 -10:00
Alexander Ljungberg
15af54efda
Fixed with CPTokenField: quickly entered tokens would be ignored.
...
If the autocomplete state had not been set yet, tokens could not be finished using the token separator, return or tab. Instead the user typed text remained in its 'non token' state.
2011-11-16 12:52:27 +00:00
Alexander Ljungberg
07966bb7fe
Fixed with CPTokenField: crash if added to a window in a unit test.
2011-11-16 12:50:05 +00:00
Alexander Ljungberg
e7d9b0503b
Fixes #1398 . Fixed with CPTokenField: deleting tokens in front of selected tokens would shift the selection to the right.
2011-11-16 12:04:03 +00:00
Alexander Ljungberg
072b43d178
Fixes #1397 . Fixed with CPTokenField: make sure selection is initialised when loading from cib.
2011-11-16 11:55:38 +00:00
Antoine Mercadal
b424c19eee
optimization
2011-10-03 17:28:32 +02:00
Antoine Mercadal
4d597069cf
fix problem in CPTokenField with wrong theme state if containing tokens
2011-10-03 17:08:21 +02:00
Alexander Ljungberg
48157db973
Refs #1360 . Fixed: index was always 0 in CPTokenField tokenField:shouldAddObjects:atIndex: delegate method.
2011-09-16 21:52:09 +01:00
Alexander Ljungberg
a8fae51ea8
Refs #1360 . Cursor movement fixes, optimisations.
...
Don't move the cursor forward if no token was inserted. Only count new tokens once.
2011-09-16 21:46:20 +01:00
Alexander Ljungberg
85f8ca9241
Refs #1360 . Format code.
2011-09-16 19:29:53 +01:00
Samir Gartner
e5284e9b43
Fixed some possible error of my part where selectedRange is moved beyond bounds
2011-09-09 22:31:17 -05:00
Samir Gartner
c6403baa04
Fixed cursor position issue in a little escapade...guess that's all for now folks
2011-09-09 13:28:37 -05:00
Samir Gartner
662b1ec696
Submitted the right CPTokenField file, was missing the part to use the delegate approved tokens. Still lacks a way to put the cursor after the last token (if the delegate returns more than one token)
2011-09-09 12:48:18 -05:00
Samir Gartner
043df71185
Enabled tokenField:shouldAddObjects:atIndex delegate method and used on _autocompleteWithDOMEvent method to have some control over tokens. Not sure why wasn't enabled, it was very few code. Maybe no one needed it 'til now
2011-09-08 22:56:52 -05:00
Alexander Ljungberg
f773bd217c
Fixed with token field: remove false ivar '_tokenIndex' and fix tokenField:tokenField completionsForSubstring:indexOfToken:indexOfSelectedItem: ignoring its indexOfToken: parameter.
2011-08-12 19:46:39 -04:00
Alexander Ljungberg
a5f0f0e3db
CPTokenField archiving support.
2011-08-12 19:29:59 -04:00
Stephen Ierodiaconou
6a942630e4
Fixing spelling mistakes
2011-01-24 11:05:48 +02:00
Alexander Ljungberg
0943065498
Merge branch 'master' of github.com:280north/cappuccino into eventualbuddha-CPTokenField-sendAction-fix
...
Conflicts:
AppKit/CPTokenField.j
2011-01-07 18:53:44 -03:00
Alexander Ljungberg
6d7dc24775
Merge branch 'CPTokenField-sendAction-fix' of https://github.com/eventualbuddha/cappuccino into eventualbuddha-CPTokenField-sendAction-fix
2011-01-07 18:14:17 -03:00
Klaas Pieter Annema
3d5232b308
give objects a chance to change their binder class
...
- make every object calling getBinding:forObject: aware of this change
- implement _CPCheckBoxValueBinder to handle binding to the value of a checkbox Closes : #1083
- re-implement CPTextField's behavior for controller markers using the new binder class
- disabled some tests that are not compliant with Cocoa
2011-01-07 14:14:19 +01:00
Brian Donovan
978545af94
Import required CPTableView.
2010-12-19 11:46:13 -08:00
Brian Donovan
69c004093d
CPTokenField did not send its action on end edit.
...
Also fixes that the CPNotification sent out was CPControlTextDidBeginEditingNotification, not CPControlTextDidEndEditingNotification.
2010-11-23 10:47:59 -08:00
Alexander Ljungberg
381a6a999b
Fixed a bad var statement in CPDecimal. Cleanup.
2010-11-17 21:58:58 -03:00
Luc Vauvillier
8b9a0edeba
Fix CPTokenField autocompletion to deal with represented objects
2010-11-15 15:51:21 +01:00
Luc Vauvillier
0f8aa1e644
Support object representation in CPTokenField
...
Add some tests
2010-11-15 13:14:53 +01:00
Francisco Ryan Tolmasky I
52f7844aee
Made it so .h files are automatically included in AppKit (avoiding needing to manually include Platform.h, etc.).
...
Also changed a bunch of <AppKit/*> imports to "*" imports.
Reviewed by me.
2010-11-01 11:10:01 -07:00
Klaas Pieter Annema
64aeea0f08
Merge branch 'runtime-theming'
2010-11-01 14:04:22 +01:00
Alexander Ljungberg
eb39e2e81a
Optimise token field redraws when adding or deleting tokens by recycling token fields. This eliminates the flicker of all previous tokens whenever a new token was added.
2010-10-29 14:40:46 -03:00
Klaas Pieter Annema
6e9f82212b
rename CPView +themeClass to +defaultThemeClass
2010-10-25 14:15:22 +02:00
Alexander Ljungberg
b95bdca2a3
Lint cleanup.
2010-10-23 20:47:11 -03:00
Alexander Ljungberg
6fd5f66a15
Support forward delete in token fields.
2010-10-23 20:42:01 -03:00
Alexander Ljungberg
9e235f7236
Fixed: clicking tokens in a token field could disable its keyboard handling due to the input field losing focus.
2010-10-23 20:21:02 -03:00
Alexander Ljungberg
90d12ef77e
Place the cursor correctly when arrow keys are used with one or more tokens selected. Fixed: the layout would not update to remove the gap for the editor if between tokens when resigning first responders.
2010-10-23 19:31:08 -03:00
Alexander Ljungberg
0c2301766a
Place the cursor after the last inserted token when editing.
2010-10-23 17:09:46 -03:00
Alexander Ljungberg
8a7b6054ef
If the text editing part of the token field is the last in the line, make it take up the remaining field width so that it captures clicks there.
2010-10-23 16:58:02 -03:00
Alexander Ljungberg
7037151bfc
Fixed: clicking a token would cause the token field to resign first responder status, only to reclaim it on mouse up.
...
This was caused by the framework's stop DOM event code blurring the field. Now simply refuse to resign first responder status between mouse down and mouse up. Note that this fixes the bug the previous commit did too, but that commit improves other scrolling behaviour so it gets to stay.
2010-10-23 16:00:45 -03:00
Alexander Ljungberg
ba26b19567
Fixed: if the token field was scrolled up and a token was clicked, the scroll position would jump back down.
2010-10-23 15:41:41 -03:00
Alexander Ljungberg
6587014014
Improve token field scrolling behaviour and performance: only resize the document view frame when necessary to prevent the loss of scroll position and display jumps. Fixed: if a token on a new line was clicked, the view would scroll up to the first line.
2010-10-23 14:36:42 -03:00
Alexander Ljungberg
07330a0ca8
Select tokens by clicking on them. Select multiple tokens by holding down shift. Also fixed a bug when deleting multiple tokens at a time.
2010-10-23 13:49:36 -03:00
Alexander Ljungberg
d68f4359ac
Reduce token shifting when a token is selected. Ideally there shouldn't be any shifting at all, but placing a tiny editor at the right spot simplifies scroll handling.
2010-10-23 00:22:40 -03:00
Alexander Ljungberg
d4cfa4b24f
Minor optimisations and cleanup.
2010-10-23 00:00:00 -03:00
Alexander Ljungberg
2912acb4f5
Simplify: remove _selectedTokenIndexes since we now have _selectedRange. Hide the editor when tokens are selected. Preserve cursor position when tokens are deleted.
2010-10-22 23:45:48 -03:00
Alexander Ljungberg
85683d8f18
Navigate among tokens with the arrow keys. Insert and delete tokens relative to the cursor.
2010-10-22 20:43:40 -03:00
Alexander Ljungberg
e66f22d094
Allow the editor to be placed anywhere based on a selection range.
2010-10-21 23:46:03 -03:00
Alexander Ljungberg
d0b29fd38c
Fix resizing and initial sizing of token fields.
2010-10-21 17:49:41 -03:00
Alexander Ljungberg
28378ff19b
Minor performance tweaks.
2010-10-21 17:11:47 -03:00
Alexander Ljungberg
b4f2f15698
Fixed: if a token field had many tokens and a long token name was entered, that token name had to be edited in the small amount of space left on the right hand side of the token field. Now the editor wraps to a new line as needed.
2010-10-21 17:04:09 -03:00
Alexander Ljungberg
2210c1f4c5
Implemented token field overflow support as in Cocoa: if more tokens than can fit are entered, they wrap to a new line. If the new line does not fit within the height of the token field, the previous line is scrolled out of view.
...
Note: this replaces the previous non Cocoa behaviour where the token field would grow height-wise with new tokens. This behaviour can still be useful, as seen in Apple Mail, but it will now require the user to subclass CPTokenField, override layoutSubview and set the frame size to the size of the scroll view's document view.
2010-10-21 15:56:17 -03:00
Alexander Ljungberg
d63e4f8021
Remove some placeholder comments for methods which now exist.
2010-10-21 00:47:58 -03:00
Alexander Ljungberg
8ec78f20d1
Implement _minimumFrameSize for CPTokenField tokens. Also honor min-size width - not used by Aristo but potentially useful for custom themes.
2010-10-15 12:40:09 -03:00