Antoine Mercadal
6bd9a08460
Fixed: CPAlert always shows on main platform window
...
Previously, a CPAlert was always shown on the main platform window. This behavior could result in a feeling that the application was hanging because of the modal nature of the alert when users are looking to another platform window. This fix ensure to set the CPAlert window's platformWindow to the current key window using [[CPApp keyWindow] platformWindow].
2013-04-26 10:34:48 -07:00
Alexander Ljungberg
5b05dc92a1
More dictionary literals.
2013-02-25 18:27:44 +00:00
Alexander Ljungberg
854780a22a
Fixes #1754 . Fixed: CPAlert ignoring keyboard interaction, not movable by background.
...
Without this fix, a CPAlert window couldn't actually become the key window which meant it couldn't receive keyboard events such as using the escape key to close the alert or hitting enter to activate the default button.
Furthermore the window could not be moved by clicking its background and dragging.
This fix makes CPAlert windows into CPPanels instead, which can become key windows and is more appropriate since panels are meant for auxiliary windows.
2013-02-20 19:56:23 +00:00
Aparajita Fishman
caed991cb1
Reformat to make it actually readable, fixed a wrong value
2013-02-11 11:05:55 -05:00
Alexandre Wilhelm
aa40a039f9
Fixed bug with position of buttons in CPAlert
2013-02-01 14:50:46 -08:00
Aparajita Fishman
93fb849296
Import fixes
2013-01-24 19:18:39 +08:00
Aparajita Fishman
4f377bcebe
Objj2 compiler fixes
...
Compiled all files individually:
- Added missing imports.
- Added @class/@global declarations to break circular dependencies.
- Misc. code cleanup.
Conflicts:
AppKit/CPWindow/_CPWindow.j
AppKit/Platform/DOM/CPPlatformWindow+DOM.j
2013-01-23 15:48:55 +07:00
Aparajita Fishman
17f07ee888
capp_lint will not flag CPRectEdge, more linking
2013-01-20 07:24:00 +07:00
Martin Carlberg
458fa9d02e
Fixed a lot of small bugs found by new warning message from compiler
2013-01-18 14:24:37 +01:00
Antoine Mercadal
c0d33a1a19
Merge branch 'master' into Aristo2
...
Conflicts:
AppKit/CPAlert.j
2013-01-14 10:57:03 -08:00
Aparajita Fishman
0e82504daf
Formatting
2013-01-12 16:57:59 +07:00
Aparajita Fishman
7fdc3abd30
Missing semicolon
2013-01-12 16:24:26 +07:00
Alexandre Wilhelm
f30e846f09
Added theme value to set the position of the buttons relative to the type of window
2013-01-11 13:54:18 -08:00
Alexandre Wilhelm
aa1559b159
Added missing images
2013-01-04 11:57:12 -08:00
Alexandre Wilhelm
4757648349
CPAlert can be moved now
2013-01-03 18:34:22 -08:00
Alexandre Wilhelm
a1f166942c
Added new modal window
2013-01-03 18:14:13 -08:00
Alexander Ljungberg
2a11bdb7ef
Fixup: previous fix undid penultimate fix.
2012-12-18 00:34:14 +00:00
Alexander Ljungberg
3775c3fb2e
Fixed: CPAlert was a CPView.
...
Before this fix, CPAlert subclassed CPView, causing an API mismatch with Cocoa and exposing unexpected methods in the public API which made no sense for a CPAlert such as autoresizing masks. It also lead to CPAlert mistakingly shadowing _window from its CPView superclass.
This fix makes CPAlert inherit from CPObject as it should. The theming, which needs to be applied to a view, was moved to an internal view.
2012-12-18 00:22:19 +00:00
Alexander Ljungberg
cea120945c
Fixed: CPAlert sheet crash.
...
Without this fix, CPAlert windows would not finish closing before sending the `alertDidEnd:returnCode:` delegate message. This would lead to a crash if the delegate method tried to open a new sheet.
This fix makes sure to fully order out the alert sheet before sending the delegate message.
2012-12-18 00:19:04 +00:00
Antoine Mercadal
0fa499bd61
Makes CPAlert above popovers
2012-10-30 11:09:38 -07:00
Darrell Walisser
97b3679101
Merge remote-tracking branch 'upstream/master'
...
Conflicts:
AppKit/CPApplication.j
AppKit/CPWindow/_CPDocModalWindowView.j
2012-07-29 12:31:47 -04:00
Darrell Walisser
8fd5f30b87
-call orderOut: to dismiss the alert sheet
2012-04-28 20:28:09 -04:00
Randall Luecke
340b86e97f
CPAlert shouldn't use 'alert' as a variable name
2012-04-13 10:59:30 -04:00
Alexander Ljungberg
3cee00323c
Don't separate statements by commas.
2011-11-10 12:31:16 +00:00
Brian Donovan
156610ee07
Allow CPAlert subclasses to use +alertWithMessageText:... et al.
2011-08-05 08:32:44 -07:00
Stephen Ierodiaconou
6a942630e4
Fixing spelling mistakes
2011-01-24 11:05:48 +02:00
Alexander Ljungberg
e8b1063647
Whitespace cleanup.
2010-12-29 23:17:18 -03:00
Antoine Mercadal
60ff3ca0a1
Support for HUD style
...
use [alert setTheme:[CPTheme defaultHUDTheme]] or [alert setTheme:[CPTheme defaultTheme]] to switch theme.
Add deprecated procies setWindowStyle: and windowStyles;
2010-11-11 18:24:17 +01:00
Antoine Mercadal
6b42ef3cb1
fix: CPAlert fails to runModal if ran sheetModal before
2010-11-11 17:38:39 +01:00
Nicholas Small
5c961d4f16
Restore CPAlert -setTitle: functionality.
2010-11-10 17:43:21 -05:00
Nicholas Small
c21cdc2916
Cleanup CPAlert.
2010-11-10 17:39:56 -05:00
Antoine Mercadal
3bfa427134
Add setTitle: and title, deprecated proxies for setMessageText: and messageText
...
Add some missing Cocoa accessors
Fix acessors for messageText and informativeText that returned CPTextField instead of CPString
2010-11-10 11:02:27 +01:00
Antoine Mercadal
9a8c4bd431
move CPAlertLabelOffset to a theme attribute
2010-11-10 10:25:23 +01:00
Antoine Mercadal
dc72b55361
remove the title of the panel. Cocoa doesn't display any title
2010-11-09 18:33:39 +01:00
Antoine Mercadal
ee4ef882dd
add X and Y offet theme properties for supression button
2010-11-09 18:27:26 +01:00
Antoine Mercadal
23c2f4bb8c
remove the movable thing and remove the bezel-color them attribute
2010-11-09 18:08:13 +01:00
Antoine Mercadal
bd01955f39
support for setShowsSupressionButton
2010-11-09 18:02:24 +01:00
Antoine Mercadal
ee343c7533
make window not movable by dragging background if sheet + capp_lint/sorting/cleaning/commenting
2010-11-09 17:01:11 +01:00
Antoine Mercadal
961071e3fa
refactor a method
2010-11-09 16:55:33 +01:00
Antoine Mercadal
0219341ee8
add support for setShowHelp:
2010-11-09 16:41:41 +01:00
Antoine Mercadal
bf63147ca3
Cleaning CPAlert, add accessoryView
2010-11-09 15:21:25 +01:00
Francisco Ryan Tolmasky I
52f7844aee
Made it so .h files are automatically included in AppKit (avoiding needing to manually include Platform.h, etc.).
...
Also changed a bunch of <AppKit/*> imports to "*" imports.
Reviewed by me.
2010-11-01 11:10:01 -07:00
Klaas Pieter Annema
6e9f82212b
rename CPView +themeClass to +defaultThemeClass
2010-10-25 14:15:22 +02:00
Aparajita Fishman and Alexander Ljungberg
b823eb7fe0
Fixes for Cocoa compliance
2010-08-27 14:04:28 -04:00
Alexander Ljungberg
65d957f9f5
Fixed: an ivar was not being properly initialized in CPAlert.
2010-08-24 14:00:12 -04:00
Alexander Ljungberg
9968896bbd
When running CPAlert as a sheet, automatically activate the CPDocModalWindowMask window style if needed.
2010-08-24 12:14:24 -04:00
Alexander Ljungberg
1a27ae39a3
Removed CPAlert long message test from last commit since this branch already has its own long message test. Also slight clean up.
2010-08-24 11:58:36 -04:00
cacaodev and Alexander Ljungberg
ee4802e513
CPAlert: Attached alerts. Added a new method -beginSheetModalForWindow: that calls -alertDidEnd:returnCode: on ending. CPAlertTest update testing it.
...
Fixed a bug in CPWindow where the didEndSelector was reset too early. This bug was visible only when trying to chain sheet alerts.
Fixed a local/instance variable conflict in AttachedSheet/AppController.j
2010-08-24 11:50:44 -04:00
Alexander Ljungberg
447c33b806
Don't layout CPAlert in layoutSubviews since it's not a real view. This avoids the theme showcase error where the CPAlert windowing code was activated by the theme descriptor setup.
2010-08-22 23:01:52 -04:00
Alexander Ljungberg
e766a2c945
Fixed: if a CPAlert message was 3 lines or more and there was no informative text, the upper half of the CPAlert buttons would not react to clicks as the blank informative label partially covered them.
2010-08-21 17:47:03 -04:00