Aparajita Fishman
7747bbffcf
Fixed key loop calculation, might as well use _initialFirstResponder instance variable instead of accessor
2012-06-28 10:01:07 -07:00
ggsato
db47d8fb85
fixed needsUntitled evaluation
2012-06-28 12:01:37 +09:00
Alexander Ljungberg
c52315cd8d
Refs #1572 . Merge extra commit re highlights.
2012-06-25 21:58:02 +01:00
Alexander Ljungberg
a2787f8783
Formatting.
2012-06-25 21:57:28 +01:00
Ilya Kulakov
913308d886
Refs #1572 . Fix highlighted status is not preserved.
...
When higlightsBy == CPNoCellMask and showsStateBy == CPChangeBackgroundCellMask
higlighted status must be preserved when a user switch state from Off to On.
2012-06-26 03:54:59 +07:00
Alexander Ljungberg
21bb383193
Refs #1527 . Fix button performClick: highlight.
...
Critically this is what enables button highlighting on key equivalents.
2012-06-25 18:13:16 +01:00
Alexander Ljungberg
bd83885eca
Refs #1527 . Backwards compatibility.
...
If no highlight or state masks were encoded (button was encoded prior to them being added), make sure to let the default settings stand.
2012-06-25 17:42:31 +01:00
Alexander Ljungberg
d34d139658
Refs #1572 . Default CPButton type.
...
If a button is created in code it should act like a regular momentary push in button by default.
2012-06-25 17:21:56 +01:00
Alexander Ljungberg
f5c201c0be
Refs #1572 . Fixed: CPPushInCellMask in showsStateBy.
...
Code didn't match comment.
2012-06-25 17:18:07 +01:00
Alexander Ljungberg
10fcc0c452
Refs #1572 . Minor fixes.
2012-06-25 16:26:44 +01:00
Alexander Ljungberg
378822b777
Merge pull request #1572 from slevenbits/cpbutton-masks
...
CPButton and subclasses respect highlightsBy and showsStateBy masks now.
Conflicts:
AppKit/CPButton.j
Tests/Manual/CPButtonTest/AppController.j
Tests/Manual/CPButtonTest/Info.plist
Tests/Manual/CPButtonTest/Resources/MainMenu.cib
Tests/Manual/CPButtonTest/Resources/MainMenu.xib
2012-06-25 16:05:03 +01:00
Alexander Ljungberg
edebb81ed4
Merge pull request #1570 from aradabaugh/cpbutton-types
...
Enable additional button types for CPButton
2012-06-25 15:40:23 +01:00
Ilya Kulakov
7cf3ac3b40
CPButton and subclasses respect highlightsBy and showsStateBy now.
2012-06-25 18:57:10 +07:00
Ilya Kulakov
c46c365823
Extenend CPButtonTest to test highlightsBy and showsStateBy.
2012-06-25 18:57:06 +07:00
Ilya Kulakov
66f5e1fb64
Take into account highlightsBy and showsStateBy when decoding cib.
...
nib2cib was modified to take into account these variables
during conversion nib->cib.
2012-06-25 18:57:01 +07:00
Ilya Kulakov
c80417c433
Add highlightsBy method that returns current higlightsBy mask.
2012-06-25 18:56:56 +07:00
Martin Carlberg
32e3df1e80
Added key value binding support for CPPopupButton
2012-06-25 08:23:14 +02:00
Malte Tancred
3f65153d4f
Corrected the format specifier for the flags variable.
2012-06-23 22:46:25 +02:00
Adam Radabaugh
5fbf0f83cb
Make the check for CPOnOffButton tracking correctly use the highlights mask.
2012-06-23 14:26:46 -06:00
Adam Radabaugh
84c8427bb4
Merge branch master
2012-06-23 14:21:45 -06:00
cacaodev
539a8f0ca9
An OJTest for the table view's content binding
2012-06-22 21:59:41 +02:00
cacaodev
6281f188f8
Merge branch 'cptextfield-cpthemestateeditable' into CPTableViewLion
2012-06-22 18:27:25 +02:00
cacaodev
a444a7de19
Merge remote-tracking branch 'upstream/master' into CPTableViewLion
2012-06-22 18:27:18 +02:00
cacaodev
4369f4b5bb
Set CPThemeStateEditable in setEditable: Add to Aristo theme desc. for table view data views
2012-06-22 18:12:35 +02:00
cacaodev
3689a7f17f
CPTableView: support -editColumn:row:... for view-based tables even if this is not the prefered way to edit a view. If called, just makes the view first responder.
2012-06-22 17:55:44 +02:00
Alexander Ljungberg
d39849b297
Improve token field keyboard navigation when tokens are selected.
...
If one or more token is selected and the left arrow key is pressed, collapse the selection to the left of the first selected token.
Similarly, on right arrow key collapse to the right of the last token.
Note that shift-left and shift-right have no effect if the first or last token respectively in the field are already selected.
2012-06-21 19:24:22 +01:00
Alexander Ljungberg
7764921c21
Select all support for CPTokenField.
...
Cmd-A (Mac) or Ctrl-A (other) finishes any ongoing editing and selects all tokens in a token field.
This commit also adds support for the `selectText:` and `selectAll:` methods.
2012-06-21 19:17:34 +01:00
Alexander Ljungberg
26ceb25e7b
Merge pull request #1569 from slevenbits/rwelephant-token-field
...
Token field improved autocomplete, key bindings support, clean up
2012-06-21 10:32:33 -07:00
Aparajita Fishman
13423e43d5
Removed stray console.log
2012-06-20 11:05:22 -07:00
Aparajita Fishman
45da163230
text tweak
2012-06-18 09:31:34 -07:00
aparajita
281e3c925c
Merge pull request #1566 from slevenbits/CPArrayController-tweaks
...
CPArrayController tweaks
2012-06-18 09:03:22 -07:00
Aparajita Fishman
6f50900b1b
Added missing removeObjectAtArrangedObjectIndex, added missing return
2012-06-18 09:00:59 -07:00
cacaodev
6b051d77ab
Comment
2012-06-17 12:14:36 +02:00
cacaodev
10ae5bfbc0
Merge remote-tracking branch 'upstream/master' into CPTableViewLion
2012-06-17 12:10:37 +02:00
Alexander Ljungberg
2200e40001
Fixed: browser shortcuts wouldn't work when a token field was active.
...
We now leave the default propagation policy of Cappuccino in place, which normally is NO for regular characters but YES for things which could be shortcuts.
2012-06-16 12:31:50 +01:00
Alexander Ljungberg
44b609f604
Don't make space for editing in token field if tokens are selected.
...
If the editor is placed while there is a token selection it can cause the token view to become scrollable to a white area at the bottom even that there is no editing cursor. And even if the editor is not at the bottom, the empty space made for the editor makes no sense when no editing cursor is visible.
2012-06-16 12:31:50 +01:00
Alexander Ljungberg
d5918157ff
Overwrite selected tokens by typing support.
...
If tokens are selected in `CPTokenField` and new text is entered, the selected tokens are overwritten by the newly entered text.
2012-06-16 12:31:50 +01:00
Alexander Ljungberg
19b53746cf
Fix nil representedObjectForEditingString: response handling.
...
If `tokenField: representedObjectForEditingString:` returns nil, act the same as if the delegate method didn't exist. This matches Cocoa.
2012-06-16 12:31:50 +01:00
Alexander Ljungberg
d0769ec360
Oops. Fix object value fix.
2012-06-16 12:31:49 +01:00
Alexander Ljungberg
3c20bf8ad6
Allow token field insertText: to be somewhat overridden.
...
If `insertText:` is overridden to do nothing, nothing in inserted.
2012-06-16 12:31:49 +01:00
Alexander Ljungberg
3eab2a528f
Make token field object value more like Cocoa.
...
If a half typed token is in the field, Cocoa tries to convert it to a representedObject before responding to objectValue. Now CPTokenField does the same.
2012-06-16 12:31:49 +01:00
Alexander Ljungberg
fb404a0671
Hide private token field API. Fix return type.
2012-06-16 12:31:49 +01:00
Alexander Ljungberg
6d6cf52180
Minor token field optimisation.
2012-06-16 12:31:49 +01:00
Alexander Ljungberg
e9ba326610
Inlineable range functions.
2012-06-16 12:31:49 +01:00
Alexander Ljungberg
55ca956f50
Remove nonstandard CPCopyRange.
2012-06-16 12:31:49 +01:00
Alexander Ljungberg
f43c643d5a
Allow token field subclasses to override defaultCompletionDelay.
...
Also fixed incorrect return type.
2012-06-16 12:31:49 +01:00
Alexander Ljungberg
69f5fc536c
Key bindings support for token field.
...
Also improve compatibility with `CPTextField` superclass and subclassing support by properly using `interpretKeyEvents:` like `CPTextField`.
2012-06-16 12:31:49 +01:00
Alexander Ljungberg
132ac7c03f
Token field 'keyUp:' support.
2012-06-16 12:31:49 +01:00
Alexander Ljungberg
5683af9bc8
Improve token field subclassing support.
...
Token field now triggers autocompletion from textDidChange: which better meets the expectations of Cappuccino programmers, and is closer to how Cocoa does it.
Eliminated custom non-Cappuccino key press handler.
2012-06-16 12:31:48 +01:00
Alexander Ljungberg
429933f601
Fix token field keyDown: handling.
...
`CPTokenField` had custom key down handling making it function poorly with Cappuccino's event handling and subclasses.
2012-06-16 12:31:48 +01:00