Stephen Ierodiaconou and Ross Boucher
935f1084d6
Javascript Date object returns month between 0 and 11
2010-06-06 12:05:11 -07:00
Saikat Chakrabarti and Ross Boucher
c8759babae
Adding checks for existence of DOM when calling CPPlatformWindow+DOM-only methods
...
Conflicts:
AppKit/CPWindow/CPWindow.j
2010-06-06 11:48:15 -07:00
Francisco Ryan Tolmasky I
ab3d648244
Fix for browser:acceptDrop:atRow:column:dropOperation: not being called if browser:validateDrop:proposedRow:column:dropOperation: is implemented.
...
Reviewed by me.
2010-06-04 19:21:43 -07:00
Randall Luecke
57dc0460a3
Fixed theme state for CPBrowser.
2010-06-03 21:09:18 -05:00
Randall Luecke
d5ee07fe1b
CPControl should not be allowed to performClick: if it's disabled.
2010-06-02 20:43:09 -05:00
Klaas Pieter Annema
89e3618d85
Merge branch 'master' of git://github.com/280north/cappuccino
2010-06-02 15:37:11 +02:00
Randall Luecke
162381a73f
Removed worthless variable in the collectionview.
2010-06-01 19:16:02 -05:00
Klaas Pieter Annema
08db857334
Merge branch 'master' of git://github.com/280north/cappuccino
2010-06-01 10:16:11 +02:00
Randall Luecke
bb651d0c70
Added multiple selection support to the collectionview.
2010-06-01 01:53:26 -05:00
klaaspieter and Randall Luecke
d9c094f644
call tableview doubleclick action even if target is nil (action will travel down the responder chain)
...
Conflicts:
AppKit/CPTableView.j
2010-05-31 19:14:54 -05:00
Klaas Pieter Annema
32040bdd7e
Merge branch 'tableview-doubleclick'
...
Conflicts:
AppKit/CPTableView.j
2010-05-31 15:44:24 +02:00
Klaas Pieter Annema
43f0e43de7
call tableview doubleclick action even if target is nil (action will travel down the responder chain)
2010-05-31 15:41:52 +02:00
Klaas Pieter Annema
5122b15ffb
Merge branch 'windowcontroller-loadwindowfix'
2010-05-31 13:48:23 +02:00
Klaas Pieter Annema
468d8e7c33
call windowWillLoad and windowDidLoad if the window is set directly from the initializer
2010-05-31 13:45:51 +02:00
Klaas Pieter Annema
93b1d1e591
Merge branch 'master' of git://github.com/280north/cappuccino
2010-05-31 10:34:52 +02:00
Ross Boucher
1642149228
Missing #include had broken the slider color picker.
2010-05-28 12:45:15 -07:00
Ross Boucher
8fd564b034
Minor cleanup to the current test cases.
2010-05-28 10:54:45 -07:00
Ross Boucher
7c3f94dd87
Merge remote branch 'klaaspieter/bindings-fixes' into bindings
...
Conflicts:
AppKit/CPControl.j
Foundation/CPValueTransformer.j
2010-05-28 10:23:47 -07:00
Klaas Pieter Annema
eacd408ce8
Fixed a typo in CPObjectController
2010-05-27 15:23:09 +02:00
Klaas Pieter Annema
084da71420
exposed more bindings on CPControl
2010-05-27 15:22:40 +02:00
Alexander Ljungberg
3fa47ee9ec
Fixed: [_CPImageAndTextView setDimsImage] wasn't working right due to checking if a non existent variable equalled the current value.
2010-05-26 20:09:01 -04:00
Alexander Ljungberg
e811895570
Fixed: CPObjectController keyPathsForValuesAffectingX typos.
2010-05-26 20:06:32 -04:00
Alexander Ljungberg
47e890b8e1
Fixed table row drag view when using bindings.
2010-05-26 20:02:12 -04:00
Alexander Ljungberg
f2bb27dc32
Fixed: [CPArray isEqualToArray:nil] threw an exception instead of returning NO.
2010-05-26 19:54:20 -04:00
Alexander Ljungberg
ef9d2d1775
Reverse update value binding when control editing stops, not only when the action fires. This causes tabbing out of a text field to update the binding source. Based on the description of the bindings option NSContinuouslyUpdatesValueBindingOption this is the right thing to do: if NSContinuouslyUpdatesValueBindingOption is on, update on every character; "otherwise the update is made only when the user interface item resigns as the responder."
2010-05-26 19:51:51 -04:00
Alexander Ljungberg
be13a14330
Hack to make [textField bind:CPValueBinding ...] work. Without this, any observed change leads to a [textField setValue:X forKey:"value"] which in turn leads to a direct ivar access changing the value in textField._value. This means the text field has no idea the value changed and it doesn't update to show the new text. I'm not sure what the right solution should be here. It looks like _replacementKeyPathForBinding should play into this and change the end result to [textField setValue:X forKey:"objectValue"] which would work fine. But currently _replacementKeyPathForBinding applies to the observed key path, not the bound one.
2010-05-26 19:51:28 -04:00
Alexander Ljungberg
45a2bcb71a
Fixed bindings problems where 'nil' would be transformed into @"". Also, CPIsNilTransformerName and its inverse couldn't work because any nil value was immediately returned without transformations being applied. Full complement of unit tests included, based on Cocoa empirical testing.
...
Fixed with CPKeyValueBinding: the CPValueTransformerNameBindingOption option would cause an exception due a missing import.
2010-05-26 19:50:35 -04:00
Alexander Ljungberg
48fb660e66
The problem with initialize in fb5950c82d0124bdebb6e03cb4509306ef4161c8 turned out to be caused by a Cappuccino bug with class methods and arguments named 'name'. Renaming the argument solved the problem so I reverted the initialize change. This fix also fixes valueTransformerForName.
2010-05-26 19:49:49 -04:00
Alexander Ljungberg
218919a8ba
Fixed: exposed bindings on CPObject would not appear in CPObject subclasses.
2010-05-26 19:48:27 -04:00
Alexander Ljungberg
79ed04e403
Fixed: including CPValueTransformer.j causes an infinite loop due to the recent Objective-J (mis?) behavior that every class has to inherit from CPObject. Also, the transformer map failed to initialize properly with the existing setup code for reasons which were not immediately clear. Moving the initialization to a regular + initialize method eliminated the problem.
...
Fixed: CPKeyValueBinding.j would throw an exception if a named value transformer option was specified, due to CPValueTransformer.j not being imported.
2010-05-26 19:47:45 -04:00
Alexander Ljungberg
3c995fe17b
Fixed: the array controller remove method mapped selection indexes to the content array instead of the arranged objects, leading to the wrong objects being removed as filters and sort descriptors were effectively ignored.
2010-05-26 19:45:13 -04:00
Alexander Ljungberg
5ff8ddf5f3
Fewer bindings debug log messages.
2010-05-26 19:44:14 -04:00
Alexander Ljungberg
8b2350fb22
Optimized table data loading when using bindings for the cell values. A special code path in the CPTableColumn's prepareDataView:forRow: method turns a O(n) operation into O(1) where n is the number of items in the model array.
2010-05-26 19:42:59 -04:00
Alexander Ljungberg
15be647c16
Fixed: the CPArrayController code to remove out of bounds selections failed to remove the last selected item if the new arrangedObjects array was empty.
2010-05-26 19:42:40 -04:00
Alexander Ljungberg
8a8af0e4a9
Fixed: CPArrayController could get out of bounds selections if a call to rearrangeObjects caused objects to disappear from the arranged set.
2010-05-26 19:41:34 -04:00
Alexander Ljungberg
4ff89eab04
Fixed: CPArrayController would throw out of bounds exceptions when its content array was shortened and items at the end were selected.
...
Extended avoid empty selection support so that when the last item is selected and deleted, the (previously) second to last item is selected instead. Works as expected with multiple selections.
2010-05-26 19:40:55 -04:00
Alexander Ljungberg
ec032cb739
Performance fix: willChange and didChange for CPArrayController's selectionIndexes were sent doubly.
2010-05-26 19:40:24 -04:00
Alexander Ljungberg
2b287a85e5
CPArrayController now pushes new selections to the bound model for selectionIndexes. Using this, support for selectsInsertedObjects was added.
...
This commit also fixes a performance problem where calling setSelectionIndexes with a selection equal to the one already active caused a selection update.
2010-05-26 19:39:42 -04:00
Alexander Ljungberg
6ea2b4e0e2
Fixed: the CPArrayController addObject: optimization for fast index updates would never fire with a nil _filterPredicate, causing rearrangeObjects to be called needlessly.
2010-05-26 19:39:09 -04:00
Alexander Ljungberg
f7e2e9c2ee
Fixed: the _CPObservableArray init method used by CPArrayController did not properly initialize _observationProxies.
...
Fixed: _CPObservableArray's insertObject:atIndex: caused an infinite loop.
2010-05-26 19:37:28 -04:00
Alexander Ljungberg
5463e5ca55
Fixed: CPArray insertObject:inArraySortedByDescriptors: did not return the index into which the object was inserted. This would have broken CPArrayController's addObject code.
2010-05-26 19:36:26 -04:00
Alexander Ljungberg
396d4218f0
Fixed: CPArrayController keys ContentArray, ArrangedObjects, Selection, SelectionIndex, SelectedObjects, CanRemove and CanSelectNext could not be observed properly because their dependency declarations had a repeated typo.
2010-05-26 19:30:06 -04:00
Alexander Ljungberg
e3a07845d4
Implemented CPTableView clickedRow for use in double-action.
2010-05-26 19:24:36 -04:00
Alexander Ljungberg
341a42bddd
DataSource delegate method tableView:objectValueForTableColumn:row is optional if bindings are used to provide data for the table view.
2010-05-26 19:20:38 -04:00
Alexander Ljungberg
573444e640
Removed a bindings console.log statement incompatible with browsers without a debug console.
2010-05-26 19:14:03 -04:00
Alexander Ljungberg
ed9c6d7959
Added reverse sort tests for CPArray insertObject:inArraySortedByDescriptors:.
2010-05-26 19:11:58 -04:00
Alexander Ljungberg
ed2c65dd6f
Merge branch 'master' of git://github.com/280north/cappuccino into bindings-merge
...
Conflicts:
AppKit/CPTableView.j
Foundation/CPArray+KVO.j
Foundation/CPArray.j
2010-05-26 19:05:04 -04:00
cacaodev and Ross Boucher
0062caafdf
CPObject -implementsSelector:
2010-05-26 10:06:49 -07:00
Stephen Ierodiaconou and Ross Boucher
b98f0b1427
Apply style rules to Foundation
2010-05-26 08:53:05 -07:00
Stephen Ierodiaconou and Ross Boucher
b6a3d2b283
Remove import of deprecated CPLog.j
...
Remove deprecated CPLog.j
2010-05-26 08:52:59 -07:00