Aparajita Fishman and Alexander Ljungberg
be36e17bd8
Make the names in +themeShowcaseExcludes case-insensitive
2010-08-31 22:09:29 -04:00
Blair Duncan and Randall Luecke
b27560c51e
Fix for issue 841 where the edit cursor would not always flash
2010-08-27 19:46:55 -04:00
Aparajita Fishman and Alexander Ljungberg
18696e6bc2
Ensure CPControl -performClick unhighlights the button if the action throws.
2010-08-27 15:58:35 -04:00
Aparajita Fishman and Alexander Ljungberg
4f2914a123
Implementation of CPFont -ascender, -descender and -defaultLineHeightForFont, supporting method +metricsOfFont in CPStringDrawing and CPPlatformString, and Font Metrics Explorer test app.
2010-08-27 14:32:03 -04:00
Aparajita Fishman and Alexander Ljungberg
b823eb7fe0
Fixes for Cocoa compliance
2010-08-27 14:04:28 -04:00
Klaas Pieter Annema
f4e7386a0a
fix gridColor when decoding a CPTableView
...
Don't default to a gray color when there is no grid color in the cib.
The tableview theme will automatically set the correct grid color.
2010-08-26 16:29:46 +02:00
Klaas Pieter Annema
86ee790ea1
implement missing __setSelectionIndex:
2010-08-25 15:57:35 +02:00
Klaas Pieter Annema
c9752195ac
several CPButton theming additions
...
- made image and alternate image a theme property
- made image margins theme-able
2010-08-25 13:26:44 +02:00
Klaas Pieter Annema
64000215a4
Call CPObjectController designated initializer from init and initialize _observedKeys instance variable
2010-08-25 13:15:19 +02:00
Alexander Ljungberg
65d957f9f5
Fixed: an ivar was not being properly initialized in CPAlert.
2010-08-24 14:00:12 -04:00
Alexander Ljungberg
aef19c3b13
Merge branch 'master' of github.com:280north/cappuccino
2010-08-24 12:30:51 -04:00
Alexander Ljungberg
9968896bbd
When running CPAlert as a sheet, automatically activate the CPDocModalWindowMask window style if needed.
2010-08-24 12:14:24 -04:00
Alexander Ljungberg
1a27ae39a3
Removed CPAlert long message test from last commit since this branch already has its own long message test. Also slight clean up.
2010-08-24 11:58:36 -04:00
cacaodev and Alexander Ljungberg
ee4802e513
CPAlert: Attached alerts. Added a new method -beginSheetModalForWindow: that calls -alertDidEnd:returnCode: on ending. CPAlertTest update testing it.
...
Fixed a bug in CPWindow where the didEndSelector was reset too early. This bug was visible only when trying to chain sheet alerts.
Fixed a local/instance variable conflict in AttachedSheet/AppController.j
2010-08-24 11:50:44 -04:00
Klaas Pieter Annema
60dd1863b3
Implement objectsAtIndexes on _CPObservableArray to return another _CPObservableArray instance
2010-08-24 11:41:52 +02:00
Klaas Pieter Annema
71408e7c3a
made CPObjectController call it's designated initializer (init)
2010-08-24 11:41:51 +02:00
Alexander Ljungberg
febdf4092e
New implementation of change notifications from CPArrayController.
...
It is crucial that we send notification only before and after complete changes. In the middle notifications might cause observers to see or react to inconsistent data (e.g. selection indexes pointing to rows no longer present). Added some unit tests - more might be needed in the future. Fixed: before and after values when observing array controller key paths during content changes or rearranges were wrong. Fixed: the array controller sent out multiple redundant change notifications.
2010-08-23 18:53:29 -04:00
Alexander Ljungberg
a3d89c8d78
Ignore table view row selection of already selected rows. This avoids potential infinite recursion caused by the explicit bindings propagation.
2010-08-23 18:51:00 -04:00
Alexander Ljungberg
b9086f134a
Don't include table column header graphics in the showcase - they're not really widgets which make sense standing alone.
2010-08-22 23:03:51 -04:00
Alexander Ljungberg
447c33b806
Don't layout CPAlert in layoutSubviews since it's not a real view. This avoids the theme showcase error where the CPAlert windowing code was activated by the theme descriptor setup.
2010-08-22 23:01:52 -04:00
Aparajita Fishman and Alexander Ljungberg
ae47ba78cd
Use [self respondsToSelector] instead of class_respondsToSelector
2010-08-22 22:06:38 -04:00
Aparajita Fishman and Alexander Ljungberg
2f51358ea0
Added documentation for the excluded mechanism.
2010-08-22 22:06:31 -04:00
Aparajita Fishman and Alexander Ljungberg
c91c513b60
Proposed method of excluding themed objects from the theme showcase.
...
- Also added class_respondsToSelector, it was a no-brainer.
- Cleaned up trailing whitespace in CPThemeBlend.j. Woo-hoo!
2010-08-22 22:06:22 -04:00
Aparajita Fishman and Alexander Ljungberg
189d90da91
Moved theWindow to an ivar so other methods can reference it.
2010-08-22 19:03:15 -04:00
Aparajita Fishman and Alexander Ljungberg
05edec8a8b
Removed CPButton -setDefaultButton, new version of CPButton after merging with latest master.
2010-08-22 18:53:52 -04:00
Alexander Ljungberg
a9e59e1e87
Fixed: in the new theme definition the table header sort images were no longer images. This would cause an exception whenever a table header was clicked such that the sort arrows needed to display.
2010-08-22 17:47:52 -04:00
Alexander Ljungberg
e766a2c945
Fixed: if a CPAlert message was 3 lines or more and there was no informative text, the upper half of the CPAlert buttons would not react to clicks as the blank informative label partially covered them.
2010-08-21 17:47:03 -04:00
Alexander Ljungberg
fbd5a78cf0
Don't make space for CPAlert informative text if there is none. Consider the theme size a minimum size.
2010-08-20 12:41:20 -04:00
Alexander Ljungberg
f39c1a2eb8
Try to help the build bot by not calling CPAlert setWindowStyle: in init.
2010-08-20 03:01:37 -04:00
Alexander Ljungberg
5335a611a0
Use Aristo icons for CPAlert.
2010-08-20 01:55:45 -04:00
Alexander Ljungberg
c06068c931
Themable CPAlert which automatically grows height-wise to accommodate all text. Adjustable icons, margins, spacing and fonts.
2010-08-19 23:03:35 -04:00
Alexander Ljungberg
62f81f2601
Remove hardcoded Aristo theme from CPAlert. New CPTheme method to get the default HUD theme style, which defaults to the default theme + "-HUD". Clean up CPAlert slightly.
2010-08-19 19:11:52 -04:00
Alexander Ljungberg
d56bc733ad
Remove some accidental globals.
2010-08-18 22:01:18 -04:00
Alexander Ljungberg
8fbd24c861
Moved file globals to the top of the file. Removed a misplaced var. Eliminated empty statements.
2010-08-18 21:32:51 -04:00
Alexander Ljungberg
98049aeb78
Whitespace cleanup.
2010-08-18 17:02:22 -04:00
Aparajita Fishman and Alexander Ljungberg
c9718783af
Made the new theming mechanism generic (see ecbbe57)
2010-08-18 16:45:45 -04:00
Aparajita Fishman and Alexander Ljungberg
bfe01badc1
Radically simplified the whole theming mechanism. Theming can now be done declaratively with less typing, better readability, easier maintenance.
...
Also fixed some oversights in the existing themes: text was not dimmed in disabled state for segmented controls, text was not dimmed for default buttons in disabled state in HUD (IIRC).
2010-08-18 16:45:38 -04:00
Randall Luecke
d7540eea84
if the new proposed selection is empty the tableview should not deselect any rows.
2010-08-17 00:01:33 -05:00
Randall Luecke
88408fc0ea
Missed a couple lines in tableview custom drawing because of a merge conflict.
2010-08-16 15:10:29 -05:00
Randall Luecke
6e796d7a22
Fix for endless loop with default buttons.
2010-08-16 15:05:46 -05:00
Randall Luecke
f587713795
This was terrible, real fix soon...Revert "Fix for endless loop when changing platform windows."
...
This reverts commit 66fcba846b
2010-08-16 14:55:44 -05:00
Randall Luecke
66fcba846b
Fix for endless loop when changing platform windows.
2010-08-16 01:26:48 -05:00
Alexander Ljungberg
112ad65882
Support value transformers in CPTableColumn when using bindings.
2010-08-13 20:19:35 -04:00
Alexander Ljungberg
4c0057e66a
Undoing this change since it is no longer necessary due to an alternative solution implemented by Ross Boucher. Revert "Merge commit 'c17a3533ecae63d479b285b23ac3a490ebe8bd3c'"
...
This reverts commit 039f2ce449494f39dd86
2010-08-13 14:39:27 -04:00
Alexander Ljungberg
61ccc39f81
Merge remote branch 'klaaspieter/fix/794-cparraycontroller-preserveselection'
...
Conflicts:
Tests/AppKit/CPArrayControllerTest.j
2010-08-13 14:06:35 -04:00
Alexander Ljungberg
533e1a1846
Merge remote branch 'klaaspieter/fix/786-cparraycontroller-removeobject'
2010-08-13 14:01:47 -04:00
Alexander Ljungberg
6afe22f351
Merge remote branch 'klaaspieter/fix/784-cparraycontroller-selection'
2010-08-13 14:00:27 -04:00
Alexander Ljungberg
039f2ce449
Merge commit 'c17a3533ecae63d479b285b23ac3a490ebe8bd3c'
2010-08-13 13:56:21 -04:00
Alexander Ljungberg
494f39dd86
Closes #752 . Removed some debug code which snuck in with the merge of fix-752-CPValueTransformerNameBindingOption.
2010-08-12 23:37:53 -04:00
Alexander Ljungberg
c851522536
Fixed: if the CPWebView iframe was destroyed before its HTML loader timer fired, an error would occur.
2010-08-12 23:36:25 -04:00
