Alexandre Wilhelm and GitHub
c094420428
Merge pull request #2810 from bedalton/fixed-cpscroller-return-style
...
Fixed: Change CPScroller's style method return type to int
2019-03-29 15:01:13 -07:00
Alexandre Wilhelm and GitHub
e948064063
Merge pull request #2809 from bedalton/fixed-cocolor-parameter-to-cpstring
...
Fixed: Changed CPColor parameter to CPString
2019-03-29 15:00:59 -07:00
Alexandre Wilhelm and GitHub
bdd3b7d2a5
Merge pull request #2808 from bedalton/fixed-cpbrowserdelegate-duplicate-method
...
Fixed: CPBrowserDelegate duplicate protocol method
2019-03-29 15:00:46 -07:00
Alexandre Wilhelm and GitHub
404c37b54c
Merge pull request #2800 from bedalton/fixed-mismatched-parameters-in-CPTextView
...
Fixed: mismatched parameters in CPTextView
2019-03-29 15:00:18 -07:00
Alexandre Wilhelm and GitHub
ac686a17fa
Merge pull request #2799 from bedalton/fixed-mispelled-parameter-in-CPTextView
...
Fixed: Misspelled parameter in CPTextView.j
2019-03-29 14:59:55 -07:00
Alexandre Wilhelm and GitHub
bfc5068b5e
Merge pull request #2796 from bedalton/formatting-remove-redundant-semi-colon-CPDatePicker
...
Formatting: Remove redundant semi-colon form CPDatePicker
2019-03-29 14:59:39 -07:00
Alexandre Wilhelm and GitHub
649bee2330
Merge pull request #2806 from bedalton/fixed-cpbezier-path-nsinteger
...
Fixed: CPBezierPath using parameter type NSInteger
2019-03-29 14:59:18 -07:00
Alexandre Wilhelm and GitHub
593587ea60
Merge pull request #2805 from bedalton/fixed-cpapplication-isactive-return-type
...
Fixed: CPApplication's isActive method return type
2019-03-29 14:59:02 -07:00
Alexandre Wilhelm and GitHub
0ab81a7b32
Merge pull request #2804 from bedalton/fixed-_cpautocompletemenu-return-type
...
Fixed: Changed void return to id in CPAutocompleteMenu.j
2019-03-29 14:58:50 -07:00
Alexandre Wilhelm and GitHub
8bf937357c
Merge pull request #2801 from bedalton/formatting-remove-semi-colon-_CPStandardWindowView
...
Formatting: Remove extraneous semi-colon _CPStandardWindowView.j
2019-03-29 14:58:16 -07:00
daniel
ca5cd8e09b
Fixed: CPScroller's style method should have returned int
...
Despite returning an int and a comment stating it returns a value, CPScroller's style method had a return type of void.
2019-03-28 14:51:15 -07:00
daniel
34ac4cd23b
Fixed: Changed CPColor parameter from string to CPString
...
Parameter type in CPColor was string, changed here to CPString, to make it more inline with other string parameter types.
2019-03-28 14:33:00 -07:00
daniel
8598fe8ad9
Revert "Fixed: Changed CPColor parameter type from string to CPString"
...
This reverts commit 06498672ab .
2019-03-28 14:32:00 -07:00
daniel
3699a31f28
Revert "Formatting: Removed extra semi-colon ThemeDescriptors.j"
...
This reverts commit 75cd5a75e1 .
2019-03-28 14:31:17 -07:00
daniel
06498672ab
Fixed: Changed CPColor parameter type from string to CPString
...
Parameter type in CPColor was string, changed here to CPString, to make it more inline with other string parameter types.
2019-03-28 14:29:50 -07:00
daniel
cd3b92af7a
Fixed:CPBrowserDelegate duplicate method
...
Method browser:imageValueForItem was defined twice in CPBrowserDelegate. Once on line 43, and the other on line 45. This removes the commit removed the second declaration
2019-03-28 14:26:08 -07:00
daniel
e15cc29e2f
Fixed: CPBezierPath used parameter types NSInteger
...
CPBezierPath has parameter type NSInteger. Assumed meant to be CPInteger
2019-03-28 14:19:09 -07:00
daniel
c59e7cc456
Fixed: Changed CPApplication's isActive method return type to BOOL
...
Method has declared return type of void, despite the method returning a BOOL, and the name implying that it returns a BOOL
2019-03-28 14:08:00 -07:00
daniel
3c16bfef58
Fixed: Changed void return type to id in _CPAutocompleteMenu.j
...
tableView:objectValueForTableColumn:row: has return type set to void, despite returning an method call returning id. Similar methods also return id.
2019-03-28 14:01:31 -07:00
daniel
ec24977d4e
Revert "Fixed: changed void return type in _CPAutocompleMenu.j to id"
...
This reverts commit 10b4f57a0e .
2019-03-28 13:58:15 -07:00
daniel
10b4f57a0e
Fixed: changed void return type in _CPAutocompleMenu.j to id
...
tableView:objectValueForTableColumn:row: has return type set to void, despite returning an method call returning id. Similar methods also return id.
2019-03-28 13:54:20 -07:00
daniel
75cd5a75e1
Formatting: Removed extra semi-colon ThemeDescriptors.j
2019-03-28 13:46:25 -07:00
daniel
49ef1276f6
Formatting: Removed extra semi-colon in _CPStandardWindowView.j
2019-03-28 13:32:56 -07:00
daniel
828788b643
Fixed: Mismatched parameter types in CPTextView
...
isBlinking had return type void, but returned a BOOL, and the method name implies that it returns a BOOL.
Some parameters were marked as integer, so were changed to int to coincide with most other names for integers.
setString had parameter type id, despite implying that parameter was a string, and the super class parameter being a string.
2019-03-28 13:21:34 -07:00
daniel
0ca8d7a258
Fixed: Mispelled DOMElement parameter in CPTextView.j
2019-03-28 13:12:30 -07:00
daniel
d39e1c0c6e
Fixed: Return type for font method should have been CPFont
2019-03-28 12:51:04 -07:00
daniel
8e7f201ca8
Formatting: Removed redundant semi-colon in CPDatePicker
2019-03-28 12:49:13 -07:00
Alexandre Wilhelm and GitHub
0be913ab18
Merge pull request #2780 from daboe01/fixed-wrong-return-type-in-_CPCibClassSwapper
...
fixed: wrong return type in initializer of _CPCibClassSwapper
2019-02-06 16:58:44 -08:00
Alexandre Wilhelm and GitHub
bab30f3b61
Merge pull request #2781 from daboe01/fixed-wrong-return-type-in-shouldArchiveValueForKey-
...
fixed: wrong return type in shouldArchiveValueForKey:
2019-02-06 16:58:25 -08:00
Alexandre Wilhelm and GitHub
abb599c556
Merge pull request #2782 from daboe01/fixed-wrong-return-type-of-_menuWithName-
...
fixed: wrong return type of _menuWithName:
2019-02-06 16:57:59 -08:00
Alexandre Wilhelm and GitHub
2b6c6e9ab3
Merge pull request #2783 from daboe01/fixed-wrong-return-type-of-backgroundColorForGlyphAtIndex-
...
fixed: wrong return type of backgroundColorForGlyphAtIndex:
2019-02-06 16:57:42 -08:00
Alexandre Wilhelm and GitHub
0db0d744da
Merge pull request #2784 from daboe01/fixed-wrong-return-type-in-isMovable
...
fixed: wrong return type in isMovable
2019-02-06 16:57:21 -08:00
daboe01
ae50fde4e1
fixed: wrong return type of isMiniaturized
2018-10-14 16:49:49 +02:00
daboe01
401461f1f0
fixed: wrong return type in isMovable
2018-10-14 13:36:53 +02:00
daboe01
676c6e106d
fixed: wrong return type of backgroundColorForGlyphAtIndex:
2018-10-14 13:34:33 +02:00
daboe01
d0a066ccd3
fixed: wrong return type of _menuWithName:
2018-10-14 13:31:20 +02:00
daboe01
340e286277
fixed: wrong return type in shouldArchiveValueForKey:
2018-10-14 13:27:38 +02:00
daboe01
9211d41984
fixed: wrong return type in initializer of _CPCibClassSwapper
2018-10-14 13:24:03 +02:00
Alexander Ljungberg
2e0b9f5ea5
New: tweak flash view warning.
2018-09-07 23:16:31 +01:00
Didier Korthoudt and Martin Carlberg
8a3eb0d83b
FIXED: This PR fixes a side effect of #2744 on table data views ( #2767 )
...
When a textField is used in a tableView, setValue forThemeAttribute
should refer to state CPThemeStateTableDataView instead of
CPThemeStateNormal as #2744 is now more accurate on states.
2018-08-31 09:14:54 +02:00
Didier Korthoudt and Martin Carlberg
dd68b37a2a
Fixed: CPButtonBar with actionPopupButton was outside the visible rect. Fixes #2770 ( #2771 )
2018-08-31 09:10:44 +02:00
cacaodev
96793b39ba
Revert "Fixed: Define header-view-height attribute in ThemeDescriptors. ( #2764 )"
...
This reverts commit 9ad44e6dc2 .
2018-08-30 16:02:48 +02:00
cacaodev and Martin Carlberg
9ad44e6dc2
Fixed: Define header-view-height attribute in ThemeDescriptors. ( #2764 )
...
This is a better solution for problem introduced by #2758
2018-08-29 14:28:02 +02:00
Didier Korthoudt and Martin Carlberg
988b3d27b8
Fixed: allowFadingOut side effect introduced by #2718 ( #2768 )
2018-08-29 11:27:50 +02:00
Didier Korthoudt and cacaodev
ff6d17990f
FIXED: Before this PR, starting a column drag within a scrolled down table would scroll the table content to the bottom ( #2753 )
...
Before this commit, in the method [view convertPoint:aPoint toView:aView] : aPoint was not in the coordinate system of view.
2018-08-21 19:26:42 +02:00
Didier Korthoudt and Martin Carlberg
73f02cc1bf
NEW: Add first responder management based on content view to CPScrollView ( #2757 )
2018-08-21 09:14:21 +02:00
Didier Korthoudt and Martin Carlberg
eb27d24923
Fixed: CPTableView-visual-problem( #2755 )
2018-08-21 09:08:16 +02:00
Didier Korthoudt and Martin Carlberg
eeb056d509
Fixed: CPCursor-fix-and-update, some cursors were badly or not displayed ( #2752 )
2018-08-20 13:35:18 +02:00
Didier Korthoudt and Martin Carlberg
3615912ce0
Fixed: Before this PR, loading of a CPTabView from a CIB file could crash the app ( #2686 )
2018-08-20 13:30:02 +02:00
Didier Korthoudt and Martin Carlberg
4518dfc0ca
FIXED: CPSearchField was positionning its menu with hard coded offset ( #2691 )
2018-08-20 13:12:22 +02:00