Aparajita Fishman
4f377bcebe
Objj2 compiler fixes
...
Compiled all files individually:
- Added missing imports.
- Added @class/@global declarations to break circular dependencies.
- Misc. code cleanup.
Conflicts:
AppKit/CPWindow/_CPWindow.j
AppKit/Platform/DOM/CPPlatformWindow+DOM.j
2013-01-23 15:48:55 +07:00
Martin Carlberg
458fa9d02e
Fixed a lot of small bugs found by new warning message from compiler
2013-01-18 14:24:37 +01:00
Aparajita Fishman
cae5486ec6
Added missing class checks in +initialize, regularized checking code
2012-06-28 12:05:18 -07:00
Aparajita Fishman
36bfc7c675
Fixed decode methods to return the correct defaults, removed unnecessary containsValueForKey and || with defaults
2012-04-24 10:15:19 +02:00
Alexander Ljungberg
21a34f88b2
Fixed: don't crash when removing objects from an array controller which has its arrangedObjects.@count observed.
2012-04-20 15:12:59 +01:00
Alexander Ljungberg
0736f86f32
Fixed: "[CPString count] unrecognized selector" error when binding an array controller's content array to a key of another AC's selection.
...
This change also avoids wrapping a selection proxy in a KVO array proxy, which isn't helpful and probably hurts performance.
2012-03-07 16:49:41 +00:00
cacaodev
d44df8a9da
CPControllerSelectionProxy: accidental globals.
2012-02-02 10:50:26 +01:00
Alexander Ljungberg
cb2f539cf7
Send didChange in reverse order of willChange in CPObjectController setContent:.
2011-09-07 17:32:19 +01:00
Alexander Ljungberg
485e59b5eb
More handlesContentAsCompoundValue, although fairly guess-work based. More research needed in the future.
2011-06-06 00:11:04 -04:00
Alexander Ljungberg
79ec12e2a2
Added support for the CPNullPlaceholderBindingOption for bound text fields.
2011-03-28 18:02:52 -04:00
Alexander Ljungberg
7b3ae56031
CPObjectController automaticallyPreparesContent support.
2011-03-28 11:06:12 -04:00
Alexander Ljungberg
65043c5d78
Added some missing LGPL headers.
2011-03-25 22:52:57 -04:00
Stephen Ierodiaconou
6a942630e4
Fixing spelling mistakes
2011-01-24 11:05:48 +02:00
Randall Luecke
1dc10440b7
Documentaion of CPObjectController.
2011-01-13 00:57:07 -05:00
Klaas Pieter Annema
3d5232b308
give objects a chance to change their binder class
...
- make every object calling getBinding:forObject: aware of this change
- implement _CPCheckBoxValueBinder to handle binding to the value of a checkbox Closes : #1083
- re-implement CPTextField's behavior for controller markers using the new binder class
- disabled some tests that are not compliant with Cocoa
2011-01-07 14:14:19 +01:00
Francisco Ryan Tolmasky I
b3e0c4a5d5
Added a FIXME.
...
Reviewed by me.
2010-12-27 03:05:20 -08:00
Francisco Ryan Tolmasky I
f79c2346a5
More test fixes.
...
Reviewed by me.
2010-12-25 17:05:31 -08:00
Francisco Ryan Tolmasky I
e964c60830
Fix a few failing tests, and a bad import.
...
Reviewed by me.
2010-12-25 16:58:09 -08:00
Francisco Ryan Tolmasky I
37931f08b5
First pass at CPArray class cluster.
...
Reviewed by me.
2010-12-25 16:07:30 -08:00
Alexander Ljungberg
53f4baa9ac
Fixed: CPArrayController add: and insert: would fail if automaticallyPreparesContent was NO.
...
This was caused by an unimplemented method in the original adapted from Cocotron CPObjectController.
2010-12-14 20:44:22 +01:00
Klaas Pieter Annema
8345788e59
disable value caching in CPControllerSelectionProxy
...
More information here http://groups.google.com/group/objectivej-dev/browse_thread/thread/c100f16095073332 .
2010-11-24 14:27:59 +01:00
Klaas Pieter Annema
21c2b8f74a
trigger notification for correct key path in _CPObservationProxy
...
Previously _CPObservationProxy would only trigger notifications for the key path it was created with. For example a notification for department would be forwarded to the controller and observer as a notification on department.name because that was the key path the observation proxy was created for.
2010-11-24 14:21:19 +01:00
Klaas Pieter Annema
34339fbcd9
several bindings / KVC fixes
...
- setValue:forKeyPath will now get call setValue:forKeyPath again on the value of the first part of the key path
- override valueForKeyPath: and valueForKey: in CPObjectController's CPControllerSelectionProxy to return controller markers when appropriate
- override setValue:forKeyPath: and setValue:forKey: in CPObjectController's CPControllerSelectionProxy to bypass possible controller markers
This commit also removes previous hacks for compound paths and adds test cases for the errors. All this is related to issue #967 .
2010-11-23 14:18:22 +01:00
Klaas Pieter Annema
b49dc87a86
Merge branch 'fix-967'
2010-11-23 12:16:57 +01:00
Klaas Pieter Annema
535d6c9dc5
make setValue:forKey: handle controller markers
2010-11-23 12:15:53 +01:00
Klaas Pieter Annema
1e85a054ac
better fix for long key paths
...
The previous fix for issue #967 would only work if there was only one object observing a compound key path like selection.customer.name.
2010-11-22 19:13:20 +01:00
Klaas Pieter Annema
ca60e50128
small bindings fix in CPObjectController
...
CPObjectController would attempt to remove observations from the new selection in stead of the old selection. This would throw an error when binding to longer compound key paths like selection.customer.name
Fixes #967
2010-11-22 18:10:34 +01:00
Klaas Pieter Annema
70c13a7588
style cleanup in CPObjectController
2010-11-22 18:10:28 +01:00
Ross Boucher
45f74386b8
Add bindings support to nib2cib
2010-11-18 15:52:54 -08:00
Brian Donovan and Francisco Ryan Tolmasky I
7bf2297125
-[CPArrayController setContent:] would interpret nil as [nil].
...
When initializing a CPArrayController with a value that is not an array setContent: would make it an array by replacing value with [value]. This is consistent with how Cocoa does it, but it should first check to make sure that the content is not nil. If it is, the sensible thing to do (and what Cocoa does) is to replace it with an empty array.
This commit also includes a missing import to make CPArrayControllerTest run without error.
2010-11-03 01:24:38 -07:00
Paul Baumgart and Ross Boucher
98393c66fc
change a 'self' to a 'super' to fix infinite recursion
2010-10-13 18:41:59 -07:00
Klaas Pieter Annema
64000215a4
Call CPObjectController designated initializer from init and initialize _observedKeys instance variable
2010-08-25 13:15:19 +02:00
Klaas Pieter Annema
60dd1863b3
Implement objectsAtIndexes on _CPObservableArray to return another _CPObservableArray instance
2010-08-24 11:41:52 +02:00
Klaas Pieter Annema
71408e7c3a
made CPObjectController call it's designated initializer (init)
2010-08-24 11:41:51 +02:00
Klaas Pieter Annema
acf5e5b75f
call super in _CPObservableArray removeObjectAtIndex:
...
The current implementation calls self, which causes an infinite loop
2010-07-26 18:44:50 +02:00
Ross Boucher
7c3f94dd87
Merge remote branch 'klaaspieter/bindings-fixes' into bindings
...
Conflicts:
AppKit/CPControl.j
Foundation/CPValueTransformer.j
2010-05-28 10:23:47 -07:00
Klaas Pieter Annema
eacd408ce8
Fixed a typo in CPObjectController
2010-05-27 15:23:09 +02:00
Alexander Ljungberg
e811895570
Fixed: CPObjectController keyPathsForValuesAffectingX typos.
2010-05-26 20:06:32 -04:00
Alexander Ljungberg
f7e2e9c2ee
Fixed: the _CPObservableArray init method used by CPArrayController did not properly initialize _observationProxies.
...
Fixed: _CPObservableArray's insertObject:atIndex: caused an infinite loop.
2010-05-26 19:37:28 -04:00
Ross Boucher
3635d0ec26
Bindings Checkpoint.
2009-09-21 13:27:50 -07:00
Francisco Ryan Tolmasky I
08ed16c493
Made CPObjectController's contentObject binding bidirectional.
...
Reviewed by me.
2009-07-22 23:54:38 -07:00
Ross Boucher
9bbe51fa64
CPArrayController works simply with bindings and arrangedObjects
2009-02-19 01:29:39 -08:00
Ross Boucher
c028425f14
More bindings fixes.
2009-02-09 17:35:25 -08:00
Ross Boucher
1b8aca26a3
In progress work on bindings.
2009-02-07 12:55:15 -07:00