daboe01
fe6a576d84
add special close button for inactive windows
2014-08-31 21:16:36 +02:00
daboe01
d4f2d99a6b
Fixed: typo in scrollRectToVisible: documentation
2014-08-31 13:48:34 +02:00
Antoine Mercadal
cb390325a6
Merge pull request #2170 from t00f/themeable-rule-editor
...
ControlSize management and CPRuleEditor/CPPredicateEditor alignments
2014-08-29 10:11:05 -07:00
Alexandre Wilhelm
de495aa1c5
Fixed: _removeObservers called in orderFront, we don't need this as addObservers and removeObservers work with boolean to check if the observers are set or not
2014-08-28 22:28:41 -07:00
Alexandre Wilhelm
aa4a4b07d8
Fixed: method viewWillMoveToWindow and viewDidMoveToWindow not called when when adding a view to a view without a window where the previous superview had a window
2014-08-28 22:22:50 -07:00
Antoine Mercadal
b92214461e
FIXED: Some tooltips was truncated
...
This patch adds a small size adjustment when we compute the size of the
tooltip. It seems to fix all truncated tooltips problem.
2014-08-28 19:02:22 -07:00
Antoine Mercadal
3f4ba87079
FIXED: Tooltip content alignement was mistakely set to be justified
...
This patch ensure the tooltip content is left aligned correctly
2014-08-28 18:30:55 -07:00
Antoine Mercadal
f1cfa14750
FIXED: buttons in CPButtonBar were never removed from the CPButtonBar
...
Previsouly, layoutSubview was layouting the visible buttons, but it was not removing them from
the buttonbar
2014-08-28 17:26:22 -07:00
Christophe Serafin
3dbce0e800
move DOMElement.style.backgroundSize to CPDomDisplayServerSetStyleBackgroundSize equivalent method
2014-08-22 10:09:09 -07:00
Christophe Serafin
efca50c6ac
fix style
2014-08-22 10:07:29 -07:00
Antoine Mercadal
3cf013b25b
Merge pull request #2178 from Dogild/CPOUtlineView-fix-reuseItem
...
Fixed: crash of the CPOutlineView when reloading and changing an item to another parent
2014-08-21 10:42:58 -07:00
Alexandre Wilhelm
92a5fa19fb
Fixed: crash of the CPOutlineView when reloading and changing an item to another parent
...
Previously, when reloading the CPOutlineView and changing an item to another parentItem, the CPOutlineView deleted the reference of the item.
Now, when removing old data to avoid memory leaks, the CPOutlineView checks if the pending item to delete doesn't have another parent item.
2014-08-20 18:32:20 -07:00
Alexandre Wilhelm
1fcf13d149
Fixed: added optimization for releasing observers
2014-08-20 16:13:59 -07:00
Alexandre Wilhelm
bd20050db8
Fixed: added a boolean to avoid to addObservers seveal times
2014-08-20 15:23:10 -07:00
Alexandre Wilhelm
ce0233d0a2
Fixed: revert commit abdf1156d4 for CPComboBox
2014-08-20 15:11:21 -07:00
daboe01
ce777348b3
cursor up/down+ frames protection
2014-08-20 23:09:53 +02:00
daboe01
c052325487
various fixes and cleanup
2014-08-20 22:39:15 +02:00
Alexandre Wilhelm
0479e9b3f3
Fixed: make sure to remove observers when opening a CPWindow
2014-08-19 17:52:24 -07:00
Alexandre Wilhelm
abdf1156d4
Fixed: memory leaks with CPNotifications
...
Previously, when removing a view, Cappuccino didn't clean the notification center. The notification center kept in reference old views.
This PR fix this issue. When a CPView is added to a view, the methods _removeObservers and _addObservers are called. In these both methods we remove and add the observer to the notification center if needed. _removeObservers and _addObservers are called for the view and its subviews. These both methods are called through the method viewWillMoveToSuperview.
When a CPView is removed, we only call the method _removeObservers.
When a CPWindow is closed, we call the method _removeObservers on its contentView.
When a CPWindow is about to be opened, we call the method _removeObservers and _addObservers on its contentView.
Refs #1880
Refs #2024
Test app in Tests/Manual/AttachedSheet2/SheetWindowController.j
2014-08-19 17:45:01 -07:00
Alexandre Wilhelm
9ed30f563a
Fixed: Methods viewDidMoveToSuperview viewDidMoveToWindow viewWillMoveToSuperview viewWillMoveToWindow not called as in Cocoa
...
Previously, when adding, removing, replacing a CPView, the framework didn't call the methods viewDidMoveToSuperview, viewDidMoveToWindow, viewWillMoveToSuperview and viewWillMoveToWindow as in Cocoa. Now it does.
The main change is that these methods will be called when removing a CPView.
Added unit-test in Tests/AppKit/CPViewTest.j
2014-08-19 14:26:26 -07:00
Christophe Serafin
5484bbf8bf
fix Aristo and Aristo2 alignments
2014-08-18 13:08:47 -07:00
Christophe Serafin
62e8d70d74
fix _adjustNib2CibSize calls
2014-08-18 13:08:09 -07:00
Alexandre Wilhelm
b2f1477b45
Fixed: wrong condition in CPApplication
2014-08-15 16:37:03 -07:00
Christophe Serafin
7323a5e393
fix disappearing buttons
2014-08-15 09:04:26 -07:00
Christophe Serafin
f8205cc376
realign Aristo2 buttons for fix 6f9210
2014-08-15 08:20:46 -07:00
Antoine Mercadal
4828f7478e
Merge branch 'master' into themeable-rule-editor
2014-08-14 21:05:58 -07:00
Antoine Mercadal
775141b7f7
Merge branch 'themeable-rule-editor' of https://github.com/t00f/cappuccino into themeable-rule-editor
2014-08-14 21:03:45 -07:00
Christophe Serafin
4b639843ec
fixed buttons positions and extended Nib2CibAlignment test
2014-08-14 18:18:08 -07:00
Christophe Serafin
464389a862
update nib2cib-adjustment-frame to match Nib2CibAlignment Test. Except for button in small and mini sizes
2014-08-14 14:17:57 -07:00
Alexandre Wilhelm
48b3eb259d
Fixed: delegate popover did show not called with a none animate CPPopover
...
Previously, the delegate popoverDidShow wasn't called with an none animated CPPopover.
2014-08-14 14:10:37 -07:00
daboe01
4cebfbcd13
removed collectionViewDidChangeSelection
2014-08-14 22:57:05 +02:00
daboe01
1767cf8ad4
formatting+nil equality
2014-08-14 22:41:59 +02:00
daboe01
b1981bb70c
fix activateIgnoringOtherApps:shouldIgnoreOthe...
2014-08-14 22:27:46 +02:00
Christophe Serafin
3dc581efbb
introduce nib2cib-adjustment-frame as theme attribute to enbable proper control alignment
2014-08-14 10:54:38 -07:00
Christophe Serafin
655cc3256c
remove arbitrary CONTROL_HEIGHT
2014-08-14 10:45:12 -07:00
daboe01
ce69410f49
revert of breaking change wrt backspace
2014-08-14 18:21:53 +02:00
daboe01
5f0be0cc7f
make storage length zero more tolerant
2014-08-14 14:14:49 +02:00
Andrew Hankinson
dca6347ea9
Fixed: Remove lingering references to i
...
Refs 75e347e8e3
2014-08-14 07:19:53 -04:00
daboe01
94c4db9072
fixed equality operator
2014-08-14 07:17:00 +02:00
Andrew Hankinson
7f63be2cd2
Formatting: Make if statement more readable
...
The if statement had a lot of sub-clauses. These were factored out into variable assignments.
2014-08-13 19:56:50 -04:00
Andrew Hankinson
1236dea4c5
Fixed: equality operators
2014-08-13 19:47:06 -04:00
Andrew Hankinson
c5c46df613
Fixed: typo
2014-08-13 19:44:23 -04:00
Andrew Hankinson
a96269150a
Fixed: AppKit.j is alphabetized
...
CPTextView.j was out of alphabetical order. This commit fixes that.
2014-08-13 19:34:56 -04:00
Andrew Hankinson
75e347e8e3
Fixed: obscure use of variables
...
Previously, the counting variable "i" was used as a variable throughout this method, leading to the value of 'i' becoming unclear as the method progressed.
Additionally, a later loop in this method redeclared 'i', providing more confusion.
This commit renames 'i' to the more descriptive 'targetLine' and uses that in its place. The redeclared value of 'i' was also renamed to "newTargetLine".
2014-08-13 18:15:58 -04:00
daboe01
d641cc5057
fix fussy optimization
2014-08-14 00:12:02 +02:00
Christophe Serafin
bf5b660cb5
fix background size with 1-part image
2014-08-12 17:26:43 -07:00
Christophe Serafin
712dc493ca
remove CPDateFormater dependancy and CPString convertion
2014-08-12 15:42:03 -07:00
Christophe Serafin
f4fba64ffb
remove test on sendAction
2014-08-12 14:06:37 -07:00
Christophe Serafin
e3ad115698
correction based on primalmotion comments
2014-08-12 13:56:25 -07:00
Christophe Serafin
c078bb04b2
Correction and optimizations based on Alex comments. Fix for CPDatePickerTest
2014-08-12 13:31:22 -07:00
daboe01
Antoine Mercadal
Alexandre Wilhelm
Christophe Serafin
Andrew Hankinson