daboe01 and Martin Carlberg
eb55e4def6
Fixed: keyboard issues from FF66 alignmets to the other major browsers ( #2847 )
2019-05-24 12:57:57 +02:00
Alexandre Wilhelm and GitHub
acda834ad9
Merge pull request #2819 from daboe01/CPFontManager-duplicate-methods-removal
...
fixed: removed outdated duplicate method definitions in CPFontManager.j
2019-04-14 20:02:22 -07:00
Alexandre Wilhelm and GitHub
aba3e30d9c
Merge pull request #2824 from daboe01/cpdocumentcontroller-return-type-fix
...
fixed: return type of openUntitledDocumentOfType:display:
2019-04-14 20:01:36 -07:00
daboe01
26cbe17218
fixed: wrong return type of textField method in
2019-04-08 14:39:02 +02:00
daboe01
fc8f1dca4e
fixed: return type of openUntitledDocumentOfType:display:
2019-04-08 14:32:06 +02:00
Alexandre Wilhelm and GitHub
6b20a4f8f7
Merge pull request #2786 from didierkorthoudt/CPStepper-enabled-from-IB
...
FIXED: CPStepper was not receiving the enabled status from IB
2019-04-03 15:15:22 -07:00
Alexandre Wilhelm and GitHub
1180789c0c
Merge pull request #2823 from daboe01/CPBrowserDelegateMethodFix
...
fixed: CPBrowserDelegate_browser_imageValueForItem_ was defined twice
2019-04-03 14:37:33 -07:00
Alexandre Wilhelm and GitHub
ac056d4a06
Merge pull request #2822 from daboe01/cpcursor-fix
...
fixed: accidental creation of a global variable in CPCursor.j
2019-04-03 14:36:44 -07:00
daboe01
c612b13529
fixed: CPBrowserDelegate_browser_imageValueForItem_ was defined twice
2019-03-31 19:42:54 +02:00
daboe01
5f4c79f6c4
fixed: accidental creation of a global variable
2019-03-31 17:44:07 +02:00
daboe01
302cbf641e
fixed: typo in initWithGraphicsPort: declaration
2019-03-31 17:37:44 +02:00
daboe01
4bc2e9ad44
fixed: removed outdated duplicate method definitions in CPFontManager.j
2019-03-31 17:24:03 +02:00
Alexandre Wilhelm and GitHub
6853c4c212
Merge pull request #2779 from daboe01/textview-contextmenu
...
New: support contextmenus for CPTextView
2019-03-29 15:06:39 -07:00
Alexandre Wilhelm and GitHub
800e15cfd0
Merge pull request #2803 from bedalton/fixed-return-type-CPPlatformPasteboard
...
Fixed: Return type CPPlatformPasteboard.j should return BOOL
2019-03-29 15:04:14 -07:00
Alexandre Wilhelm and GitHub
873f184117
Merge pull request #2798 from bedalton/formatting-add-semi-colons-to-CPTextStorage
...
Formatting: Add semi-colons to CPTextStorage.j
2019-03-29 15:03:47 -07:00
Alexandre Wilhelm and GitHub
3bae5cd5cb
Merge pull request #2807 from bedalton/fixed-duplicate-method-in-cparraycontroller
...
Fixed: Duplicate method in CPArrayController
2019-03-29 15:03:26 -07:00
Alexandre Wilhelm and GitHub
19300332e8
Merge pull request #2813 from bedalton/fixed-cpcontrol-misspelled-parameter-type
...
Fixed: CPControl misspelled parameter type
2019-03-29 15:02:12 -07:00
Alexandre Wilhelm and GitHub
89d88c9644
Merge pull request #2811 from bedalton/formatting-remove-redundant-semi-colon-in-cptextview
...
Formatting: Remove redundant semi-colon in CPTextView
2019-03-29 15:01:52 -07:00
Alexandre Wilhelm and GitHub
472014b1b1
Merge pull request #2812 from bedalton/fixed-cpwindowcontroller-returns-cpview
...
Fixed: Changed CPWindowController method return to CPView
2019-03-29 15:01:29 -07:00
Alexandre Wilhelm and GitHub
c094420428
Merge pull request #2810 from bedalton/fixed-cpscroller-return-style
...
Fixed: Change CPScroller's style method return type to int
2019-03-29 15:01:13 -07:00
Alexandre Wilhelm and GitHub
e948064063
Merge pull request #2809 from bedalton/fixed-cocolor-parameter-to-cpstring
...
Fixed: Changed CPColor parameter to CPString
2019-03-29 15:00:59 -07:00
Alexandre Wilhelm and GitHub
bdd3b7d2a5
Merge pull request #2808 from bedalton/fixed-cpbrowserdelegate-duplicate-method
...
Fixed: CPBrowserDelegate duplicate protocol method
2019-03-29 15:00:46 -07:00
Alexandre Wilhelm and GitHub
404c37b54c
Merge pull request #2800 from bedalton/fixed-mismatched-parameters-in-CPTextView
...
Fixed: mismatched parameters in CPTextView
2019-03-29 15:00:18 -07:00
Alexandre Wilhelm and GitHub
ac686a17fa
Merge pull request #2799 from bedalton/fixed-mispelled-parameter-in-CPTextView
...
Fixed: Misspelled parameter in CPTextView.j
2019-03-29 14:59:55 -07:00
Alexandre Wilhelm and GitHub
bfc5068b5e
Merge pull request #2796 from bedalton/formatting-remove-redundant-semi-colon-CPDatePicker
...
Formatting: Remove redundant semi-colon form CPDatePicker
2019-03-29 14:59:39 -07:00
Alexandre Wilhelm and GitHub
649bee2330
Merge pull request #2806 from bedalton/fixed-cpbezier-path-nsinteger
...
Fixed: CPBezierPath using parameter type NSInteger
2019-03-29 14:59:18 -07:00
Alexandre Wilhelm and GitHub
593587ea60
Merge pull request #2805 from bedalton/fixed-cpapplication-isactive-return-type
...
Fixed: CPApplication's isActive method return type
2019-03-29 14:59:02 -07:00
Alexandre Wilhelm and GitHub
0ab81a7b32
Merge pull request #2804 from bedalton/fixed-_cpautocompletemenu-return-type
...
Fixed: Changed void return to id in CPAutocompleteMenu.j
2019-03-29 14:58:50 -07:00
Alexandre Wilhelm and GitHub
8bf937357c
Merge pull request #2801 from bedalton/formatting-remove-semi-colon-_CPStandardWindowView
...
Formatting: Remove extraneous semi-colon _CPStandardWindowView.j
2019-03-29 14:58:16 -07:00
daniel
cba9212150
Fixed: CPControl parameter type to CPVerticalTextAlignment
...
Parameter was set to type CPTextVerticalAlignment, but typedef was declared as CPVerticalTextAlignment. This commit fixes this mismatch
2019-03-29 11:58:51 -07:00
daniel
a0a6c42227
Fixed: Change return in CPWindowController to CPView
...
In CPWindowController, method viewControllerContainerView, implies that it returns something, and it does. It returns the _viewControllerContainerView instance object, and return type should be changed from void to CPView
2019-03-28 15:19:59 -07:00
daniel
c245d9de80
Formatting: Removed redundant semi-colon in CPTextField
2019-03-28 14:55:44 -07:00
daniel
ca5cd8e09b
Fixed: CPScroller's style method should have returned int
...
Despite returning an int and a comment stating it returns a value, CPScroller's style method had a return type of void.
2019-03-28 14:51:15 -07:00
daniel
34ac4cd23b
Fixed: Changed CPColor parameter from string to CPString
...
Parameter type in CPColor was string, changed here to CPString, to make it more inline with other string parameter types.
2019-03-28 14:33:00 -07:00
daniel
8598fe8ad9
Revert "Fixed: Changed CPColor parameter type from string to CPString"
...
This reverts commit 06498672ab .
2019-03-28 14:32:00 -07:00
daniel
3699a31f28
Revert "Formatting: Removed extra semi-colon ThemeDescriptors.j"
...
This reverts commit 75cd5a75e1 .
2019-03-28 14:31:17 -07:00
daniel
06498672ab
Fixed: Changed CPColor parameter type from string to CPString
...
Parameter type in CPColor was string, changed here to CPString, to make it more inline with other string parameter types.
2019-03-28 14:29:50 -07:00
daniel
cd3b92af7a
Fixed:CPBrowserDelegate duplicate method
...
Method browser:imageValueForItem was defined twice in CPBrowserDelegate. Once on line 43, and the other on line 45. This removes the commit removed the second declaration
2019-03-28 14:26:08 -07:00
daniel
e15cc29e2f
Fixed: CPBezierPath used parameter types NSInteger
...
CPBezierPath has parameter type NSInteger. Assumed meant to be CPInteger
2019-03-28 14:19:09 -07:00
daniel
dabeb066de
Fixed: Duplicate method in CPArrayController.j
...
Method alwaysUsesMultipleValuesMarker is duplicated in class CPArrayController.j. Both methods have the same body and same selector, the only difference being their comments are slightly different. Both comments however communicate the same thing.
2019-03-28 14:11:28 -07:00
daniel
c59e7cc456
Fixed: Changed CPApplication's isActive method return type to BOOL
...
Method has declared return type of void, despite the method returning a BOOL, and the name implying that it returns a BOOL
2019-03-28 14:08:00 -07:00
daniel
3c16bfef58
Fixed: Changed void return type to id in _CPAutocompleteMenu.j
...
tableView:objectValueForTableColumn:row: has return type set to void, despite returning an method call returning id. Similar methods also return id.
2019-03-28 14:01:31 -07:00
daniel
ec24977d4e
Revert "Fixed: changed void return type in _CPAutocompleMenu.j to id"
...
This reverts commit 10b4f57a0e .
2019-03-28 13:58:15 -07:00
daniel
10b4f57a0e
Fixed: changed void return type in _CPAutocompleMenu.j to id
...
tableView:objectValueForTableColumn:row: has return type set to void, despite returning an method call returning id. Similar methods also return id.
2019-03-28 13:54:20 -07:00
daniel
75cd5a75e1
Formatting: Removed extra semi-colon ThemeDescriptors.j
2019-03-28 13:46:25 -07:00
daniel
fb2d0ed170
Fixed: Return types in CPPlatformPasteboard.j should return BOOL
...
Method _mayRequireDOMPasteboardElementHack:flags had return type of void, despite returning a BOOL value, and also being annotated with a doc comment stating that it should return a BOOL value
Also some methods had return type "boolean", should possibly be BOOL
2019-03-28 13:42:39 -07:00
daniel
d4e139eaf5
Fixed: Return type for method in CPPlatformPasteboard.j
...
Method return type is labeled as void despite returning a BOOL and the DOC comment stating that it should return a BOOL
2019-03-28 13:38:33 -07:00
daniel
49ef1276f6
Formatting: Removed extra semi-colon in _CPStandardWindowView.j
2019-03-28 13:32:56 -07:00
daniel
828788b643
Fixed: Mismatched parameter types in CPTextView
...
isBlinking had return type void, but returned a BOOL, and the method name implies that it returns a BOOL.
Some parameters were marked as integer, so were changed to int to coincide with most other names for integers.
setString had parameter type id, despite implying that parameter was a string, and the super class parameter being a string.
2019-03-28 13:21:34 -07:00
daniel
0ca8d7a258
Fixed: Mispelled DOMElement parameter in CPTextView.j
2019-03-28 13:12:30 -07:00