hueso/Sensor-Watch
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Activity

movement: prevent invalid tick frequency from breaking scheduled tasks

Browse Source
This commit is contained in:
Joey Castillo 2022-02-12 22:19:01 -05:00
parent 5dac14974c
commit b8cb6f3bcf
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
movement/movement.c
View File

@ -152,14 +152,19 @@ static void _movement_handle_scheduled_tasks(void) {
}
void movement_request_tick_frequency(uint8_t freq) {
if (freq == 128) return; // Movement uses the 128 Hz tick internally
// Movement uses the 128 Hz tick internally
if (freq == 128) return;
// Movement requires at least a 1 Hz tick.
// If we are asked for an invalid frequency, default back to 1 Hz.
if (freq == 0 || __builtin_popcount(freq) != 1) freq = 1;
// disable all callbacks except the 128 Hz one
watch_rtc_disable_matching_periodic_callbacks(0xFE);
movement_state.subsecond = 0;
movement_state.tick_frequency = freq;
if (freq) watch_rtc_register_periodic_callback(cb_tick, freq);
watch_rtc_register_periodic_callback(cb_tick, freq);
}
void movement_illuminate_led(void) {

2
movement/movement.h
View File

@ -274,8 +274,6 @@ void movement_move_to_face(uint8_t watch_face_index);
void movement_move_to_next_face(void);
void movement_illuminate_led(void);
// note: requesting a tick frequency of 0 will break any scheduled background tasks.
// this will be fixed in a future refactor of the tick mechanism.
void movement_request_tick_frequency(uint8_t freq);
// note: watch faces can only schedule a background task when in the foreground, since