hueso/Sensor-Watch
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Activity

Deduplicate month-length table in deadline_face

Browse Source 
_increment_date() kept its own copy of the days-per-month table
and leap-year check, duplicating _days_in_month() in the same
file. Two sources of truth is how the July day-count typo went
unnoticed. Call _days_in_month() directly instead, leaving one
table in the file.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PSucp94GA31sshe5AjvSzQ
This commit is contained in:
Konrad Rieck
2026-07-27 20:41:36 +02:00
co-authored by Claude Sonnet 5
parent 0b7ea662fe
commit eacb6de737
1 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
watch-faces/complication/deadline_face.c
+1 -6
View File
@@ -227,8 +227,6 @@ static void _correct_time_difference(int16_t *units, watch_date_time_t deadline)
/* Increment date in settings mode. Function taken from `set_time_face.c` */
static void _increment_date(deadline_state_t *state, watch_date_time_t date_time)
{
const uint8_t days_in_month[12] = { 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31 };
switch (state->current_page) {
case 0:
/* Only 10 years covered. Fix this sometime next decade */
@@ -238,10 +236,7 @@ static void _increment_date(deadline_state_t *state, watch_date_time_t date_time
date_time.unit.month = (date_time.unit.month % 12) + 1;
break;
case 2: {
/* Check for leap years */
uint8_t days = days_in_month[date_time.unit.month - 1];
if (date_time.unit.month == 2 && _is_leap(date_time.unit.year))
days++;
int days = _days_in_month(date_time.unit.month, date_time.unit.year);
/* Compute next day outside the 5-bit bitfield so overflow past 31
* can be compared against `days` before it gets truncated. */