From 1e04f92abba6d86cd2a81842f6e2885bc33b4861 Mon Sep 17 00:00:00 2001 From: Yann Leboulanger Date: Thu, 3 Aug 2017 14:12:47 +0200 Subject: [PATCH] [plugin_installer] do not update plugin if it's not compatible with current Gajim version. Fixes #225 --- plugin_installer/plugin_installer.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/plugin_installer/plugin_installer.py b/plugin_installer/plugin_installer.py index 5f7b54e..8bc210f 100644 --- a/plugin_installer/plugin_installer.py +++ b/plugin_installer/plugin_installer.py @@ -450,7 +450,13 @@ class DownloadAsync(threading.Thread): for plugin in plugin_list: local_version = get_local_version(plugin['name']) if local_version: - if V(plugin['version']) > V(local_version): + gajim_v = V(gajim.config.get('version')) + min_v = plugin.get('min_gajim_version', None) + min_v = V(min_v) if min_v else gajim_v + max_v = plugin.get('max_gajim_version', None) + max_v = V(max_v) if max_v else gajim_v + if (V(plugin['version']) > V(local_version)) and \ + gajim_v >= min_v and gajim_v <= max_v: to_update.append(plugin['name']) GLib.idle_add(self.plugin.warn_update, to_update)