From 990d23b714b34ef3948ecd733ffee6938159c628 Mon Sep 17 00:00:00 2001 From: wurstsalat Date: Sun, 28 Feb 2021 17:17:35 +0100 Subject: [PATCH] [preview] Catch possible error while saving pixbuf The returned error from save_to_bufferv() is not always reliable, and might be True even if saving succeeded. --- url_image_preview/utils.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/url_image_preview/utils.py b/url_image_preview/utils.py index ec89e45..ef4c455 100644 --- a/url_image_preview/utils.py +++ b/url_image_preview/utils.py @@ -150,9 +150,10 @@ def create_thumbnail_with_pixbuf(data, size): thumbnail = pixbuf.scale_simple(width, height, GdkPixbuf.InterpType.BILINEAR) - has_error, bytes_ = thumbnail.save_to_bufferv('png', [], []) - if has_error: - log.warning('saving pixbuf to buffer failed') + try: + _error, bytes_ = thumbnail.save_to_bufferv('png', [], []) + except GLib.Error as err: + log.warning('Saving pixbuf to buffer failed: %s', err) return None return bytes_