From 0484ff64757a585cf3f8f3580ac246e956b3f77a Mon Sep 17 00:00:00 2001 From: Lakshya Singh Date: Tue, 26 Sep 2023 00:37:51 +0530 Subject: [PATCH] refactor: use ARG instead of ENV - keep environment variables clean Signed-off-by: Lakshya Singh --- bitcoind/Dockerfile | 4 ++-- lightningd/Dockerfile | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/bitcoind/Dockerfile b/bitcoind/Dockerfile index d0753d3..07f761c 100644 --- a/bitcoind/Dockerfile +++ b/bitcoind/Dockerfile @@ -46,8 +46,8 @@ RUN set -ex \ done && \ wget -O- https://raw.githubusercontent.com/Kvaciral/kvaciral/main/kvaciral.asc | gpg --import -ENV BITCOIN_VERSION=23.0 -ENV BITCOIN_PREFIX=/opt/bitcoin-${BITCOIN_VERSION} +ARG BITCOIN_VERSION=23.0 +ARG BITCOIN_PREFIX=/opt/bitcoin-${BITCOIN_VERSION} ARG SHA256SUMS_HASH=aaff81ea001f499e8f6f3221387d7db960d71a3b7a4a2b1aaf2c8060bc94a391 RUN wget https://bitcoincore.org/bin/bitcoin-core-${BITCOIN_VERSION}/SHA256SUMS diff --git a/lightningd/Dockerfile b/lightningd/Dockerfile index 5c64431..4dc327b 100644 --- a/lightningd/Dockerfile +++ b/lightningd/Dockerfile @@ -68,8 +68,8 @@ RUN apk update && \ sqlite-dev ARG LIGHTNINGD_UID=101 -ENV LIGHTNINGD_USER=lightning -ENV LIGHTNINGD_HOME=/home/${LIGHTNINGD_USER} +ARG LIGHTNINGD_USER=lightning +ARG LIGHTNINGD_HOME=/home/${LIGHTNINGD_USER} ENV LIGHTNINGD_DATA=${LIGHTNINGD_HOME}/.lightning \ LIGHTNINGD_RPC_PORT=9835 \ LIGHTNINGD_PORT=9735 \