dockerfile: optimize on size and network call

- merge multiple steps to reduce number of layers
- run make clean to reduce layer size
- run cargo clean
- merge multiple ARG into single step
Signed-off-by: Lakshya Singh <lakshay.singh1108@gmail.com>

lightningd/Dockerfile

@@ -27,17 +27,18 @@ RUN apk update && \
       zlib-dev \
       zlib-static
 
-ARG CORE_LIGHTNING_GIT_HASH=bd9494c65be09e6f8ecb3bc49b50a859467a65fe
-ARG CORE_LIGHTNING_REPO=https://github.com/lightning-signer/c-lightning.git
+ARG CORE_LIGHTNING_GIT_HASH=bd9494c65be09e6f8ecb3bc49b50a859467a65fe \
+    CORE_LIGHTNING_REPO=https://github.com/lightning-signer/c-lightning.git
 RUN git clone --recursive $CORE_LIGHTNING_REPO core-lightning
 RUN cd core-lightning && \
     git checkout $CORE_LIGHTNING_GIT_HASH && \
     ./configure --enable-static --prefix=/usr && \
     make -j $(nproc) && \
-    make -j $(nproc) install
+    make -j $(nproc) install && \
+    make clean
 
-ARG PLUGINS_GIT_HASH=ce078bb74e10b5dea779fcd9fbe77e1d3e72db7a
-ARG PLUGINS_REPO=https://github.com/lightningd/plugins.git
+ARG PLUGINS_GIT_HASH=ce078bb74e10b5dea779fcd9fbe77e1d3e72db7a \
+    PLUGINS_REPO=https://github.com/lightningd/plugins.git
 RUN git clone $PLUGINS_REPO
 RUN cd plugins && \
     git checkout $PLUGINS_GIT_HASH
@@ -59,15 +60,16 @@ RUN apk update && \
     pkgconf \
     sqlite-dev
 
-ARG CLBOSS_GIT_HASH=9c050d61f01ffff4b7b5d295f708569dd71b55d3
-ARG CLBOSS_REPO=https://github.com/ZmnSCPxj/clboss.git
+ARG CLBOSS_GIT_HASH=9c050d61f01ffff4b7b5d295f708569dd71b55d3 \
+    CLBOSS_REPO=https://github.com/ZmnSCPxj/clboss.git
 RUN git clone --recurse-submodules $CLBOSS_REPO clboss
 RUN cd clboss && \
     git checkout $CLBOSS_GIT_HASH && \
     autoreconf -i && \
     ./configure --prefix=/usr && \
     make -j $(nproc) && \
-    make install
+    make -j $(nproc) install && \
+    make clean
 
 FROM --platform=${TARGETPLATFORM:-${BUILDPLATFORM:-linux/amd64}} alpine:3.18 as vls_builder
 
@@ -83,12 +85,13 @@ RUN apk update && \
     protobuf-dev \
     rust
 
-ARG VLS_GIT_HASH=af02dac8b855c361d74234387d288a9591fad1d5
-ARG VLS_REPO=https://gitlab.com/lightning-signer/validating-lightning-signer.git
+ARG VLS_GIT_HASH=af02dac8b855c361d74234387d288a9591fad1d5 \
+    VLS_REPO=https://gitlab.com/lightning-signer/validating-lightning-signer.git
 RUN git clone $VLS_REPO vls
 RUN cd vls && \
     git checkout $VLS_GIT_HASH && \
-    cargo build --bin remote_hsmd_socket --release
+    cargo install --path ./vls-proxy --bin remote_hsmd_socket --profile release --root /usr/local/ && \
+    cargo clean
 
 # final stage with runtime dependencies and pkgs
 FROM --platform=${TARGETPLATFORM:-${BUILDPLATFORM:-linux/amd64}} alpine:3.18 as runner
@@ -109,8 +112,8 @@ RUN apk update && \
       curl-dev \
       sqlite-dev
 
-ARG LIGHTNINGD_UID=101
-ARG LIGHTNINGD_USER=lightning
+ARG LIGHTNINGD_UID=101 \
+    LIGHTNINGD_USER=lightning
 ARG LIGHTNINGD_HOME=/home/${LIGHTNINGD_USER}
 ENV LIGHTNINGD_DATA=${LIGHTNINGD_HOME}/.lightning \
     LIGHTNINGD_RPC_PORT=9835 \
@@ -119,15 +122,13 @@ ENV LIGHTNINGD_DATA=${LIGHTNINGD_HOME}/.lightning \
 
 RUN mkdir -p /usr/local/src/plugins
 
-COPY --from=builder /usr/bin/lightningd /usr/bin/
-COPY --from=builder /usr/bin/lightning-cli /usr/bin/
-COPY --from=builder /usr/bin/lightning-hsmtool /usr/bin/
+COPY --from=builder /usr/bin/lightningd /usr/bin/lightning-cli /usr/bin/lightning-hsmtool /usr/bin/
 COPY --from=builder /usr/libexec/c-lightning /usr/libexec/c-lightning
 COPY --from=builder /usr/share/man/man8 /usr/share/man/man8
 COPY --from=builder /usr/share/doc/c-lightning /usr/share/doc/c-lightning
 COPY --from=clboss_builder /usr/bin/clboss /usr/bin/clboss
 COPY --from=builder /build/plugins/summary /usr/local/src/plugins/summary
-COPY --from=vls_builder /build/vls/target/release/remote_hsmd_socket /usr/libexec/c-lightning/remote_hsmd_socket
+COPY --from=vls_builder /usr/local/bin/remote_hsmd_socket /usr/libexec/c-lightning/remote_hsmd_socket
 
 RUN addgroup -S lightning && adduser -S lightning -G lightning && \
     mkdir -p ${LIGHTNINGD_DATA} && \