Add RS OAuth controller specs

app/controllers/rs/oauth_controller.rb

@@ -1,5 +1,6 @@
 class Rs::OauthController < ApplicationController
-  before_action :require_signed_in_with_username
+  before_action :require_signed_in_with_username, only: :new
+  before_action :authenticate_user!, only: :create
 
   def new
     username, org  = params[:useraddress].split("@")
@@ -30,23 +31,26 @@ class Rs::OauthController < ApplicationController
     end
 
     unless @client_id.present?
-      redirect_to url_with_state("#{@redirect_uri}#error=invalid_request", @state) and return
+      redirect_to(url_with_state("#{@redirect_uri}#error=invalid_request", @state),
+                  allow_other_host: true) and return
     end
 
     if @scopes.empty?
-      redirect_to url_with_state("#{@redirect_uri}#error=invalid_scope", @state) and return
+      redirect_to(url_with_state("#{@redirect_uri}#error=invalid_scope", @state),
+                  allow_other_host: true) and return
     end
 
     unless hostname_of(@client_id) == hostname_of(@redirect_uri)
-      redirect_to url_with_state("#{@redirect_uri}#error=invalid_client", @state) and return
+      redirect_to(url_with_state("#{@redirect_uri}#error=invalid_client", @state),
+                  allow_other_host: true) and return
     end
 
     @client_id.gsub!(/http(s)?:\/\//, "")
 
-    # TODO
-    # if auth = current_user.remote_storage_authorizations.valid.where(permissions: @scopes, client_id: @client_id).first
-    #   redirect_to url_with_state("#{@redirect_uri}#access_token=#{auth.token}", @state), allow_other_host: true
-    # end
+    if auth = current_user.remote_storage_authorizations.valid.where(permissions: @scopes, client_id: @client_id).first
+      redirect_to(url_with_state("#{@redirect_uri}#access_token=#{auth.token}", @state),
+                  allow_other_host: true) and return
+    end
   end
 
   def create
@@ -64,15 +68,18 @@ class Rs::OauthController < ApplicationController
     http_status :bad_request and return unless redirect_uri.present?
 
     if permissions.empty?
-      redirect_to url_with_state("#{redirect_uri}#error=invalid_scope", state), allow_other_host: true and return
+      redirect_to(url_with_state("#{redirect_uri}#error=invalid_scope", state),
+                  allow_other_host: true) and return
     end
 
     unless client_id.present?
-      redirect_to url_with_state("#{redirect_uri}#error=invalid_request", state), allow_other_host: true and return
+      redirect_to(url_with_state("#{redirect_uri}#error=invalid_request", state),
+                  allow_other_host: true) and return
     end
 
     unless hostname_of(client_id) == hostname_of(redirect_uri)
-      redirect_to url_with_state("#{redirect_uri}#error=invalid_client", state), allow_other_host: true and return
+      redirect_to(url_with_state("#{redirect_uri}#error=invalid_client", state),
+                  allow_other_host: true) and return
     end
 
     client_id.gsub!(/http(s)?:\/\//, "")
@@ -85,14 +92,15 @@ class Rs::OauthController < ApplicationController
       expire_at: expire_at
     )
 
-    redirect_to url_with_state("#{redirect_uri}#access_token=#{auth.token}", state), allow_other_host: true
+    redirect_to url_with_state("#{redirect_uri}#access_token=#{auth.token}", state),
+                allow_other_host: true
   end
 
   # GET /rs/oauth/token/:id/launch_app
   def launch_app
     auth = current_user.remote_storage_authorizations.find(params[:id])
 
-    redirect_to app_auth_url(auth)
+    redirect_to app_auth_url(auth), allow_other_host: true
   end
 
   private