Only validate display name when updated

Otherwise we needlessly fetch the validated one from LDAP every time a model is saved.
2023-05-27 20:09:02 +02:00 · 2023-05-27 20:09:02 +02:00 · 445cdfa024
commit 445cdfa024
parent f74227fedb
1 changed files with 2 additions and 1 deletions
--- a/app/models/user.rb
+++ b/app/models/user.rb
@ -33,7 +33,8 @@ class User < ApplicationRecord
  validates_uniqueness_of :email
  validates :email, email: true

-  validates_length_of :display_name, minimum: 3, maximum: 35, allow_blank: true
+  validates_length_of :display_name, minimum: 3, maximum: 35, allow_blank: true,
+                                     if: -> { defined?(@display_name) }

  scope :confirmed, -> { where.not(confirmed_at: nil) }
  scope :pending,   -> { where(confirmed_at: nil) }