Only update avatars in one place

Prevent future mistakes

app/controllers/settings_controller.rb

@@ -35,8 +35,7 @@ class SettingsController < ApplicationController
 
       if @user.avatar_new.present?
         if store_user_avatar
-          LdapManager::UpdateAvatar.call(user: @user)
+          UserManager::UpdateAvatar.call(user: @user)
-          XmppSetAvatarJob.perform_later(user: @user) if Setting.ejabberd_enabled?
         else
           @validation_errors = @user.errors
           render :show, status: :unprocessable_entity and return

app/services/user_manager/import_remote_avatar.rb

@@ -7,8 +7,7 @@ module UserManager
 
     def call
       if import_remote_avatar
-        LdapManager::UpdateAvatar.call(user: @user)
+        UserManager::UpdateAvatar.call(user: @user)
-        XmppSetAvatarJob.perform_later(user: @user) if Setting.ejabberd_enabled?
       end
     end
 

app/services/user_manager/update_avatar.rb

@@ -0,0 +1,15 @@
+module UserManager
+  class UpdateAvatar < UserManagerService
+    def initialize(user:)
+      @user = user
+    end
+
+    def call
+      LdapManager::UpdateAvatar.call(user: @user)
+
+      if Setting.ejabberd_enabled?
+        XmppSetAvatarJob.perform_later(user: @user)
+      end
+    end
+  end
+end