From f49aff262c79f5c4048fde0ad31f6994249c00b4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C3=A2u=20Cao?= <raucao@kip.pe>
Date: Mon, 7 Aug 2023 18:15:17 +0200
Subject: [PATCH] Add base controller for service controllers

---
 app/controllers/services/base_controller.rb     |  9 +++++++++
 .../services/remotestorage_controller.rb        | 17 +++++------------
 2 files changed, 14 insertions(+), 12 deletions(-)
 create mode 100644 app/controllers/services/base_controller.rb

diff --git a/app/controllers/services/base_controller.rb b/app/controllers/services/base_controller.rb
new file mode 100644
index 0000000..9bb0b21
--- /dev/null
+++ b/app/controllers/services/base_controller.rb
@@ -0,0 +1,9 @@
+class Services::BaseController < ApplicationController
+  before_action :set_current_section
+
+  private
+
+    def set_current_section
+      @current_section = :services
+    end
+end
diff --git a/app/controllers/services/remotestorage_controller.rb b/app/controllers/services/remotestorage_controller.rb
index 231e359..5d455ba 100644
--- a/app/controllers/services/remotestorage_controller.rb
+++ b/app/controllers/services/remotestorage_controller.rb
@@ -1,8 +1,7 @@
-class Services::RemotestorageController < ApplicationController
-  before_action :require_user_signed_in
-  before_action :require_service_enabled
+class Services::RemotestorageController < Services::BaseController
+  before_action :authenticate_user!
   before_action :require_feature_enabled
-  before_action :set_current_section
+  before_action :require_service_available
 
   def dashboard
     # unless current_user.services_enabled.include?(:remotestorage)
@@ -18,13 +17,7 @@ class Services::RemotestorageController < ApplicationController
       end
     end
 
-    def require_service_enabled
-      unless Setting.remotestorage_enabled?
-        http_status :not_found
-      end
-    end
-
-    def set_current_section
-      @current_section = :services
+    def require_service_available
+      http_status :not_found unless Setting.remotestorage_enabled?
     end
 end