kosmos/akkounts
kosmos/akkounts
8
1
Fork 0
Code Issues 19 Pull Requests 1 Actions Packages Releases 12 Activity

Fail gracefully when remote icon is 404
All checks were successful
continuous-integration/drone/push Build is passing
Details

Browse Source
This commit is contained in:
Râu Cao 2024-01-29 14:54:18 +02:00
parent b0b56fcf92
commit f8da034e66
Signed by: raucao
GPG Key ID: 37036C356E56CC51
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/services/app_catalog_manager/update_metadata.rb
View File

@ -45,8 +45,12 @@ module AppCatalogManager
filename = "#{attachment_name}.png" filename = "#{attachment_name}.png"
key = "web_apps/#{@app.id}/icons/#{attachment_name}.png" key = "web_apps/#{@app.id}/icons/#{attachment_name}.png"
tempfile = Down.download(download_url) begin
@app.send(attachment_name).attach(key: key, io: tempfile, filename: filename) tempfile = Down.download(download_url)
@app.send(attachment_name).attach(key: key, io: tempfile, filename: filename)
rescue Down::NotFound
Rails.logger.warn "Icon download failed: NotFound error for #{download_url}"
end
end end
end end
end end