kosmos/akkounts
8
1
Fork 0
Code Issues 25 Pull Requests 1 Actions Packages Releases 12 Activity

Let users add a verified nostr pubkey to their account #101

Merged
raucao merged 14 commits from feature/98-nostr_nip05 into master 2023-06-16 13:04:24 +00:00
Conversation 4 Commits 14 Files Changed 41
+777 -244
raucao commented 2023-03-09 03:52:04 +00:00
Owner
Copy Link
Copy Source

Add a settings page (for experimental settings) that can verify and save nostr pubkeys for user accounts. It currently only allows adding keys from a browser extension, but not from manual signing outside of the browser.

This can then be used for:

  • #98 — NIP-05 user addresses (i.e. make your pubkey discoverable via your username@kosmos.org address)
  • #99 — Two-factor authentication
  • Notifications of all kinds (via encrypted DM)
  • Auth for publishing events to a potential Kosmos relay

Note: tagged WIP, because without any of the above-mentioned features, this is currently not useful to anyone. Adding the NIP-05 endpoint is the first and easiest feature to base on top of this now.

Update: NIP-05 support has been added in the meantime, see comments and commits.

closes #98

Add a settings page (for experimental settings) that can verify and save nostr pubkeys for user accounts. It currently only allows adding keys from a browser extension, but not from manual signing outside of the browser. This can then be used for: * #98 — [NIP-05](https://github.com/nostr-protocol/nips/blob/master/05.md) user addresses (i.e. make your pubkey discoverable via your username@kosmos.org address) * #99 — Two-factor authentication * Notifications of all kinds (via encrypted DM) * Auth for publishing events to a potential Kosmos relay Note: tagged WIP, because without any of the above-mentioned features, this is currently not useful to anyone. Adding the NIP-05 endpoint is the first and easiest feature to base on top of this now. Update: NIP-05 support has been added in the meantime, see comments and commits. closes #98
🎉 1
raucao added the feature label 2023-03-09 03:52:04 +00:00
raucao requested review from bumi 2023-03-09 06:32:30 +00:00
bumi reviewed 2023-03-10 21:00:27 +00:00
Gemfile Outdated
@@ -49,2 +49,4 @@
gem 'sidekiq-scheduler'
# Services
gem 'nostr', git: 'https://gitea.kosmos.org/kosmos/nostr-gem.git', branch: 'feature/ruby_2.7_compat'
bumi commented 2023-03-10 20:35:42 +00:00
Owner
Copy Link
Copy Source

adds quite some dependencies (like the websocket stuff) but I guess it's fine here as it is not conflicting with any dependencies that we already have.

adds quite some dependencies (like the websocket stuff) but I guess it's fine here as it is not conflicting with any dependencies that we already have.
raucao commented 2023-03-11 05:15:04 +00:00
Author
Owner
Copy Link
Copy Source

Yeah, the idea is that we can very easily add more nostr features using the same library.

Yeah, the idea is that we can very easily add more nostr features using the same library.
raucao marked this conversation as resolved
app/models/user.rb Outdated
@@ -30,3 +30,2 @@
scope :confirmed, -> { where.not(confirmed_at: nil) }
scope :pending, -> { where(confirmed_at: nil) }
validates_uniqueness_of :nostr_pubkey, scope: :ou, allow_blank: true
bumi commented 2023-03-10 20:38:49 +00:00
Owner
Copy Link
Copy Source

why the scope :ou?

why the `scope :ou`?
raucao commented 2023-03-11 05:16:10 +00:00
Author
Owner
Copy Link
Copy Source

It was supposed to be so that you can add the same key for accounts with different domains, but actually now that you mention it, I think it should always be unique, since you can only point back to one of them anyway.

It was supposed to be so that you can add the same key for accounts with different domains, but actually now that you mention it, I think it should always be unique, since you can only point back to one of them anyway.
raucao marked this conversation as resolved
app/models/user.rb Outdated
@@ -33,0 +32,4 @@
scope :confirmed, -> { where.not(confirmed_at: nil) }
scope :pending, -> { where(confirmed_at: nil) }
scope :all_except, -> (user) { where.not(id: user) }
bumi commented 2023-03-10 20:37:57 +00:00
Owner
Copy Link
Copy Source

does this need where.not(id: user.id) ?

does this need `where.not(id: user.id)` ?
raucao commented 2023-03-11 05:22:12 +00:00
Author
Owner
Copy Link
Copy Source

It's magic. ;)

It's magic. ;)
raucao marked this conversation as resolved
bumi commented 2023-03-10 21:06:29 +00:00
Owner
Copy Link
Copy Source

wondering if any other nip05 provider implements this that well currently

wondering if any other nip05 provider implements this that well currently
raucao commented 2023-03-11 05:26:25 +00:00
Author
Owner
Copy Link
Copy Source

wondering if any other nip05 provider implements this that well currently

Thanks. I was wondering the same. :)

I addressed your comments and resolved the one about the uniqueness validation.

> wondering if any other nip05 provider implements this that well currently Thanks. I was wondering the same. :) I addressed your comments and resolved the one about the uniqueness validation.
raucao added the kredits-2 label 2023-04-13 10:52:59 +00:00
raucao marked the pull request as ready for review 2023-04-13 12:45:08 +00:00
raucao commented 2023-04-13 12:47:42 +00:00
Author
Owner
Copy Link
Copy Source

This is now ready to merge. I have adjusted all the code to the refactored user settings routes and controller, as well as resolved the other merge conflicts.

Also, NIP-05 support was added a few weeks ago, so it's actually useful now. And I also just added a hint for users to update their public profile with the address, which is visible when a pubkey has been added.

This is now ready to merge. I have adjusted all the code to the refactored user settings routes and controller, as well as resolved the other merge conflicts. Also, NIP-05 support was added a few weeks ago, so it's actually useful now. And I also just added a hint for users to update their public profile with the address, which is visible when a pubkey has been added.
Screenshot from 2023-04-13 14-33-04.png
62 KiB
Screenshot from 2023-04-13 14-33-04.png
raucao force-pushed feature/98-nostr_nip05 from caeb13974c to bfc0969829 2023-06-16 12:40:44 +00:00 Compare
raucao added 1 commit 2023-06-16 12:55:21 +00:00
Fix path
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
Release Drafter / Update release notes draft (pull_request) Successful in 4s
Details
4551a14362
raucao removed review request for bumi 2023-06-16 13:04:14 +00:00
raucao merged commit 1b959b5643 into master 2023-06-16 13:04:24 +00:00
raucao deleted branch feature/98-nostr_nip05 2023-06-16 13:04:25 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
bumi
Labels
Clear labels
integration
btcpay
integration
discourse
integration
ejabberd
integration
email
integration
ldap
integration
lndhub
integration
mastodon
integration
nostr
integration
remotestorage
bug
Something is not working
 design
Graphic/visual design
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 good first issue
Dive in, and start contributing
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 on hold
Currently not actionable
 ops
Manual IT ops activities
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No labels feature kredits-2
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/akkounts#101