kosmos/akkounts
kosmos/akkounts
8
1
Fork 0
Code Issues 19 Pull Requests 1 Actions Packages Releases 12 Activity

Add LndHub wallets #33

Merged
raucao merged 13 commits from feature/lndhub into master 2021-11-22 23:04:19 +00:00
Conversation 3 Commits 13 Files Changed 22 +491 -130
raucao commented 2021-11-20 21:31:11 +00:00
Owner
Copy Link

This adds LndHub Lightning wallets and wallet setup UI for user accounts. Also adds lnurl-pay endpoints to support lnurl-based payments, and one of the endpoints can also be proxied to for the Lightning Address .well-known URLs.

The latter means that, as soon as the addresses are enabled, you can easily send sats to any Kosmos user address, e.g. from resolving your XMPP contacts' JIDs. However, that is not part of this PR, but only the wallets themselves, which you can set up to use with Blue Wallet, as well as the lnurl-pay endpoints for generating invoices from URLs.

I tested it with our production LndHub, but we'll have to add something for simple development testing (local lndhub against remote LND I guess).

Deployment

There's a Rake task for generating wallets for all users via Sidekiq jobs, after this code has been deployed to production.

bundle exec rails lndhub:generate_wallets

Caveat

CI for this repo is currently broken, but not due to code changes in the repo. I created an issue for that in the Chef repo. You should be able to run the suite locally without problems.

refs #34

This adds [LndHub](https://github.com/BlueWallet/LndHub) Lightning wallets and wallet setup UI for user accounts. Also adds [lnurl-pay](https://github.com/fiatjaf/lnurl-rfc/blob/luds/06.md) endpoints to support lnurl-based payments, and one of the endpoints can also be proxied to for the [Lightning Address](https://lightningaddress.com/) `.well-known` URLs. The latter means that, as soon as the addresses are enabled, you can easily send sats to any Kosmos user address, e.g. from resolving your XMPP contacts' JIDs. However, that is not part of this PR, but only the wallets themselves, which you can set up to use with [Blue Wallet](https://bluewallet.io/), as well as the lnurl-pay endpoints for generating invoices from URLs. I tested it with our [production LndHub](https://lndhub.kosmos.org/), but we'll have to add something for simple development testing (local lndhub against remote LND I guess). ### Deployment There's a Rake task for generating wallets for all users via Sidekiq jobs, after this code has been deployed to production. bundle exec rails lndhub:generate_wallets ### Caveat CI for this repo is currently broken, but not due to code changes in the repo. I created [an issue for that](https://gitea.kosmos.org/kosmos/chef/issues/352) in the Chef repo. You should be able to run the suite locally without problems. refs #34
raucao added 1 commit 2021-11-20 21:31:11 +00:00
raucao changed title from WIP: Add LndHub wallets to Add LndHub wallets 2021-11-20 21:52:46 +00:00
raucao changed title from Add LndHub wallets to WIP: Add LndHub wallets 2021-11-20 21:53:00 +00:00
raucao added 1 commit 2021-11-20 22:14:25 +00:00
Add wallet page
Some checks failed
continuous-integration/drone/pr Build is failing
Details
continuous-integration/drone/push Build is failing
Details
0a1052fcb7 
With setup code to connect Blue Wallet to Kosmos account wallets
raucao added 1 commit 2021-11-21 19:28:37 +00:00
Fix small issue with turbolinks
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
21c6ebc137 
The JS was run again, and failed to assign variables using `const` then.
raucao added 1 commit 2021-11-21 21:34:35 +00:00
Formatting
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
3c350155de
raucao added 1 commit 2021-11-21 22:48:11 +00:00
Show available balance on wallet page
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
884070a3cb
raucao added 1 commit 2021-11-22 21:41:53 +00:00
Add LndHub service, lnurl-pay endpoints
Some checks failed
continuous-integration/drone/pr Build is failing
Details
continuous-integration/drone/push Build is failing
Details
dbc811b840 
Enables the lnurl-pay payment workflow
raucao added 1 commit 2021-11-22 21:52:02 +00:00
Don't overwrite existing lndhub wallet credentials
Some checks failed
continuous-integration/drone/pr Build is failing
Details
continuous-integration/drone/push Build is failing
Details
8662a4c8c1
raucao added 1 commit 2021-11-22 22:19:34 +00:00
Configure LndHub for production
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
e2ee33a1da
raucao added 1 commit 2021-11-22 22:23:06 +00:00
Add Rake task for generating wallets
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
4f20cd0d0a
raucao added 1 commit 2021-11-22 22:24:57 +00:00
Adjust spec for new development config
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
bfa38ad7b2
raucao added 1 commit 2021-11-22 22:26:15 +00:00
Remove obsolete comment
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
1078c034ad
raucao added 1 commit 2021-11-22 22:29:33 +00:00
Remove obsolete files
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
40e5c3609e
raucao changed title from WIP: Add LndHub wallets to Add LndHub wallets 2021-11-22 22:29:47 +00:00
raucao requested review from bumi 2021-11-22 22:37:06 +00:00
bumi approved these changes 2021-11-22 22:56:10 +00:00
bumi left a comment
Owner
Copy Link

looks good to me.
utACK

looks good to me. utACK
app/controllers/lnurlpay_controller.rb Outdated
@ -0,0 +9,4 @@
maxSendable: 1000000,
minSendable: 1000,
metadata: metadata(@user.address),
commentAllowed: 255
bumi commented 2021-11-22 22:47:16 +00:00
Owner
Copy Link

we should set this to 0 because we do not allow the payer to send a comment with the payment.

we should set this to `0` because we do not allow the payer to send a comment with the payment.
👍 1
raucao added 1 commit 2021-11-22 23:03:49 +00:00
Do not allow comments for lnurlp senders
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
bf76ac55ee
raucao merged commit 25ddab9241 into master 2021-11-22 23:04:19 +00:00
raucao deleted branch feature/lndhub 2021-11-22 23:04:27 +00:00
galfert approved these changes 2021-11-22 23:26:16 +00:00
galfert left a comment
Owner
Copy Link

Nice. That looks pretty dope 👍 Looking forward to using it.

Haven't tested it locally, but code looks all good to me.

Just left one comment/question.

Nice. That looks pretty dope 👍 Looking forward to using it. Haven't tested it locally, but code looks all good to me. Just left one comment/question.
app/controllers/lnurlpay_controller.rb
@ -0,0 +49,4 @@
def validate_amount(amount)
if amount > 1000000 || amount < 1000
render json: { status: "ERROR", reason: "Invalid amount" }
galfert commented 2021-11-22 22:54:54 +00:00
Owner
Copy Link

Shouldn't this also give an error response code? Maybe 422?

Shouldn't this also give an error response code? Maybe 422?
👍 1
raucao commented 2021-11-22 23:27:56 +00:00
Author
Owner
Copy Link

You would think so, but no. That's how ldnhub clients are expected to implement errors. ;)

You would think so, but no. That's how ldnhub clients are expected to implement errors. ;)
galfert commented 2021-11-22 23:56:41 +00:00
Owner
Copy Link

WHUT?

WHUT? ![](https://storage.5apps.com/galfert/public/shares/170629-1354-lebowski.gif)
😆 1
bumi commented 2021-11-23 00:08:59 +00:00
Owner
Copy Link

the lnurl spec specifically says to ignore HTTP status codes :( - no idea why... but because of that it's better to return a 200

the lnurl spec specifically says to ignore HTTP status codes :( - no idea why... but because of that it's better to return a 200
bumi reviewed 2021-11-23 19:12:34 +00:00
app/controllers/lnurlpay_controller.rb
@ -0,0 +20,4 @@
validate_amount(amount)
payment_request = @user.ln_create_invoice({
amount: amount,
bumi commented 2021-11-23 19:12:34 +00:00
Owner
Copy Link

this must be amount/1000 - amount is in msats but we create invoices for sats.

this must be `amount/1000` - amount is in msats but we create invoices for sats.
👍 1
Sign in to join this conversation.
Reviewers
No Reviewers
bumi
galfert
Labels
Clear labels
integration
btcpay
integration
discourse
integration
ejabberd
integration
email
integration
ldap
integration
lndhub
integration
mastodon
integration
nostr
integration
remotestorage
bug
Something is not working
design
Graphic/visual design
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
good first issue
Dive in, and start contributing
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
on hold
Currently not actionable
ops
Manual IT ops activities
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg hueso raucao slvrbckt
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/akkounts#33
No description provided.
Delete Branch "feature/lndhub"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?