kosmos/akkounts
8
1 Fork 0
Code Issues 25 Pull Requests 2 Actions Packages Releases 14 Activity

Fixes/improvements for lnurl-pay #49

Merged
raucao merged 3 commits from feature/lnurlp_improvements into master 2021-11-26 17:37:37 +00:00
Conversation 1 Commits 3 Files Changed 1
+4 -4
raucao commented 2021-11-26 01:18:39 +00:00
Owner
Copy link
Copy source
  • Change description and success message for lnurlp
  • Set correct min/max amounts for lnurlp

closes #46
fixes #47

* Change description and success message for lnurlp * Set correct min/max amounts for lnurlp closes #46 fixes #47
raucao added the kredits-1 label 2021-11-26 01:18:39 +00:00
raucao added 2 commits 2021-11-26 01:18:39 +00:00
Set correct min/max amounts for lnurlp f3b22c02ef 
fixes #47
Change description and success message for lnurlp
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
2e31268698 
closes #46
raucao requested review from bumi 2021-11-26 01:19:02 +00:00
bumi approved these changes 2021-11-26 02:55:35 +00:00
app/controllers/lnurlpay_controller.rb Outdated
@@ -9,2 +9,2 @@
maxSendable: 1000000,
minSendable: 1000,
maxSendable: 1000000 * 1000, # msat
minSendable: 1000 * 1000, # msat
bumi commented 2021-11-26 02:55:08 +00:00
Owner
Copy link
Copy source

minimum of 1000 sats? isn't that a bit much?

minimum of 1000 sats? isn't that a bit much?
raucao commented 2021-11-26 17:36:36 +00:00
Author
Owner
Copy link
Copy source

I lowered it to 100 now.

I lowered it to 100 now.
raucao marked this conversation as resolved
raucao added 1 commit 2021-11-26 17:35:09 +00:00
Lower the minimum receivable via lnurlp
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
67d148d117
raucao merged commit a7390ba00b into master 2021-11-26 17:37:37 +00:00
raucao deleted branch feature/lnurlp_improvements 2021-11-26 17:37:48 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
bumi
Labels
Clear labels
integration
btcpay
integration
discourse
integration
ejabberd
integration
email
integration
ldap
integration
lndhub
integration
mastodon
integration
nostr
integration
remotestorage
bug
Something is not working
 design
Graphic/visual design
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 good first issue
Dive in, and start contributing
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 on hold
Currently not actionable
 ops
Manual IT ops activities
 question
Looking for an answer
 security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
release
major
release
minor
release
patch
No labels kredits-1
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/akkounts#49