kosmos/akkounts
kosmos/akkounts
8
1
Fork 0
Code Issues 19 Pull Requests 1 Actions Packages Releases 12 Activity

Allow comments for LNURL-PAY invoices #65

Merged
raucao merged 3 commits from feature/lnurlp_memos into master 2022-03-02 14:13:40 +00:00
Conversation 6 Commits 3 Files Changed 2 +18 -2
raucao commented 2022-03-01 17:15:35 +00:00
Owner
Copy Link

Allows senders to add a short message to payments, which will be stored as invoice memo by LND/LndHub, and then should be shown in the receiver's wallet so they can know where a certain payment came from, when they didn't actively request it.

https://github.com/fiatjaf/lnurl-rfc/blob/luds/12.md

Allows senders to add a short message to payments, which will be stored as invoice memo by LND/LndHub, and then should be shown in the receiver's wallet so they can know where a certain payment came from, when they didn't actively request it. https://github.com/fiatjaf/lnurl-rfc/blob/luds/12.md
raucao requested review from bumi 2022-03-01 17:15:40 +00:00
raucao added the
kredits-1
 label 2022-03-01 17:15:48 +00:00
raucao force-pushed feature/lnurlp_memos from 2418acd727 to 4c51b9c966 2022-03-01 17:20:33 +00:00 Compare
raucao added 1 commit 2022-03-01 19:26:52 +00:00
Remove desc hash, always add memo to invoices
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
9903683536
raucao added 1 commit 2022-03-01 19:53:50 +00:00
Re-add description_hash
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
4c70600d1f 
Necessary for lnurlpay-enabled wallets
raucao commented 2022-03-01 20:30:43 +00:00
Author
Owner
Copy Link

This branch is running in production now, and actually working (so you can review it by using it).

It requires another LndHub change, which I'm going to propose separately (currently just manually changed on the server).

This branch is running in production now, and actually working (so you can review it by using it). It requires another LndHub change, which I'm going to propose separately (currently just manually changed on the server).
raucao commented 2022-03-02 04:22:37 +00:00
Author
Owner
Copy Link

I created a new repo for our LndHub fork (it was still using @bumi's repo with a manual fix for the onchain txs), and pushed my memo additions to it:

9b81cc6287

That repo is currently running on bitcoin-2 (Chef PR incoming).

I created a new repo for our LndHub fork (it was still using @bumi's repo with a manual fix for the onchain txs), and pushed my memo additions to it: https://gitea.kosmos.org/kosmos/lndhub/commit/9b81cc628730a13ba2ae7f0e17670918dde4dcd3 That repo is currently running on `bitcoin-2` (Chef PR incoming).
bumi commented 2022-03-02 09:53:47 +00:00
Owner
Copy Link

nice addition!

you should switch to the Go version :)

nice addition! you should switch to the Go version :)
raucao commented 2022-03-02 14:12:57 +00:00
Author
Owner
Copy Link

you should switch to the Go version :)

How? You're very welcome to help with that! I'd love nothing more than a clean database for those transactions and balances.

> you should switch to the Go version :) How? You're very welcome to help with that! I'd love nothing more than a clean database for those transactions and balances.
raucao merged commit 83e4dfa18f into master 2022-03-02 14:13:40 +00:00
raucao deleted branch feature/lnurlp_memos 2022-03-02 14:13:47 +00:00
bumi commented 2022-03-02 14:56:27 +00:00
Owner
Copy Link

We'd "only" need to migrate the users. There is no automation for that yet. the rest is exactly the same.
Will see when I get to writing a migration script. But I will likely start only with the balances and not indiviudal transactions.

We'd "only" need to migrate the users. There is no automation for that yet. the rest is exactly the same. Will see when I get to writing a migration script. But I will likely start only with the balances and not indiviudal transactions.
raucao commented 2022-03-02 15:48:19 +00:00
Author
Owner
Copy Link

Balances-only is fine. But people do have balances and some do use their accounts, so we have to migrate those.

There is currently no way to see who has which balance, since we haven't written a front-end for that Redis data and LndHub doesn't offer one.

Balances-only is fine. But people do have balances and some do use their accounts, so we have to migrate those. There is currently no way to see who has which balance, since we haven't written a front-end for that Redis data and LndHub doesn't offer one.
raucao added the
feature
 label 2023-03-28 14:45:58 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
bumi
Labels
Clear labels
integration
btcpay
integration
discourse
integration
ejabberd
integration
email
integration
ldap
integration
lndhub
integration
mastodon
integration
nostr
integration
remotestorage
bug
Something is not working
design
Graphic/visual design
dev environment
Config, builds, CI, deployment, etc.
docs
Documentation
duplicate
This issue or pull request already exists
enhancement
Improving existing functionality
feature
New functionality
good first issue
Dive in, and start contributing
idea
Something to consider
invalid
Not a bug
kredits-1
Small contribution
kredits-2
Medium contribution
kredits-3
Large contribution
on hold
Currently not actionable
ops
Manual IT ops activities
question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
ui/ux
User interface, process design, etc.
wontfix
This won't be fixed
No Label
feature
kredits-1
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero bumi fsmanuel galfert greg hueso raucao slvrbckt
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/akkounts#65
No description provided.
Delete Branch "feature/lnurlp_memos"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?