kosmos/akkounts
8
1
Fork 0
Code Issues 25 Pull Requests 1 Actions Packages Releases 12 Activity

Add Webhooks and XMPP notifications for incoming sats #79

Merged
raucao merged 10 commits from feature/webhooks into master 2023-01-13 04:33:02 +00:00
Conversation 1 Commits 10 Files Changed 17
+195 -5
raucao commented 2023-01-12 03:48:28 +00:00
Owner
Copy Link
Copy Source
  • Migrate ln_login out of encrypted column to ln_account, so we can look up users by login
  • Add Webhooks controller and config for allowed IPs
  • Add send_message API to ejabberd service, plus respective background job
  • Add Webhook for incoming sats, which notifies the user via XMPP message
* Migrate `ln_login` out of encrypted column to `ln_account`, so we can look up users by login * Add Webhooks controller and config for allowed IPs * Add `send_message` API to ejabberd service, plus respective background job * Add Webhook for incoming sats, which notifies the user via XMPP message
🎉 1
raucao added 5 commits 2023-01-12 03:48:28 +00:00
WIP Add Webhooks controller, allowed IP config
continuous-integration/drone/push Build is passing
Details
68e0d00f6e
Add migration for unencrypted ln login field
continuous-integration/drone/push Build is passing
Details
51952ecdc2
Rename job 2c8b3cdacc
Add send_message to ejabberd service 4232df302b
Notify user about incoming sats via XMPP
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
9e988e92d1
raucao added 1 commit 2023-01-12 03:50:32 +00:00
Fix spec after renaming job
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
d4a3f8dadb
raucao added 3 commits 2023-01-12 06:33:47 +00:00
Make status code explicit 4c0d8283e3
Remove hardcoded user address from hook aa3c2b4fa2
Add specs for lndhub webhook
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
a1663b9f9d
raucao marked the pull request as ready for review 2023-01-12 06:33:57 +00:00
raucao added the kredits-2 label 2023-01-12 06:34:01 +00:00
raucao requested review from greg 2023-01-12 06:34:07 +00:00
raucao requested review from galfert 2023-01-12 06:34:08 +00:00
raucao requested review from bumi 2023-01-12 06:34:09 +00:00
bumi approved these changes 2023-01-13 00:17:59 +00:00
bumi left a comment
Owner
Copy Link
Copy Source

that's super cool!
from checking the code it looks good to me.
I have a few minor comments

that's super cool! from checking the code it looks good to me. I have a few minor comments
app/controllers/webhooks_controller.rb
@@ -0,0 +5,4 @@
def lndhub
begin
payload = JSON.parse(request.body.read, symbolize_names: true)
bumi commented 2023-01-13 00:11:07 +00:00
Owner
Copy Link
Copy Source

doesn't rails automatically parse the JSON because the proper content type is set?
so params[:type] and params[:user_login] should be enough?

doesn't rails automatically parse the JSON because the proper content type is set? so `params[:type]` and `params[:user_login]` should be enough?
raucao commented 2023-01-13 04:23:45 +00:00
Author
Owner
Copy Link
Copy Source

I didn't know, so I tried (also with explicitly setting the content type in the spec). Doesn't do it.

I didn't know, so I tried (also with explicitly setting the content type in the spec). Doesn't do it.
raucao marked this conversation as resolved
app/controllers/webhooks_controller.rb Outdated
@@ -0,0 +11,4 @@
head :unprocessable_entity and return
end
user = User.find_by(ln_account: payload[:user_login])
bumi commented 2023-01-13 00:09:22 +00:00
Owner
Copy Link
Copy Source

should not be the case, but this might be nil. maybe we should do a User.find_by!

should not be the case, but this might be nil. maybe we should do a `User.find_by!`
raucao commented 2023-01-13 04:25:21 +00:00
Author
Owner
Copy Link
Copy Source

Good idea! Fails much cleaner and more expressively than when trying to access properties on nil later.

Good idea! Fails much cleaner and more expressively than when trying to access properties on `nil` later.
raucao marked this conversation as resolved
raucao added 1 commit 2023-01-13 04:24:44 +00:00
Throw exception when user cannot be found
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
b0c787bbc7
raucao merged commit f62e49f524 into master 2023-01-13 04:33:02 +00:00
raucao deleted branch feature/webhooks 2023-01-13 04:33:02 +00:00
raucao removed review request for galfert 2023-01-13 04:33:19 +00:00
raucao removed review request for greg 2023-01-13 04:33:22 +00:00
raucao added the feature label 2023-03-28 14:43:05 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
bumi
Labels
Clear labels
integration
btcpay
integration
discourse
integration
ejabberd
integration
email
integration
ldap
integration
lndhub
integration
mastodon
integration
nostr
integration
remotestorage
bug
Something is not working
 design
Graphic/visual design
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 good first issue
Dive in, and start contributing
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 on hold
Currently not actionable
 ops
Manual IT ops activities
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No labels feature kredits-2
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/akkounts#79