Sign up for new account via invitation #9

2020-12-03T13:53:36Z

raucao commented

2020-12-03 13:53:36 +00:00

Adds a task for generating a specified amount of invites for every user
Adds an as-of-yet unlinked invitations page (/invitations), displaying invitation URLs as well as used invitations with details.
Lets new users sign up from invitation URLs, with a nice step-by-step process. Allows going back and forth using back/forward history. Allows to easily sprinkle some live JS validation on it later.

Here's a screencap of it, if you don't want to run the code on your machine (needs local LDAP otherwise): https://storage.5apps.com/basti/public/shares/201203-1411-signup-from-invite-2020-12-03_15.07.23.mp4

closes #1

* Adds a task for generating a specified amount of invites for every user * Adds an as-of-yet unlinked invitations page (/invitations), displaying invitation URLs as well as used invitations with details. * Lets new users sign up from invitation URLs, with a nice step-by-step process. Allows going back and forth using back/forward history. Allows to easily sprinkle some live JS validation on it later. Here's a screencap of it, if you don't want to run the code on your machine (needs local LDAP otherwise): https://storage.5apps.com/basti/public/shares/201203-1411-signup-from-invite-2020-12-03_15.07.23.mp4 closes #1

raucao changed title from ~~Sign up for account via invitation~~ to Sign up for new account via invitation

2020-12-03 14:01:00 +00:00

raucao added the kredits-2 label 2020-12-03 14:01:28 +00:00

raucao requested review from bumi 2020-12-03 14:13:26 +00:00

raucao requested review from galfert 2020-12-03 14:13:27 +00:00

raucao requested review from greg 2020-12-03 14:13:27 +00:00

galfert approved these changes

2020-12-04 00:04:53 +00:00

galfert left a comment

Code looks all good to me.

Looks like I can't delete the comment I made on the ApplicationService. Took me a while, but I think I understand it now.

Code looks all good to me. Looks like I can't delete the comment I made on the `ApplicationService`. Took me a while, but I think I understand it now.

app/services/application_service.rb

						
				@@ -0,0 +2,4 @@

				  def self.call(*args, &block)

				    new(*args, &block).call

				  end

				end

galfert commented

2020-12-03 23:09:25 +00:00

What does this do and what is it for?

galfert marked this conversation as resolved

raucao removed review request for greg 2020-12-04 12:23:30 +00:00

raucao removed review request for bumi 2020-12-04 12:23:33 +00:00

raucao commented

2020-12-04 12:30:06 +00:00

Looks like I can’t delete the comment I made on the ApplicationService. Took me a while, but I think I understand it now.

Good point. I added an explanatory comment to that class, so it's clear for the next person.

> Looks like I can’t delete the comment I made on the ApplicationService. Took me a while, but I think I understand it now. Good point. I added an explanatory comment to that class, so it's clear for the next person.

raucao referenced this issue from a commit

2020-12-04 12:30:28 +00:00

Merge pull request 'Sign up for new account via invitation' (#9) from feature/signup_from_invite into master Reviewed-on: https://gitea.kosmos.org/kosmos/akkounts/pulls/9

raucao merged commit efe168b205 into master

2020-12-04 12:30:28 +00:00

raucao deleted branch feature/signup_from_invite

2020-12-04 12:30:35 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kosmos/akkounts#9