kosmos/akkounts
8
1
Fork 0
Code Issues 25 Pull Requests 1 Actions Packages Releases 12 Activity

Add service attribute to LDAP user entry #91

Merged
greg merged 2 commits from feature/ldap_services into master 2023-03-01 09:57:53 +00:00
Conversation 1 Commits 2 Files Changed 7
+234 -66
raucao commented 2023-02-27 15:49:43 +00:00
Owner
Copy Link
Copy Source

Add a new service attribute to LDAP user entries, as well as methods to enable and disable services. This can then be used in LDAP filters for the various services to only allow users with the enabled service to actually log in.

New users automatically get the entries added when confirming their account. Once services are configured to check for the new attribute/role, this also fixes the current problem of users being able to log in to services before having confirmed their email address.

Adding default services for existing users in production should be easy with the Rails console:

User.confirmed.each { |u| u.devise_after_confirmation }
Add a new service attribute to LDAP user entries, as well as methods to enable and disable services. This can then be used in LDAP filters for the various services to only allow users with the enabled service to actually log in. New users automatically get the entries added when confirming their account. Once services are configured to check for the new attribute/role, this also fixes the current problem of users being able to log in to services before having confirmed their email address. Adding default services for existing users in production should be easy with the Rails console: ```ruby User.confirmed.each { |u| u.devise_after_confirmation } ```
raucao added the feature label 2023-02-27 15:49:43 +00:00
raucao added 1 commit 2023-02-27 15:49:44 +00:00
Add service attribute to LDAP user entry
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
75ffd4e2f1
raucao requested review from greg 2023-02-27 15:49:51 +00:00
raucao requested review from galfert 2023-02-27 15:49:52 +00:00
raucao added the kredits-2 label 2023-02-27 15:52:40 +00:00
greg added 1 commit 2023-03-01 09:35:54 +00:00
Merge branch 'master' into feature/ldap_services
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
2861254adf
greg approved these changes 2023-03-01 09:57:40 +00:00
greg left a comment
Owner
Copy Link
Copy Source

👍

👍
greg merged commit c8b65de7f6 into master 2023-03-01 09:57:53 +00:00
greg deleted branch feature/ldap_services 2023-03-01 09:57:54 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
galfert
greg
Labels
Clear labels
integration
btcpay
integration
discourse
integration
ejabberd
integration
email
integration
ldap
integration
lndhub
integration
mastodon
integration
nostr
integration
remotestorage
bug
Something is not working
 design
Graphic/visual design
 dev environment
Config, builds, CI, deployment, etc.
 docs
Documentation
 duplicate
This issue or pull request already exists
 enhancement
Improving existing functionality
 feature
New functionality
 good first issue
Dive in, and start contributing
 idea
Something to consider
 invalid
Not a bug
 kredits-1
Small contribution
 kredits-2
Medium contribution
 kredits-3
Large contribution
 on hold
Currently not actionable
 ops
Manual IT ops activities
 question
Looking for an answer
release
major
release
minor
release
patch
security
All your base are belong to us
 ui/ux
User interface, process design, etc.
 wontfix
This won't be fixed
No labels feature kredits-2
Milestone
No items
No Milestone
Assignees
Clear assignees
bkero (bkero) bumi (bumi) fsmanuel (fsmanuel) galfert (galfert) greg (Greg) hueso (hueso) raucao (Râu Cao) slvrbckt (Nick Jennings)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kosmos/akkounts#91