From aedaabc7ba86a25f173c995f41389c573548bbf4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C3=A2u=20Cao?= <raucao@kip.pe>
Date: Mon, 12 Jun 2023 18:18:06 +0200
Subject: [PATCH 1/4] Offer lnurl-pay QR codes for download on the Lightning
 page

---
 Gemfile                                       |  3 +
 Gemfile.lock                                  |  3 +
 .../services/lightning_controller.rb          | 57 ++++++++++++++++---
 app/views/services/lightning/index.html.erb   | 20 ++++++-
 config/routes.rb                              |  1 +
 5 files changed, 75 insertions(+), 9 deletions(-)

diff --git a/Gemfile b/Gemfile
index dad66b1..2985570 100644
--- a/Gemfile
+++ b/Gemfile
@@ -58,6 +58,9 @@ gem 'discourse_api'
 gem "sentry-ruby"
 gem "sentry-rails"
 
+# Lightning
+gem "lnurl"
+
 group :development, :test do
   # Use sqlite3 as the database for Active Record
   gem 'sqlite3', '~> 1.4'
diff --git a/Gemfile.lock b/Gemfile.lock
index 6b33fa8..211008a 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -180,6 +180,8 @@ GEM
     listen (3.7.1)
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
+    lnurl (1.0.1)
+      bech32 (~> 1.1)
     lockbox (1.1.0)
     loofah (2.19.0)
       crass (~> 1.0.2)
@@ -409,6 +411,7 @@ DEPENDENCIES
   letter_opener
   letter_opener_web
   listen (~> 3.2)
+  lnurl
   lockbox
   net-ldap
   pagy (~> 6.0, >= 6.0.2)
diff --git a/app/controllers/services/lightning_controller.rb b/app/controllers/services/lightning_controller.rb
index 44a4589..e38445b 100644
--- a/app/controllers/services/lightning_controller.rb
+++ b/app/controllers/services/lightning_controller.rb
@@ -1,4 +1,5 @@
 require "rqrcode"
+require "lnurl"
 
 class Services::LightningController < ApplicationController
   before_action :authenticate_user!
@@ -8,9 +9,55 @@ class Services::LightningController < ApplicationController
 
   def index
     @wallet_url = "lndhub://#{current_user.ln_account}:#{current_user.ln_password}@#{ENV['LNDHUB_PUBLIC_URL']}"
+    initialize_lndhub_qr_code
+  end
 
-    qrcode = RQRCode::QRCode.new(@wallet_url)
-    @svg = qrcode.as_svg(
+  def transactions
+    @transactions = fetch_transactions
+  end
+
+  def qr_lnurlp
+    lnurlp_url = "https://kosmos.org/.well-known/lnurlp/#{current_user.cn}"
+    lnurlp_bech32 = Lnurl.new(lnurlp_url).to_bech32
+    qr_code = RQRCode::QRCode.new("lightning:" + lnurlp_bech32)
+
+    if params[:format] == "svg"
+      qr_svg = qr_code.as_svg(
+        color: "000",
+        shape_rendering: "crispEdges",
+        module_size: 6,
+        standalone: true,
+        use_path: true,
+        svg_attributes: {
+          class: 'inline-block'
+        }
+      )
+      send_data(
+        qr_svg,
+        filename: "bitcoin-lightning-#{current_user.address}.svg",
+        type: "image/svg+xml"
+      )
+    elsif params[:format] == "png"
+      qr_png = qr_code.as_png(
+        fill: "white",
+        color: "black",
+        size: 1024,
+      )
+      send_data(
+        qr_png,
+        filename: "bitcoin-lightning-#{current_user.address}.png",
+        type: "image/png"
+      )
+    else
+      http_status :not_found
+    end
+  end
+
+  private
+
+  def initialize_lndhub_qr_code
+    qr_code = RQRCode::QRCode.new(@wallet_url)
+    @lndhub_qr_svg = qr_code.as_svg(
       color: "000",
       shape_rendering: "crispEdges",
       module_size: 6,
@@ -22,12 +69,6 @@ class Services::LightningController < ApplicationController
     )
   end
 
-  def transactions
-    @transactions = fetch_transactions
-  end
-
-  private
-
   def authenticate_with_lndhub(options={})
     if session[:ln_auth_token].present? && !options[:force_reauth]
       @ln_auth_token = session[:ln_auth_token]
diff --git a/app/views/services/lightning/index.html.erb b/app/views/services/lightning/index.html.erb
index fda9558..9eff3ce 100644
--- a/app/views/services/lightning/index.html.erb
+++ b/app/views/services/lightning/index.html.erb
@@ -39,7 +39,7 @@
       <button id="hide-setup-code" class="hidden btn-md btn-blue w-full sm:w-auto">Hide setup QR code</button>
     </p>
     <p id="setup-code" class="hidden my-10 w-full text-center">
-      <%= raw @svg %>
+      <%= raw @lndhub_qr_svg %>
     </p>
   </section>
 
@@ -88,6 +88,24 @@
       </p>
     </div>
   </section>
+
+  <section class="mb-12">
+    <h3>QR Code for Donations/Tips</h3>
+    <p>
+      You can print out or publish a QR code for people to scan with their
+      wallet apps, so they can send you sats without a direct personal
+      interaction (for example at a concert, or on your website).
+    </p>
+    <p class="my-6 text-center md:text-left">
+      <%= link_to "Download SVG file",
+                  qr_lnurlp_services_lightning_index_path(format: "svg"),
+                  class: "btn-md btn-blue w-full sm:w-auto"%>
+      <span class="mx-2 my-2 md:my-0 block md:inline">or</span>
+      <%= link_to "Download PNG file",
+                  qr_lnurlp_services_lightning_index_path(format: "png"),
+                  class: "btn-md btn-blue w-full sm:w-auto"%>
+    </p>
+  </section>
 <% end %>
 
 <script type="text/javascript">
diff --git a/config/routes.rb b/config/routes.rb
index 684f386..8f57b1a 100644
--- a/config/routes.rb
+++ b/config/routes.rb
@@ -24,6 +24,7 @@ Rails.application.routes.draw do
     resources :lightning, only: [:index] do
       collection do
         get 'transactions'
+        get 'qr_lnurlp'
       end
     end
   end
-- 
2.25.1


From 07fe8dba714496b001cbf0283ce298fd1b1517c2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C3=A2u=20Cao?= <raucao@kip.pe>
Date: Mon, 12 Jun 2023 18:18:47 +0200
Subject: [PATCH 2/4] Add a copy button for the Lightning address

Same as on profile settings page.
---
 app/views/services/lightning/index.html.erb | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

diff --git a/app/views/services/lightning/index.html.erb b/app/views/services/lightning/index.html.erb
index 9eff3ce..6d18379 100644
--- a/app/views/services/lightning/index.html.erb
+++ b/app/views/services/lightning/index.html.erb
@@ -7,13 +7,25 @@
 
   <section>
     <h3>Lightning Address</h3>
-    <p>
+    <p class="mb-6">
       Your Kosmos user address is also a
       <a class="ks-text-link" href="https://lightningaddress.com/" target="_blank">Lightning Address</a>!
       The easiest way to receive sats is by just giving out your address:
     </p>
-    <p>
-      <strong><%= current_user.address %></strong>
+    <p data-controller="clipboard" class="flex gap-1 sm:w-2/5">
+      <input type="text" id="user_address" class="grow"
+             value=<%= current_user.address %> disabled="disabled"
+             data-clipboard-target="source" />
+      <button id="copy-user-address" class="btn-md btn-icon btn-blue shrink-0"
+              data-clipboard-target="trigger" data-action="clipboard#copy"
+              title="Copy to clipboard">
+        <span class="content-initial">
+          <%= render partial: "icons/copy", locals: { custom_class: "text-white h-4 w-4 inline" } %>
+        </span>
+        <span class="content-active hidden">
+          <%= render partial: "icons/check", locals: { custom_class: "text-white h-4 w-4 inline" } %>
+        </span>
+      </button>
     </p>
   </section>
 
-- 
2.25.1


From 332ad757a5be6607cd234c4b5e733f1660e0c62a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C3=A2u=20Cao?= <raucao@kip.pe>
Date: Tue, 13 Jun 2023 12:30:38 +0200
Subject: [PATCH 3/4] Use respond_to for request formats

---
 .../services/lightning_controller.rb          | 65 ++++++++++---------
 1 file changed, 33 insertions(+), 32 deletions(-)

diff --git a/app/controllers/services/lightning_controller.rb b/app/controllers/services/lightning_controller.rb
index e38445b..386c950 100644
--- a/app/controllers/services/lightning_controller.rb
+++ b/app/controllers/services/lightning_controller.rb
@@ -17,39 +17,40 @@ class Services::LightningController < ApplicationController
   end
 
   def qr_lnurlp
-    lnurlp_url = "https://kosmos.org/.well-known/lnurlp/#{current_user.cn}"
-    lnurlp_bech32 = Lnurl.new(lnurlp_url).to_bech32
-    qr_code = RQRCode::QRCode.new("lightning:" + lnurlp_bech32)
+    respond_to do |format|
+      lnurlp_url = "https://kosmos.org/.well-known/lnurlp/#{current_user.cn}"
+      lnurlp_bech32 = Lnurl.new(lnurlp_url).to_bech32
+      qr_code = RQRCode::QRCode.new("lightning:" + lnurlp_bech32)
 
-    if params[:format] == "svg"
-      qr_svg = qr_code.as_svg(
-        color: "000",
-        shape_rendering: "crispEdges",
-        module_size: 6,
-        standalone: true,
-        use_path: true,
-        svg_attributes: {
-          class: 'inline-block'
-        }
-      )
-      send_data(
-        qr_svg,
-        filename: "bitcoin-lightning-#{current_user.address}.svg",
-        type: "image/svg+xml"
-      )
-    elsif params[:format] == "png"
-      qr_png = qr_code.as_png(
-        fill: "white",
-        color: "black",
-        size: 1024,
-      )
-      send_data(
-        qr_png,
-        filename: "bitcoin-lightning-#{current_user.address}.png",
-        type: "image/png"
-      )
-    else
-      http_status :not_found
+      format.svg do
+        qr_svg = qr_code.as_svg(
+          color: "000",
+          shape_rendering: "crispEdges",
+          module_size: 6,
+          standalone: true,
+          use_path: true,
+          svg_attributes: {
+            class: 'inline-block'
+          }
+        )
+        send_data(
+          qr_svg,
+          filename: "bitcoin-lightning-#{current_user.address}.svg",
+          type: "image/svg+xml"
+        )
+      end
+      format.png do
+        qr_png = qr_code.as_png(
+          fill: "white",
+          color: "black",
+          size: 1024,
+        )
+        send_data(
+          qr_png,
+          filename: "bitcoin-lightning-#{current_user.address}.png",
+          type: "image/png"
+        )
+      end
     end
   end
 
-- 
2.25.1


From d922e7f86909e6b19ff9ab8484113f1d18ac8918 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?R=C3=A2u=20Cao?= <raucao@kip.pe>
Date: Tue, 20 Jun 2023 18:18:14 +0200
Subject: [PATCH 4/4] Resolve review comment

---
 app/controllers/services/lightning_controller.rb | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/app/controllers/services/lightning_controller.rb b/app/controllers/services/lightning_controller.rb
index 386c950..94aed24 100644
--- a/app/controllers/services/lightning_controller.rb
+++ b/app/controllers/services/lightning_controller.rb
@@ -17,11 +17,11 @@ class Services::LightningController < ApplicationController
   end
 
   def qr_lnurlp
-    respond_to do |format|
-      lnurlp_url = "https://kosmos.org/.well-known/lnurlp/#{current_user.cn}"
-      lnurlp_bech32 = Lnurl.new(lnurlp_url).to_bech32
-      qr_code = RQRCode::QRCode.new("lightning:" + lnurlp_bech32)
+    lnurlp_url = "https://kosmos.org/.well-known/lnurlp/#{current_user.cn}"
+    lnurlp_bech32 = Lnurl.new(lnurlp_url).to_bech32
+    qr_code = RQRCode::QRCode.new("lightning:" + lnurlp_bech32)
 
+    respond_to do |format|
       format.svg do
         qr_svg = qr_code.as_svg(
           color: "000",
-- 
2.25.1