kosmos/akkounts
8
1
Fork 0
Code Issues 22 Pull Requests 1 Actions Packages Releases 12 Activity

Add Webhooks and XMPP notifications for incoming sats #79

Merged
raucao merged 10 commits from feature/webhooks into master 2023-01-13 04:33:02 +00:00
Conversation 1 Commits 10 Files Changed 17 +1 -1
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 4c0d8283e3 - Show all commits

2
app/controllers/webhooks_controller.rb
View File

@@ -6,7 +6,7 @@ class WebhooksController < ApplicationController
def lndhub
begin
payload = JSON.parse(request.body.read, symbolize_names: true)
raucao marked this conversation as resolved
bumi commented 2023-01-13 00:11:07 +00:00
Review
Copy Link

doesn't rails automatically parse the JSON because the proper content type is set?
so params[:type] and params[:user_login] should be enough?

doesn't rails automatically parse the JSON because the proper content type is set? so `params[:type]` and `params[:user_login]` should be enough?
raucao commented 2023-01-13 04:23:45 +00:00
Review
Copy Link

I didn't know, so I tried (also with explicitly setting the content type in the spec). Doesn't do it.

I didn't know, so I tried (also with explicitly setting the content type in the spec). Doesn't do it.
return unless payload[:type] == "incoming"
head :no_content and return unless payload[:type] == "incoming"
rescue
head :unprocessable_entity and return
end